public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libfortran/47431] New: ctime() not thread-safe
@ 2011-01-24 10:41 jb at gcc dot gnu.org
2011-01-24 11:13 ` [Bug libfortran/47431] " jb at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: jb at gcc dot gnu.org @ 2011-01-24 10:41 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431
Summary: ctime() not thread-safe
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libfortran
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: jb@gcc.gnu.org
In libgfortran/intrinsics/ctime.c we call the POSIX ctime() function, which
need not be thread safe. Instead, we should use ctime_r() if available.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libfortran/47431] ctime() not thread-safe
2011-01-24 10:41 [Bug libfortran/47431] New: ctime() not thread-safe jb at gcc dot gnu.org
@ 2011-01-24 11:13 ` jb at gcc dot gnu.org
2011-01-27 15:23 ` burnus at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jb at gcc dot gnu.org @ 2011-01-24 11:13 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431
Janne Blomqvist <jb at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2011.01.24 09:55:30
AssignedTo|unassigned at gcc dot |jb at gcc dot gnu.org
|gnu.org |
Ever Confirmed|0 |1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libfortran/47431] ctime() not thread-safe
2011-01-24 10:41 [Bug libfortran/47431] New: ctime() not thread-safe jb at gcc dot gnu.org
2011-01-24 11:13 ` [Bug libfortran/47431] " jb at gcc dot gnu.org
@ 2011-01-27 15:23 ` burnus at gcc dot gnu.org
2011-01-27 15:34 ` burnus at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: burnus at gcc dot gnu.org @ 2011-01-27 15:23 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |burnus at gcc dot gnu.org
--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-01-27 15:19:22 UTC ---
Janne's patch: http://gcc.gnu.org/ml/fortran/2011-01/msg00224.html
There is an POSIX-version issue (draft and final) on Solaris,
cf. http://gcc.gnu.org/ml/fortran/2011-01/msg00248.html (or related PRs 47491
and 47432).
Rainer Orth wrote:
* full standard:
extern char *ctime_r(const time_t *, char *);
* draft standards:
extern char *ctime_r(const time_t *, char *, int);
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libfortran/47431] ctime() not thread-safe
2011-01-24 10:41 [Bug libfortran/47431] New: ctime() not thread-safe jb at gcc dot gnu.org
2011-01-24 11:13 ` [Bug libfortran/47431] " jb at gcc dot gnu.org
2011-01-27 15:23 ` burnus at gcc dot gnu.org
@ 2011-01-27 15:34 ` burnus at gcc dot gnu.org
2011-01-27 20:42 ` jb at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: burnus at gcc dot gnu.org @ 2011-01-27 15:34 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431
--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-01-27 15:21:48 UTC ---
(In reply to comment #1)
> (or related PRs 47491 and 47432).
(did not link. Try harder:)
PR 47491 - bootstrap error for GETLOG's getpwuid_r
Cf. solution ideas at
http://gcc.gnu.org/ml/fortran/2011-01/msg00245.html
PR 47432 - ttyname_r issue (not committed)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libfortran/47431] ctime() not thread-safe
2011-01-24 10:41 [Bug libfortran/47431] New: ctime() not thread-safe jb at gcc dot gnu.org
` (2 preceding siblings ...)
2011-01-27 15:34 ` burnus at gcc dot gnu.org
@ 2011-01-27 20:42 ` jb at gcc dot gnu.org
2011-01-27 21:03 ` jb at gcc dot gnu.org
2011-02-02 18:12 ` dnovillo at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jb at gcc dot gnu.org @ 2011-01-27 20:42 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431
--- Comment #3 from Janne Blomqvist <jb at gcc dot gnu.org> 2011-01-27 20:22:46 UTC ---
Author: jb
Date: Thu Jan 27 20:22:37 2011
New Revision: 169338
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169338
Log:
Pr 47431 CTIME/FDATE thread-safety using ctime_r()
Modified:
trunk/libgfortran/ChangeLog
trunk/libgfortran/config.h.in
trunk/libgfortran/configure
trunk/libgfortran/configure.ac
trunk/libgfortran/intrinsics/ctime.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libfortran/47431] ctime() not thread-safe
2011-01-24 10:41 [Bug libfortran/47431] New: ctime() not thread-safe jb at gcc dot gnu.org
` (3 preceding siblings ...)
2011-01-27 20:42 ` jb at gcc dot gnu.org
@ 2011-01-27 21:03 ` jb at gcc dot gnu.org
2011-02-02 18:12 ` dnovillo at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jb at gcc dot gnu.org @ 2011-01-27 21:03 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431
Janne Blomqvist <jb at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #4 from Janne Blomqvist <jb at gcc dot gnu.org> 2011-01-27 20:25:42 UTC ---
Fixed, closing.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libfortran/47431] ctime() not thread-safe
2011-01-24 10:41 [Bug libfortran/47431] New: ctime() not thread-safe jb at gcc dot gnu.org
` (4 preceding siblings ...)
2011-01-27 21:03 ` jb at gcc dot gnu.org
@ 2011-02-02 18:12 ` dnovillo at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: dnovillo at gcc dot gnu.org @ 2011-02-02 18:12 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431
--- Comment #5 from Diego Novillo <dnovillo at gcc dot gnu.org> 2011-02-02 17:58:08 UTC ---
Author: dnovillo
Date: Wed Feb 2 17:58:02 2011
New Revision: 169655
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169655
Log:
Pr 47431 CTIME/FDATE thread-safety using ctime_r()
Modified:
branches/google/integration/libgfortran/ChangeLog
branches/google/integration/libgfortran/config.h.in
branches/google/integration/libgfortran/configure
branches/google/integration/libgfortran/configure.ac
branches/google/integration/libgfortran/intrinsics/ctime.c
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-02-02 18:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-24 10:41 [Bug libfortran/47431] New: ctime() not thread-safe jb at gcc dot gnu.org
2011-01-24 11:13 ` [Bug libfortran/47431] " jb at gcc dot gnu.org
2011-01-27 15:23 ` burnus at gcc dot gnu.org
2011-01-27 15:34 ` burnus at gcc dot gnu.org
2011-01-27 20:42 ` jb at gcc dot gnu.org
2011-01-27 21:03 ` jb at gcc dot gnu.org
2011-02-02 18:12 ` dnovillo at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).