[Bug fortran/47469] New: Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[Bug fortran/47469] New: Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

           Summary: Check whether arrayfunc_assign_needs_temporary misses
                    TBP/PPC attributes
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: burnus@gcc.gnu.org
                CC: pault@gcc.gnu.org, janus@gcc.gnu.org


Found when looking at PR 47455 and trans-expr.c:

I wonder whether for type-bound procedures or for procedure-pointer components,
the "pointer" or "allocatable" attribute is properly taken into account in
arrayfunc_assign_needs_temporary.

However, I have not checked whether this is an really and issue or whether
there are other related issues.

Thus, something like:

--- a/gcc/fortran/trans-expr.c
+++ b/gcc/fortran/trans-expr.c
@@ -5346,8 +5381,8 @@ arrayfunc_assign_needs_temporary (gfc_expr * expr1,
gfc_expr * expr2)
     return true;

   /* Functions returning pointers need temporaries.  */
-  if (expr2->symtree->n.sym->attr.pointer
-      || expr2->symtree->n.sym->attr.allocatable)
+  if (gfc_expr_attr (expr2).pointer
+      || gfc_expr_attr (expr2).allocatable)
     return true;

   /* Character array functions need temporaries unless the

[Bug fortran/47469] Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2015-10-13
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
On trunk (6.0 r228753) this has been changed to

  /* Functions returning pointers or allocatables need temporaries.  */
  c = expr2->value.function.esym
      ? (expr2->value.function.esym->attr.pointer
         || expr2->value.function.esym->attr.allocatable)
      : (expr2->symtree->n.sym->attr.pointer
         || expr2->symtree->n.sym->attr.allocatable);
  if (c)
    return true;

Any point to keep this PR opened?

[Bug fortran/47469] Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

--- Comment #2 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #1)
> On trunk (6.0 r228753) this has been changed to
> 
>   /* Functions returning pointers or allocatables need temporaries.  */
>   c = expr2->value.function.esym
>       ? (expr2->value.function.esym->attr.pointer
>          || expr2->value.function.esym->attr.allocatable)
>       : (expr2->symtree->n.sym->attr.pointer
>          || expr2->symtree->n.sym->attr.allocatable);
>   if (c)
>     return true;
> 
> Any point to keep this PR opened?

Tobias' version is prettier! Does it apply without regressions?

Cheers

Paul

[Bug fortran/47469] Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Tobias' version is prettier! Does it apply without regressions?

Obviously the patch in comment 0 no longer applies.

Now finding 'gfc_expr_attr (expr2).pointer' prettier than
'expr2->symtree->n.sym->attr.pointer' is just a matter of taste (29 characters
compared to 35). For a newbie like the later is easier to understand than the
former.

BTW what should it be for 'value.function.esym'?

[Bug fortran/47469] Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Well, this PR has been rotting for more than four years and a half. I was only
pointing to the fact that the initial patch no longer applies.

If you know what to do, please do so. If not, I don't see the point to keep it
open for  the next decade.

[Bug fortran/47469] Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

--- Comment #6 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #5)
> Well, this PR has been rotting for more than four years and a half. I was
> only pointing to the fact that the initial patch no longer applies.
> 
> If you know what to do, please do so. If not, I don't see the point to keep
> it open for  the next decade.

I'll take a look over the weekend.

Thanks for your efforts to weed out some of the PRs that have passed their
sell-by date. It's much appreciated.

Paul

[Bug fortran/47469] Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
No feedback after four more years!-(

[Bug fortran/47469] Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

--- Comment #9 from Paul Thomas <pault at gcc dot gnu.org> ---
Tobias's original suggestion is certainly more concise, although equivalent to
the present code.

I will commit the change today or tomorrow as obvious. It happens that I am
working on trans-expr.c at the moment and so will have to reset my tree to deal
with this.

Regards

Paul

[Bug fortran/47469] Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:7c7e841806aecf4187c69fc2ff07813c7be09582

commit r11-3702-g7c7e841806aecf4187c69fc2ff07813c7be09582
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Wed Oct 7 14:59:10 2020 +0100

    This patch fixes PR47469 - a trivial bit of tidying up.

    2020-07-10  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/47469
            * trans-expr.c (arrayfunc_assign_needs_temporary): Tidy detection
            of pointer and allocatable functions.

[Bug fortran/47469] Check whether arrayfunc_assign_needs_temporary misses TBP/PPC attributes

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47469

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|WAITING                     |RESOLVED

--- Comment #11 from Paul Thomas <pault at gcc dot gnu.org> ---
Fixed after a mere 3542 days.

Thanks for the report :-)

Paul