[Bug c/47492] New: problem with memset() inside transaction_safe function

[Bug c/47492] New: problem with memset() inside transaction_safe function

[vasilis.karakostas at bsc dot es]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47492

           Summary: problem with memset() inside transaction_safe function
           Product: gcc
           Version: trans-mem
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: vasilis.karakostas@bsc.es
                CC: aldyh@redhat.com, javier.arias@bsc.es,
                    patrick.marlier@gmail.com


Created attachment 23141
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23141
testcase

When I call memset() function from an __attribute__((transaction_safe))
function, I get compilation error.

testcase.c:10:2: error: unsafe function call 'memset' within 'transaction_safe'
function

According to Intel TM ABI, the memset() function is managed by the compiler and
it should be automatically transformed to be transaction safe.
I have attached an example.

[Bug c/47492] [trans-mem] Problem with memset() inside transaction_safe function

[patrick.marlier at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47492

--- Comment #1 from Patrick Marlier <patrick.marlier at gmail dot com> 2011-01-27 15:10:18 UTC ---
Created attachment 23143
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23143
draft patch

This patch makes it work but:
(trans-mem.c) 
examine_call_tm(): I don't know if it is require to test for BUILT_IN_TM_MEMSET
because it is never reached.
expand_call_tm(): it is required to mark the transaction having transactional
stores but should it be also done for MEMCPY/MEMMOVE?

[Bug c/47492] [trans-mem] Problem with memset() inside transaction_safe function

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47492

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2011.01.31 18:21:35
                 CC|                            |aldyh at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #2 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2011-01-31 18:21:35 UTC ---
Fixed here:
http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02325.html

Awaiting approval.

[Bug c/47492] [trans-mem] Problem with memset() inside transaction_safe function

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47492

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED