[Bug ada/47500] New: mips-*-rtems*: -G0 option not recognized by gnat1

[Bug ada/47500] New: mips-*-rtems*: -G0 option not recognized by gnat1

[joel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

           Summary: mips-*-rtems*: -G0 option not recognized by gnat1
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: joel@gcc.gnu.org


The checking for arguments passed to gnat1 does not allow for -Gn which is used
on at least the mips.  

$ mips-rtems4.11-gcc -c -march=r3900  -G0 -fstack-check -O -O2
-I/users/joel/test-gcc/gcc-svn/gcc/testsuite/ada/acats/work-jmr3904/support
a22006b.adb
Usage: gnat1 switches sfile

  sfile     Source file name

..................

$ mips-rtems4.11-gcc -c -march=r3900  -fstack-check -O -O2
-I/users/joel/test-gcc/gcc-svn/gcc/testsuite/ada/acats/work-jmr3904/support
a22006b.adb

This switch is meaningful on at least the MIPS and PowerPC.  

`-G NUM'
     On embedded PowerPC systems, put global and static items less than
     or equal to NUM bytes into the small data or bss sections instead
     of the normal data or bss section.  By default, NUM is 8.  The `-G
     NUM' switch is also passed to the linker.  All modules should be
     compiled with the same `-G NUM' value.

I thought that adding 'G' to the list around line 204 of switch-m.adb
would have addressed it but I must not be looking in the right place.

Hints or tiny patch appreciated.

[Bug ada/47500] -G0 option not recognized by gnat1

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |mips-*-rtems
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
            Summary|mips-*-rtems*: -G0 option   |-G0 option not recognized
                   |not recognized by gnat1     |by gnat1

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-01-28 07:50:08 UTC ---
> Hints or tiny patch appreciated.

You need to find out whether/how this works for the C compiler.

[Bug ada/47500] -G0 option not recognized by gnat1

[joel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

--- Comment #2 from Joel Sherrill <joel at gcc dot gnu.org> 2011-01-28 16:56:34 UTC ---
(In reply to comment #1)
> > Hints or tiny patch appreciated.
> 
> You need to find out whether/how this works for the C compiler.

What do you mean?  It dictates the maximum size of objects placed in sbss and
sdata sections.  So -Gnumber is accepted by cc1.

[Bug ada/47500] -G0 option not recognized by gnat1

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-01-28 20:05:08 UTC ---
Hmm, isn't the option "-G 0" and not "-G0" ?

[Bug ada/47500] -G0 option not recognized by gnat1

[joel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

--- Comment #4 from Joel Sherrill <joel at gcc dot gnu.org> 2011-01-28 21:18:17 UTC ---
(In reply to comment #3)
> Hmm, isn't the option "-G 0" and not "-G0" ?

We have been using -G0 for years with the rtems mips BSPs and gcc happily
accepts it.  The parsing of it must be forgiving. :)

[Bug ada/47500] -G0 option not recognized by gnat1

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-01-30 22:28:40 UTC ---
> What do you mean?  It dictates the maximum size of objects placed in sbss and
> sdata sections.  So -Gnumber is accepted by cc1.

The question is, how does it accept it?

[Bug target/47500] -G0 option not recognized by gnat1

[linux at schildmann dot info]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

Peter Schildmann <linux at schildmann dot info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |linux at schildmann dot
                   |                            |info

--- Comment #6 from Peter Schildmann <linux at schildmann dot info> 2011-09-05 19:45:27 UTC ---
diff --git a/gcc/ada/back_end.adb b/gcc/ada/back_end.adb
index 7172696..fdd06f1 100644
--- a/gcc/ada/back_end.adb
+++ b/gcc/ada/back_end.adb
@@ -206,6 +206,7 @@ package body Back_End is
          --  Skip -o or internal GCC switches together with their argument

          if Switch_Chars (First .. Last) = "o"
+           or else Switch_Chars (First .. Last) = "G"
            or else Is_Internal_GCC_Switch (Switch_Chars)
          then
             Next_Arg := Next_Arg + 1;

[Bug target/47500] -G0 option not recognized by gnat1

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-11-06
   Target Milestone|---                         |4.8.4
     Ever confirmed|0                           |1

--- Comment #7 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
We should fix this.

[Bug target/47500] -G0 option not recognized by gnat1

[charlet at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

--- Comment #8 from Arnaud Charlet <charlet at gcc dot gnu.org> ---
Author: charlet
Date: Thu Nov 20 11:55:25 2014
New Revision: 217849

URL: https://gcc.gnu.org/viewcvs?rev=217849&root=gcc&view=rev
Log:
2014-11-20  Vincent Celier  <celier@adacore.com>

    PR ada/47500
    * back_end.adb (Scan_Back_End_Switches): Skip switch -G and
    its argument.


Modified:
    trunk/gcc/ada/back_end.adb

[Bug target/47500] -G0 option not recognized by gnat1

[charlet at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

Arnaud Charlet <charlet at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |charlet at gcc dot gnu.org
         Resolution|---                         |FIXED
   Target Milestone|4.8.4                       |5.0

--- Comment #9 from Arnaud Charlet <charlet at gcc dot gnu.org> ---
Fixed on trunk

[Bug target/47500] -G0 option not recognized by gnat1

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

--- Comment #10 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Sat Nov 22 11:28:56 2014
New Revision: 217962

URL: https://gcc.gnu.org/viewcvs?rev=217962&root=gcc&view=rev
Log:
    Backport from mainline
    2014-11-20  Vincent Celier  <celier@adacore.com>

    PR ada/47500
    * back_end.adb (Scan_Back_End_Switches): Skip switch -G and
    its argument.

Modified:
    branches/gcc-4_9-branch/gcc/ada/ChangeLog
    branches/gcc-4_9-branch/gcc/ada/back_end.adb

[Bug target/47500] -G0 option not recognized by gnat1

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

--- Comment #11 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Sat Nov 22 11:29:27 2014
New Revision: 217963

URL: https://gcc.gnu.org/viewcvs?rev=217963&root=gcc&view=rev
Log:
    Backport from mainline
    2014-11-20  Vincent Celier  <celier@adacore.com>

    PR ada/47500
    * back_end.adb (Scan_Back_End_Switches): Skip switch -G and
    its argument.

Modified:
    branches/gcc-4_8-branch/gcc/ada/ChangeLog
    branches/gcc-4_8-branch/gcc/ada/back_end.adb

[Bug target/47500] -G0 option not recognized by gnat1

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47500

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.0                         |4.8.4

--- Comment #12 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Fixed on all active branches.