public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/47581] [4.6 regression] Unnecessary adjustments to stack pointer Date: Wed, 02 Feb 2011 11:23:00 -0000 [thread overview] Message-ID: <bug-47581-4-6vCG6ijiQL@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-47581-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47581 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-02 11:23:18 UTC --- Before Richard's commit apparently expand_one_var wasn't updating stack_alignment_needed, just stack_alignment_estimated, now it updates both. As PREFERRED_STACK_BOUNDARY is 128 (the default), ix86_minimum_alignment: if (TARGET_64BIT || align != 64 || ix86_preferred_stack_boundary >= 64) return align; returns 64 instead of 32. So, to fix this, either the stack_alignment_needed updating in expand_one_var isn't strictly necessary and we could undo that part of the changes. Or return 32 as MINIMUM_ALIGNMENT for DImode long long even for ix86_preferred_stack_boundary >= 64. Or we could perhaps the /* Align start of frame for local function. */ offset = (offset + stack_alignment_needed - 1) & -stack_alignment_needed; in ix86_compute_frame_layout perform only if if (offset != frame->sse_reg_save_offset || size != 0 || !current_function_is_leaf || cfun->calls_alloca || ix86_current_function_calls_tls_descriptor) (i.e. if frame size is 0 and no outgoing calls, it doesn't make sense to align).
next prev parent reply other threads:[~2011-02-02 11:23 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-01 21:27 [Bug rtl-optimization/47581] New: " tony.poppleton at gmail dot com 2011-02-01 22:56 ` [Bug rtl-optimization/47581] " rguenth at gcc dot gnu.org 2011-02-01 23:20 ` [Bug middle-end/47581] " hjl.tools at gmail dot com 2011-02-02 11:23 ` jakub at gcc dot gnu.org [this message] 2011-02-02 12:12 ` rguenth at gcc dot gnu.org 2011-02-02 12:25 ` jakub at gcc dot gnu.org 2011-02-02 13:52 ` jakub at gcc dot gnu.org 2011-02-02 14:18 ` hjl.tools at gmail dot com 2011-02-02 14:57 ` hjl.tools at gmail dot com 2011-02-02 15:05 ` [Bug middle-end/47581] [4.5/4.6 " hjl.tools at gmail dot com 2011-02-02 15:14 ` jakub at gcc dot gnu.org 2011-02-08 15:02 ` rguenth at gcc dot gnu.org 2011-02-15 11:53 ` jakub at gcc dot gnu.org 2011-02-15 13:05 ` [Bug middle-end/47581] [4.5 " jakub at gcc dot gnu.org 2011-03-25 20:01 ` jakub at gcc dot gnu.org 2011-06-27 15:52 ` jakub at gcc dot gnu.org 2011-10-26 17:46 ` jakub at gcc dot gnu.org 2012-03-01 15:04 ` jakub at gcc dot gnu.org 2012-03-01 20:29 ` pinskia at gcc dot gnu.org 2012-07-02 10:34 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-47581-4-6vCG6ijiQL@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).