public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/47581] [4.6 regression] Unnecessary adjustments to stack pointer
Date: Wed, 02 Feb 2011 14:57:00 -0000	[thread overview]
Message-ID: <bug-47581-4-MdPbQ6fM3V@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-47581-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47581

--- Comment #8 from H.J. Lu <hjl.tools at gmail dot com> 2011-02-02 14:57:22 UTC ---
For this tescase, gcc 4.4 generates the most efficient code
while 4.5/4.6 become worse and worse:

[hjl@gnu-6 gcc]$ cat x.i 
unsigned mulh(unsigned a, unsigned b)
{
  unsigned long long l __attribute__ ((aligned(32)))
    =((unsigned long long)a * (unsigned long long)b) >> 32;
  return l;
}
[hjl@gnu-6 gcc]$ /usr/gcc-4.4/bin/gcc -O2 -S -fomit-frame-pointer x.i -m32
[hjl@gnu-6 gcc]$ cat x.s 
    .file    "x.i"
    .text
    .p2align 4,,15
.globl mulh
    .type    mulh, @function
mulh:
    movl    8(%esp), %eax
    mull    4(%esp)
    movl    %edx, %eax
    ret
    .size    mulh, .-mulh
    .ident    "GCC: (GNU) 4.4.4"
    .section    .note.GNU-stack,"",@progbits
[hjl@gnu-6 gcc]$ /usr/gcc-4.5/bin/gcc -O2 -S -fomit-frame-pointer x.i -m32
[hjl@gnu-6 gcc]$ cat x.s
    .file    "x.i"
    .text
    .p2align 4,,15
.globl mulh
    .type    mulh, @function
mulh:
    pushl    %ebp
    movl    %esp, %ebp
    movl    12(%ebp), %eax
    mull    8(%ebp)
    popl    %ebp
    movl    %edx, %eax
    ret
    .size    mulh, .-mulh
    .ident    "GCC: (GNU) 4.5.1 20100507 (prerelease) [gcc-4_5-branch revision
159167]"
    .section    .note.GNU-stack,"",@progbits
[hjl@gnu-6 gcc]$ ./xgcc -B./  -O2 -S -fomit-frame-pointer x.i -m32
[hjl@gnu-6 gcc]$ cat x.s
    .file    "x.i"
    .text
    .p2align 4,,15
    .globl    mulh
    .type    mulh, @function
mulh:
.LFB0:
    .cfi_startproc
    pushl    %ebp
    .cfi_def_cfa_offset 8
    .cfi_offset 5, -8
    movl    %esp, %ebp
    .cfi_def_cfa_register 5
    andl    $-32, %esp
    movl    12(%ebp), %eax
    mull    8(%ebp)
    leave
    .cfi_restore 5
    .cfi_def_cfa 4, 4
    movl    %edx, %eax
    ret
    .cfi_endproc
.LFE0:
    .size    mulh, .-mulh
    .ident    "GCC: (GNU) 4.6.0 20110131 (experimental)"
    .section    .note.GNU-stack,"",@progbits
[hjl@gnu-6 gcc]$


  parent reply	other threads:[~2011-02-02 14:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 21:27 [Bug rtl-optimization/47581] New: " tony.poppleton at gmail dot com
2011-02-01 22:56 ` [Bug rtl-optimization/47581] " rguenth at gcc dot gnu.org
2011-02-01 23:20 ` [Bug middle-end/47581] " hjl.tools at gmail dot com
2011-02-02 11:23 ` jakub at gcc dot gnu.org
2011-02-02 12:12 ` rguenth at gcc dot gnu.org
2011-02-02 12:25 ` jakub at gcc dot gnu.org
2011-02-02 13:52 ` jakub at gcc dot gnu.org
2011-02-02 14:18 ` hjl.tools at gmail dot com
2011-02-02 14:57 ` hjl.tools at gmail dot com [this message]
2011-02-02 15:05 ` [Bug middle-end/47581] [4.5/4.6 " hjl.tools at gmail dot com
2011-02-02 15:14 ` jakub at gcc dot gnu.org
2011-02-08 15:02 ` rguenth at gcc dot gnu.org
2011-02-15 11:53 ` jakub at gcc dot gnu.org
2011-02-15 13:05 ` [Bug middle-end/47581] [4.5 " jakub at gcc dot gnu.org
2011-03-25 20:01 ` jakub at gcc dot gnu.org
2011-06-27 15:52 ` jakub at gcc dot gnu.org
2011-10-26 17:46 ` jakub at gcc dot gnu.org
2012-03-01 15:04 ` jakub at gcc dot gnu.org
2012-03-01 20:29 ` pinskia at gcc dot gnu.org
2012-07-02 10:34 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-47581-4-MdPbQ6fM3V@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).