From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-345730-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 864 invoked by alias); 1 Feb 2011 21:27:43 -0000
Received: (qmail 856 invoked by uid 22791); 1 Feb 2011 21:27:42 -0000
X-SWARE-Spam-Status: No, hits=-2.6 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Feb 2011 21:27:38 +0000
From: "tony.poppleton at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/47581] New: [4.6 regression] Unnecessary adjustments to stack pointer
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tony.poppleton at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-47581-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Tue, 01 Feb 2011 21:27:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2011-02/txt/msg00196.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47581

           Summary: [4.6 regression] Unnecessary adjustments to stack
                    pointer
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: tony.poppleton@gmail.com


Whilst investigating PR4079 (which affects PPC), I found some strange
adjustments to the stack pointer when compiling with 4.6.0 (20110129) on x86.

For reference, the C code from that PR is:

unsigned mulh(unsigned a, unsigned b)
{
        return ((unsigned long long)a * (unsigned long long)b) >> 32;
}

On 4.5.2 using "-O2 -m32 -fomit-frame-pointer", this produced the following
succinct code:
mulh:
        movl    8(%esp), %eax
        mull    4(%esp)
        movl    %edx, %eax
        ret
        .size   mulh, .-mulh
        .ident  "GCC: (GNU) 4.5.2"

However on 4.6.0 with the same arguments:
mulh:
.LFB0:
        .cfi_startproc
        subl    $4, %esp           <== isn't this unnecessary?
        .cfi_def_cfa_offset 8
        movl    12(%esp), %eax     <== this could just be 8(%esp)
        mull    8(%esp)            <== this could just be 4(%esp)
        addl    $4, %esp           <== isn't this unnecessary?
        .cfi_def_cfa_offset 4
        movl    %edx, %eax
        ret
        .cfi_endproc
.LFE0:
        .size   mulh, .-mulh
        .ident  "GCC: (GNU) 4.6.0 20110129 (experimental)"