From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-358165-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 15011 invoked by alias); 28 May 2011 13:43:42 -0000
Received: (qmail 15002 invoked by uid 22791); 28 May 2011 13:43:41 -0000
X-SWARE-Spam-Status: No, hits=-2.7 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 May 2011 13:43:28 +0000
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/47601] [OOP] Internal Error: mio_component_ref(): Component not found
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: janus at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: janus at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: Status AssignedTo
Message-ID: <bug-47601-4-7GyElXdDnm@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-47601-4@http.gcc.gnu.org/bugzilla/>
References: <bug-47601-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Sat, 28 May 2011 14:19:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2011-05/txt/msg02832.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47601

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |janus at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #17 from janus at gcc dot gnu.org 2011-05-28 13:43:23 UTC ---
(In reply to comment #16)
> Janus, you know type extension better than me. Does one now needs to do:
>   if (!p && sym->attr.extension)
>     {
>       p = search (sym->components->ts.u.derived)
>       if (!p && sym->components->ts.u.derived->attr.extension)
>         p = search (sym->components->ts.u.derived->...)
> 
> or is this the wrong method?

Yes, sounds good. Also that's exactly what 'gfc_find_component' does, so I'd
propose the following patch:


Index: gcc/fortran/module.c
===================================================================
--- gcc/fortran/module.c    (revision 174030)
+++ gcc/fortran/module.c    (working copy)
@@ -2356,9 +2356,7 @@ mio_component_ref (gfc_component **cp, gfc_symbol
       if (sym->components != NULL && p->u.pointer == NULL)
     {
       /* Symbol already loaded, so search by name.  */
-      for (q = sym->components; q; q = q->next)
-        if (strcmp (q->name, name) == 0)
-          break;
+      q = gfc_find_component (sym, name, false, false);

       if (q == NULL)
         gfc_internal_error ("mio_component_ref(): Component not found");


This fixes the test case, but is not regtested.