From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-358184-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 17187 invoked by alias); 28 May 2011 15:23:40 -0000
Received: (qmail 17174 invoked by uid 22791); 28 May 2011 15:23:39 -0000
X-SWARE-Spam-Status: No, hits=-2.7 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 May 2011 15:23:24 +0000
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/47601] [OOP] Internal Error: mio_component_ref(): Component not found
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: janus at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: janus at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-47601-4-e24f51SiJc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-47601-4@http.gcc.gnu.org/bugzilla/>
References: <bug-47601-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Sat, 28 May 2011 15:49:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2011-05/txt/msg02851.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47601

--- Comment #21 from janus at gcc dot gnu.org 2011-05-28 15:23:22 UTC ---
Improved patch, makes the original test case work:

Index: gcc/fortran/module.c
===================================================================
--- gcc/fortran/module.c    (revision 174380)
+++ gcc/fortran/module.c    (working copy)
@@ -2356,14 +2356,10 @@ mio_component_ref (gfc_component **cp, gfc_symbol
       if (sym->components != NULL && p->u.pointer == NULL)
     {
       /* Symbol already loaded, so search by name.  */
-      for (q = sym->components; q; q = q->next)
-        if (strcmp (q->name, name) == 0)
-          break;
+      q = gfc_find_component (sym, name, true, true);

-      if (q == NULL)
-        gfc_internal_error ("mio_component_ref(): Component not found");
-
-      associate_integer_pointer (p, q);
+      if (q)
+        associate_integer_pointer (p, q);
     }

       /* Make sure this symbol will eventually be loaded.  */
Index: gcc/fortran/symbol.c
===================================================================
--- gcc/fortran/symbol.c    (revision 174380)
+++ gcc/fortran/symbol.c    (working copy)
@@ -1996,14 +1996,11 @@ gfc_find_component (gfc_symbol *sym, const char *n
 {
   gfc_component *p;

-  if (name == NULL)
+  if (name == NULL || sym == NULL)
     return NULL;
-
+  
   sym = gfc_use_derived (sym);

-  if (sym == NULL)
-    return NULL;
-
   for (p = sym->components; p; p = p->next)
     if (strcmp (p->name, name) == 0)
       break;