[Bug libstdc++/47662] New: [4.6 Regression] -fno-operator-names no longer works with STL headers

[Bug libstdc++/47662] New: [4.6 Regression] -fno-operator-names no longer works with STL headers

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

           Summary: [4.6 Regression] -fno-operator-names no longer works
                    with STL headers
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jakub@gcc.gnu.org


echo '#include <iostream>' | g++ -fno-operator-names -xc++ - -o /tmp/x.s

no longer works, as bits/c++config.h now uses
#if defined(_GLIBCXX_DEBUG) or defined(_GLIBCXX_PROFILE)

any reason why it can't use || instead of or?

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bkoz at gcc dot gnu.org,
                   |                            |paolo at gcc dot gnu.org
   Target Milestone|---                         |4.6.0

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.02.09 14:27:29
     Ever Confirmed|0                           |1

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-09 14:27:29 UTC ---
I'll fix it tonight if noone beats me to it.

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-09 14:32:50 UTC ---
I've also just noticed the manual for -fno-operator-names could do with some
improvement: those alternative tokens aren't technically keywords, they're
certainly not "synonyms as keywords" because that doesn't even make sense :)

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-02-09 15:10:39 UTC ---
Thanks Jon, for sure that 'or' hasn't been added on purpose.

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-10 10:05:26 UTC ---
BTW, it would be good to have testcases covering all headers compiled with
-fno-operator-names to make sure it doesn't reappear.  Perhaps with turning off
PCH first.  So something like:
// { dg-do compile }
// { dg-options "-fno-operator-names" }

// Avoid using PCH
#include <cerrno>
#include <bits/stdc++.h>
#include <bits/stdtr1c++.h>
#include <bits/extc++.h>

int or, xor, and;

(and similarly with -std=gnu++0x -fno-operator-names).

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-10 10:12:12 UTC ---
Good idea.

I didn't get through my whole TODO list yesterday, so didn't fix this yet

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-02-10 10:25:18 UTC ---
I also think it makes sense, we already have the right places for such tests:
testsuite/17_intro/headers/c++1998 and testsuite/17_intro/headers/c++200x

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-10 22:40:58 UTC ---
Author: redi
Date: Thu Feb 10 22:40:53 2011
New Revision: 170026

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170026
Log:
2011-02-10  Jonathan Wakely  <jwakely.gcc@gmail.com>

    PR libstdc++/47662
    * include/bits/c++config: Do not use alternative token.
    * testsuite/17_intro/headers/c++1998/operator_names.cc: New.


Added:
    trunk/libstdc++-v3/testsuite/17_intro/headers/c++1998/operator_names.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/c++config

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-10 22:43:14 UTC ---
Fixed.

I've just realised I should have put Jakub's name on the new test - sorry about
that!  I haven't checked in a test for -std=gnu++0x mode yet, that will follow
shortly.

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

--- Comment #9 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-02-11 00:34:57 UTC ---
By the way, lately we have available { dg-add-options no_pch }

[Bug libstdc++/47662] [4.6 Regression] -fno-operator-names no longer works with STL headers

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47662

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-12 18:36:03 UTC ---
Author: redi
Date: Sat Feb 12 18:35:59 2011
New Revision: 170084

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170084
Log:
2011-02-12  Jakub Jelinek  <jakub@redhat.com>
            Jonathan Wakely  <jwakely.gcc@gmail.com>

    PR libstdc++/47662
    * testsuite/17_intro/headers/c++200x/operator_names.cc: New.
    * testsuite/17_intro/headers/c++1998/operator_names.cc: Add comment.


Added:
    trunk/libstdc++-v3/testsuite/17_intro/headers/c++200x/operator_names.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/testsuite/17_intro/headers/c++1998/operator_names.cc