[Bug libstdc++/47668] New: missing 'typename' in debug-mode map

[Bug libstdc++/47668] New: missing 'typename' in debug-mode map

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47668

           Summary: missing 'typename' in debug-mode map
           Product: gcc
           Version: 4.3.5
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: redi@gcc.gnu.org


include/debug/map.h refers to a type in a dependent base class, without using
'typename'

      using _Base::value_compare;


I'm not sure if this is actually *wrong* - EDG accepts it too, as long as we
don't try to use value_compare in that scope without adding 'typename' (and we
don't do that.)

However, clang++ rejects it, so debug mode maps cannot be used with clang:

/opt/gcc/include/c++/4.4.3/debug/map.h:72:20: error: dependent using
declaration resolved to type without 'typename'
      using _Base::value_compare;
                   ^

adding 'typename' allows debug/map.h to be used with clang++, and doesn't seem
to fall foul of PR 14258 (again, because we don't actually use the type in that
scope)

Another fix would be
      typedef typename _Base::value_compare value_compare;

present in all active releases, not a regression
same problem exists in include/debug/multimap.h

[Bug libstdc++/47668] missing 'typename' in debug-mode map

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47668

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-09 19:01:03 UTC ---
This certainly isn't high priority to fix, and I'm not sure what the best fix
is given that G++ has problems with parsing the required typename (PR 14258) so
I'm not going to change anything right away, I just wanted to record the issue

[Bug libstdc++/47668] missing 'typename' in debug-mode map

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47668

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-02-09 20:35:45 UTC ---
What if we remove the using altogether?

[Bug libstdc++/47668] missing 'typename' in debug-mode map

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47668

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-09 20:49:26 UTC ---
hmm, yes, that might be ok too, as it will still be found from the base class
(I think!)

[Bug libstdc++/47668] missing 'typename' in debug-mode map

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47668

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-09 20:53:23 UTC ---
I know g++ has bugs in this area, so I'm cautious about assuming "it works with
g++" means it's correct, but that seems to work ok in a couple of quick tests I
did with both g++ and clang++

[Bug libstdc++/47668] missing 'typename' in debug-mode map

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47668

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paolo.carlini at oracle dot
                   |                            |com

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-02-09 20:55:58 UTC ---
I say, let's just remove it and be done with it.

[Bug libstdc++/47668] missing 'typename' in debug-mode map

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47668

--- Comment #6 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-02-10 00:08:53 UTC ---
Author: paolo
Date: Thu Feb 10 00:08:42 2011
New Revision: 169990

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169990
Log:
2011-02-09  Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/47668
    * include/debug/map.h (map): Remove unnecessary using-declaration.
    * include/debug/multimap.h (multimap): Likewise.
    * include/profile/map.h (map): Likewise.
    * include/profile/multimap.h (multimap): Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/debug/map.h
    trunk/libstdc++-v3/include/debug/multimap.h
    trunk/libstdc++-v3/include/profile/map.h
    trunk/libstdc++-v3/include/profile/multimap.h

[Bug libstdc++/47668] missing 'typename' in debug-mode map

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47668

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|paolo.carlini at oracle dot |
                   |com                         |
         Resolution|                            |FIXED
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com
   Target Milestone|---                         |4.6.0

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-02-10 00:11:20 UTC ---
Done.

[Bug libstdc++/47668] missing 'typename' in debug-mode map

[ramana at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47668

--- Comment #8 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2011-03-15 16:14:29 UTC ---
Author: ramana
Date: Tue Mar 15 16:14:21 2011
New Revision: 171000

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171000
Log:
Fix PR 47688

2011-03-18  Ramana Radhakrishnan  <ramana.radhakrishnan@linaro.org>

    PR target/47668
    gcc/
    * config/arm/arm.md (arm_movtas_ze): Use 'L' instead of 'c'
    in the output template.
    gcc/testsuite/
    * gcc.target/arm/pr47688.c: New.

Added:
    trunk/gcc/testsuite/gcc.target/arm/pr47688.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.md
    trunk/gcc/testsuite/ChangeLog