[Bug bootstrap/47736] New: [4.6 Regression] libquadmath build broken with pre-2.10 glibc

[Bug bootstrap/47736] New: [4.6 Regression] libquadmath build broken with pre-2.10 glibc

[jsm28 at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47736

           Summary: [4.6 Regression] libquadmath build broken with
                    pre-2.10 glibc
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jsm28@gcc.gnu.org
                CC: jakub@gcc.gnu.org


Bootstrap on x86_64-unknown-linux-gnu with glibc 2.7 (Ubuntu 8.04 LTS) fails
with:

/scratch/joseph/fsf/gcc-mainline/libquadmath/printf/quadmath-printf.c: In
function 'quadmath_snprintf':
/scratch/joseph/fsf/gcc-mainline/libquadmath/printf/quadmath-printf.c:220:7:
error: 'struct printf_info' has no member named 'user'
/scratch/joseph/fsf/gcc-mainline/libquadmath/printf/quadmath-printf.c: In
function 'flt128_ais':
/scratch/joseph/fsf/gcc-mainline/libquadmath/printf/quadmath-printf.c:288:11:
error: 'const struct printf_info' has no member named 'user'
/scratch/joseph/fsf/gcc-mainline/libquadmath/printf/quadmath-printf.c: In
function 'flt128_printf_fp':
/scratch/joseph/fsf/gcc-mainline/libquadmath/printf/quadmath-printf.c:367:12:
error: 'const struct printf_info' has no member named 'user'
/scratch/joseph/fsf/gcc-mainline/libquadmath/printf/quadmath-printf.c: In
function 'flt128_printf_fphex':
/scratch/joseph/fsf/gcc-mainline/libquadmath/printf/quadmath-printf.c:380:12:
error: 'const struct printf_info' has no member named 'user'

It appears that this member was new in glibc 2.10, and so configure checks or
version checks are needed to avoid requiring it when building with older glibc.

[Bug bootstrap/47736] [4.6 Regression] libquadmath build broken with pre-2.10 glibc

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47736

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.02.14 18:17:56
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-14 18:17:55 UTC ---
Created attachment 23338
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23338
gcc46-pr47736.patch

Untested fix.

[Bug bootstrap/47736] [4.6 Regression] libquadmath build broken with pre-2.10 glibc

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47736

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-14 18:49:10 UTC ---
Author: jakub
Date: Mon Feb 14 18:49:07 2011
New Revision: 170147

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170147
Log:
    PR bootstrap/47736
    * configure.ac (HAVE_PRINTF_HOOKS): Test if printf_info struct has
    user field.
    * printf/quadmath-printf.c (quadmath_snprintf): Clear whole info
    field instead of setting individual fields to 0.  Don't set info.user
    to -1.
    * configure: Regenerated.

Modified:
    trunk/libquadmath/ChangeLog
    trunk/libquadmath/configure
    trunk/libquadmath/configure.ac
    trunk/libquadmath/printf/quadmath-printf.c

[Bug bootstrap/47736] [4.6 Regression] libquadmath build broken with pre-2.10 glibc

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47736

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-14 18:53:32 UTC ---
Should be fixed now, can you verify on real glibc 2.9 or earlier?

[Bug bootstrap/47736] [4.6 Regression] libquadmath build broken with pre-2.10 glibc

[jsm28 at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47736

Joseph S. Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Joseph S. Myers <jsm28 at gcc dot gnu.org> 2011-02-14 21:13:05 UTC ---
Trunk now builds OK again with glibc 2.7.