public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/47744] [x32] ICE: in reload_cse_simplify_operands, at postreload.c:403
Date: Sun, 17 Jul 2011 21:21:00 -0000	[thread overview]
Message-ID: <bug-47744-4-IshzdJKSM0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-47744-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47744

--- Comment #17 from H.J. Lu <hjl.tools at gmail dot com> 2011-07-17 21:21:01 UTC ---
(In reply to comment #16)
> Following patch to original ix86_decompose_address solves all failures for me:
> 
> --cut here--
> Index: i386.c
> ===================================================================
> --- i386.c    (revision 176373)
> +++ i386.c    (working copy)
> @@ -11149,8 +11149,11 @@ ix86_decompose_address (rtx addr, struct
>          return 0;
>            break;
> 
> -        case REG:
>          case SUBREG:
> +          if (GET_CODE (op) != REG)
> +        return 0;
> +
> +        case REG:
>            if (!base)
>          base = op;
>            else if (!index)
> --cut here--
> 
> The patch simply prevents subregs of anything else than registers in addresses.
> 
> So, instead of mess as in comment 14, we have a sequence of two instructions:
> 
> (insn 185 87 89 3 (set (reg:DI 0 ax)
>         (plus:DI (reg/f:DI 7 sp)
>             (const_int 200 [0xc8]))) pr47744.c:5 248 {*lea_1}
>      (nil))
> 
> (insn 89 185 90 3 (set (reg:SI 40 r11 [177])
>         (plus:SI (plus:SI (mult:SI (reg:SI 40 r11 [175])
>                     (const_int 8 [0x8]))
>                 (reg:SI 0 ax))
>             (const_int -160 [0xffffffffffffff60]))) pr47744.c:5 286
> {*lea_general_3}
>      (nil))
> 
> Please note, that "normal" lea instructions are now generated, no need for some
> special x32 versions.
> 
> BTW: I'd also argue that this sequence is more correct w.r.t. to overflows, but
> I didn't investigate this since it is already late in the night here...

I will give it a try on x32 branch.  Thanks.


  parent reply	other threads:[~2011-07-17 21:21 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15  6:10 [Bug target/47744] New: " hjl.tools at gmail dot com
2011-02-15  6:30 ` [Bug target/47744] " hjl.tools at gmail dot com
2011-02-15 13:44 ` hjl at gcc dot gnu.org
2011-02-18 15:02 ` hjl.tools at gmail dot com
2011-02-18 19:38 ` hjl at gcc dot gnu.org
2011-03-01 17:27 ` hjl.tools at gmail dot com
2011-03-01 19:21 ` hjl at gcc dot gnu.org
2011-03-29  6:27 ` hjl.tools at gmail dot com
2011-04-02  5:31 ` hjl at gcc dot gnu.org
2011-04-02  5:50 ` hjl at gcc dot gnu.org
2011-07-17 17:26 ` ubizjak at gmail dot com
2011-07-17 17:27 ` ubizjak at gmail dot com
2011-07-17 18:29 ` hjl.tools at gmail dot com
2011-07-17 20:02 ` ubizjak at gmail dot com
2011-07-17 20:08 ` ubizjak at gmail dot com
2011-07-17 20:27 ` hjl.tools at gmail dot com
2011-07-17 21:14 ` ubizjak at gmail dot com
2011-07-17 21:21 ` hjl.tools at gmail dot com [this message]
2011-07-17 21:28 ` hjl.tools at gmail dot com
2011-07-17 22:04 ` ubizjak at gmail dot com
2011-07-17 22:12 ` hjl.tools at gmail dot com
2011-07-17 22:18 ` ubizjak at gmail dot com
2011-07-17 22:44 ` hjl.tools at gmail dot com
2011-07-17 22:48 ` ubizjak at gmail dot com
2011-07-17 22:55 ` hjl.tools at gmail dot com
2011-07-17 23:00 ` ubizjak at gmail dot com
2011-07-18  0:03 ` hjl.tools at gmail dot com
2011-07-18  4:18 ` hjl.tools at gmail dot com
2011-07-18  9:09 ` ubizjak at gmail dot com
2011-07-18 13:55 ` hjl.tools at gmail dot com
2011-07-18 14:01 ` ubizjak at gmail dot com
2011-07-18 14:04 ` hjl.tools at gmail dot com
2011-07-18 14:54 ` hjl.tools at gmail dot com
2011-07-18 16:54 ` ubizjak at gmail dot com
2011-07-18 16:56 ` hjl.tools at gmail dot com
2011-07-18 17:18 ` ubizjak at gmail dot com
2011-07-18 17:51 ` hjl at gcc dot gnu.org
2011-07-18 17:52 ` uros at gcc dot gnu.org
2011-07-18 17:54 ` hjl at gcc dot gnu.org
2011-07-18 18:30 ` ubizjak at gmail dot com
2011-08-03 14:08 ` hjl at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-47744-4-IshzdJKSM0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).