[Bug libstdc++/47792] New: [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[Bug libstdc++/47792] New: [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

           Summary: [4.6 Regression] concurrence.h:292:9: error:
                    '__gthread_mutex_destroy' was not declared in this
                    scope
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: danglin@gcc.gnu.org
              Host: hppa1.1-hp-hpux10.20
            Target: hppa1.1-hp-hpux10.20
             Build: hppa1.1-hp-hpux10.20


/xxx/gnu/gcc/objdir/./gcc/xgcc -shared-libgcc -B/xxx/gnu/gcc/objdir/./gcc
-nostdinc++ -L/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/src
-L/xxx
/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/src/.libs
-B/opt/gnu/g
cc/gcc-4.6/hppa1.1-hp-hpux10.20/bin/
-B/opt/gnu/gcc/gcc-4.6/hppa1.1-hp-hpux10.20/lib/ -isystem
/opt/gnu/gcc/gcc-4.6/hppa1.1-hp-hpux10.20/include -isystem /opt/g
nu/gcc/gcc-4.6/hppa1.1-hp-hpux10.20/sys-include  -threads -x c++-header
-nostdin
c++ -g -O2  -threads
-I/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/include/hppa1.1-hp-hpux10.20
-I/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/thr
eads/libstdc++-v3/include -I/xxx/gnu/gcc/gcc/libstdc++-v3/libsupc++ -O2 -g
-std=
gnu++0x /xxx/gnu/gcc/gcc/libstdc++-v3/include/precompiled/stdc++.h \-o
hppa1.1-hp-hpux10.20/bits/stdc++.h.gch/O2ggnu++0x.gch
In file included from
/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++
-v3/include/memory:76:0,                 from
/xxx/gnu/gcc/gcc/libstdc++-v3/include/precompiled/stdc++.h
:81:
/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/include/ext/concurrence.h:
In destructor '__gnu_cxx::__mutex::~__mutex()':
/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/include/ext/concur
rence.h:171:35: error: '__gthread_mutex_destroy' was not declared in this scope
/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/include/ext/concur
rence.h: In static member function 'static typename
__gnu_cxx::__enable_if<std::
__are_same<_Rm, CMA_T_HANDLE>::__value, void>::__type
__gnu_cxx::__recursive_mutex::_S_destroy(_Rm*) [with _Rm = CMA_T_HANDLE,
typename __gnu_cxx::__enable_if<std::__are_same<_Rm, CMA_T_HANDLE>::__value,
void>::__type = void]':
/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/include/ext/concurrence.h:229:22:
  instantiated from here
/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/include/ext/concurrence.h:292:9:
error: '__gthread_mutex_destroy' was not declared in this scope
make[8]: *** [hppa1.1-hp-hpux10.20/bits/stdc++.h.gch/O2ggnu++0x.gch] Error 1
make[8]: Leaving directory
`/xxx/gnu/gcc/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/include'
make[7]: *** [all-recursive] Error 1

504 (hiauly1)dave> gcc/xgcc -Bgcc/ -v
Reading specs from gcc/specs
COLLECT_GCC=gcc/xgcc
COLLECT_LTO_WRAPPER=gcc/lto-wrapper
Target: hppa1.1-hp-hpux10.20
Configured with: ../gcc/configure --with-gnu-as --with-as=/usr/local/bin/as
--enable-shared --prefix=/opt/gnu/gcc/gcc-4.6 --with-gmp=/opt/gnu/gcc/gcc-4.6
--enable-debug=no --disable-nls --enable-languages=c,c++,objc,fortran,obj-c++
Thread model: single
gcc version 4.6.0 20110216 (experimental) [trunk revision 170207] (GCC)

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-18 00:16:20 UTC ---
probably caused by my fix for PR 46455

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-18 00:23:32 UTC ---
why is __GTHREADS defined for thread model 'single' - is that normal?

and why isn't __gthread_mutex_destroy in gthr-single.h in scope?

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #3 from John David Anglin <danglin at gcc dot gnu.org> 2011-02-18 00:29:38 UTC ---
504 (hiauly1)dave> ./xgcc -B./ -v -threads
Reading specs from ./specs
COLLECT_GCC=./xgcc
COLLECT_LTO_WRAPPER=./lto-wrapper
Target: hppa1.1-hp-hpux10.20
Configured with: ../gcc/configure --with-gnu-as --with-as=/usr/local/bin/as
--enable-shared --prefix=/opt/gnu/gcc/gcc-4.6 --with-gmp=/opt/gnu/gcc/gcc-4.6
--enable-debug=no --disable-nls --enable-languages=c,c++,objc,fortran,obj-c++
Thread model: dce
gcc version 4.6.0 20110216 (experimental) [trunk revision 170207] (GCC)

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-18 00:32:04 UTC ---
Aha! :)

There's a typo in gthr-dce.h

__gthread_mutx_destroy (__gthread_mutex_t *__mutex)

s/mutx/mutex/

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[dave at hiauly1 dot hia.nrc.ca]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #5 from dave at hiauly1 dot hia.nrc.ca 2011-02-18 00:38:54 UTC ---
> Aha! :)
> 
> There's a typo in gthr-dce.h
> 
> __gthread_mutx_destroy (__gthread_mutex_t *__mutex)
> 
> s/mutx/mutex/

Good catch!  I wonder how many years it has been there?

Dave

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.02.18 00:40:54
     Ever Confirmed|0                           |1

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-18 00:40:54 UTC ---
I suppose the safe thing to would be add the right signature and leave that
there, but I can't imagine anyone's using it with that name

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[dave at hiauly1 dot hia.nrc.ca]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #7 from dave at hiauly1 dot hia.nrc.ca 2011-02-18 01:00:35 UTC ---
On Fri, 18 Feb 2011, redi at gcc dot gnu.org wrote:

> I suppose the safe thing to would be add the right signature and leave that
> there, but I can't imagine anyone's using it with that name

I agree.  Further, the name isn't present in other thread models.

Dave

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #8 from John David Anglin <danglin at gcc dot gnu.org> 2011-02-18 02:50:28 UTC ---
Correcting the typo fixes the error.

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-02-18 10:13:40 UTC ---
Great - I guess it's up to a gthreads maintainer whether they are happy to fix
the typo in the existing function name or want to fix it by adding a new
function

[Bug libstdc++/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #10 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-02-18 17:11:58 UTC ---
... and the gthread maintainer is? (should be also in CC).

Arguably, this PR could be also re-categorized as something non-libstdc++, like
target or other, I don't know.

[Bug target/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libstdc++                   |target

--- Comment #11 from John David Anglin <danglin at gcc dot gnu.org> 2011-02-18 17:42:48 UTC ---
It appears gthr-dce.h is only used by the pa target.

[Bug target/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

--- Comment #12 from John David Anglin <danglin at gcc dot gnu.org> 2011-02-18 19:02:34 UTC ---
Author: danglin
Date: Fri Feb 18 19:02:31 2011
New Revision: 170281

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170281
Log:
    PR target/47792
    * gthr-dce.h (__gthread_mutx_destroy): Fix typo in name.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gthr-dce.h

[Bug target/47792] [4.6 Regression] concurrence.h:292:9: error: '__gthread_mutex_destroy' was not declared in this scope

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47792

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from John David Anglin <danglin at gcc dot gnu.org> 2011-02-18 19:09:38 UTC ---
Fixed by change.