public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/47840] New: incorrect _mm256_insert_epi{32,64} implementations
@ 2011-02-21 18:51 kretz at kde dot org
  2011-02-21 20:00 ` [Bug target/47840] [4.4/4.5/4.6 Regression] " ubizjak at gmail dot com
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: kretz at kde dot org @ 2011-02-21 18:51 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47840

           Summary: incorrect _mm256_insert_epi{32,64} implementations
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: kretz@kde.org


see avxintrin.h:
_mm256_insert_epi32 and _mm256_insert_epi64 use _mm_insert_epi16 internally

if __OPTIMIZE__ is not defined they use _mm_insert_epi32/64 internally - as I
would have expected.

I also checked 4.5 and 4.4, and it seems the bug was not noticed in any branch
yet.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/47840] [4.4/4.5/4.6 Regression] incorrect _mm256_insert_epi{32,64} implementations
  2011-02-21 18:51 [Bug target/47840] New: incorrect _mm256_insert_epi{32,64} implementations kretz at kde dot org
@ 2011-02-21 20:00 ` ubizjak at gmail dot com
  2011-02-21 20:05 ` uros at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ubizjak at gmail dot com @ 2011-02-21 20:00 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47840

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.02.21 19:45:17
         AssignedTo|unassigned at gcc dot       |ubizjak at gmail dot com
                   |gnu.org                     |
   Target Milestone|---                         |4.4.6
            Summary|incorrect                   |[4.4/4.5/4.6 Regression]
                   |_mm256_insert_epi{32,64}    |incorrect
                   |implementations             |_mm256_insert_epi{32,64}
                   |                            |implementations
     Ever Confirmed|0                           |1

--- Comment #1 from Uros Bizjak <ubizjak at gmail dot com> 2011-02-21 19:45:17 UTC ---
A typo, following patch should fix it:

Index: avxintrin.h
===================================================================
--- avxintrin.h    (revision 170367)
+++ avxintrin.h    (working copy)
@@ -737,7 +737,7 @@
 _mm256_insert_epi32 (__m256i __X, int __D, int const __N)
 {
   __m128i __Y = _mm256_extractf128_si256 (__X, __N >> 2);
-  __Y = _mm_insert_epi16 (__Y, __D, __N % 4);
+  __Y = _mm_insert_epi32 (__Y, __D, __N % 4);
   return _mm256_insertf128_si256 (__X, __Y, __N >> 2);
 }

@@ -762,7 +762,7 @@
 _mm256_insert_epi64 (__m256i __X, int __D, int const __N)
 {
   __m128i __Y = _mm256_extractf128_si256 (__X, __N >> 1);
-  __Y = _mm_insert_epi16 (__Y, __D, __N % 2);
+  __Y = _mm_insert_epi64 (__Y, __D, __N % 2);
   return _mm256_insertf128_si256 (__X, __Y, __N >> 1);
 }
 #endif


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/47840] [4.4/4.5/4.6 Regression] incorrect _mm256_insert_epi{32,64} implementations
  2011-02-21 18:51 [Bug target/47840] New: incorrect _mm256_insert_epi{32,64} implementations kretz at kde dot org
  2011-02-21 20:00 ` [Bug target/47840] [4.4/4.5/4.6 Regression] " ubizjak at gmail dot com
@ 2011-02-21 20:05 ` uros at gcc dot gnu.org
  2011-02-21 20:06 ` uros at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: uros at gcc dot gnu.org @ 2011-02-21 20:05 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47840

--- Comment #2 from uros at gcc dot gnu.org 2011-02-21 19:59:55 UTC ---
Author: uros
Date: Mon Feb 21 19:59:52 2011
New Revision: 170371

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170371
Log:
    PR target/47840
    * config/i386/avxintrin.h (_mm256_insert_epi32): Use _mm_insert_epi32.
    (_mm256_insert_epi64): Use _mm_insert_epi64.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/avxintrin.h


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/47840] [4.4/4.5/4.6 Regression] incorrect _mm256_insert_epi{32,64} implementations
  2011-02-21 18:51 [Bug target/47840] New: incorrect _mm256_insert_epi{32,64} implementations kretz at kde dot org
  2011-02-21 20:00 ` [Bug target/47840] [4.4/4.5/4.6 Regression] " ubizjak at gmail dot com
  2011-02-21 20:05 ` uros at gcc dot gnu.org
@ 2011-02-21 20:06 ` uros at gcc dot gnu.org
  2011-02-21 20:59 ` uros at gcc dot gnu.org
  2011-02-21 21:02 ` ubizjak at gmail dot com
  4 siblings, 0 replies; 6+ messages in thread
From: uros at gcc dot gnu.org @ 2011-02-21 20:06 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47840

--- Comment #3 from uros at gcc dot gnu.org 2011-02-21 20:02:08 UTC ---
Author: uros
Date: Mon Feb 21 20:02:02 2011
New Revision: 170372

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170372
Log:
    PR target/47840
    * config/i386/avxintrin.h (_mm256_insert_epi32): Use _mm_insert_epi32.
    (_mm256_insert_epi64): Use _mm_insert_epi64.


Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/config/i386/avxintrin.h


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/47840] [4.4/4.5/4.6 Regression] incorrect _mm256_insert_epi{32,64} implementations
  2011-02-21 18:51 [Bug target/47840] New: incorrect _mm256_insert_epi{32,64} implementations kretz at kde dot org
                   ` (2 preceding siblings ...)
  2011-02-21 20:06 ` uros at gcc dot gnu.org
@ 2011-02-21 20:59 ` uros at gcc dot gnu.org
  2011-02-21 21:02 ` ubizjak at gmail dot com
  4 siblings, 0 replies; 6+ messages in thread
From: uros at gcc dot gnu.org @ 2011-02-21 20:59 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47840

--- Comment #4 from uros at gcc dot gnu.org 2011-02-21 20:05:02 UTC ---
Author: uros
Date: Mon Feb 21 20:04:57 2011
New Revision: 170373

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170373
Log:
    PR target/47840
    * config/i386/avxintrin.h (_mm256_insert_epi32): Use _mm_insert_epi32.
    (_mm256_insert_epi64): Use _mm_insert_epi64.


Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/config/i386/avxintrin.h


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/47840] [4.4/4.5/4.6 Regression] incorrect _mm256_insert_epi{32,64} implementations
  2011-02-21 18:51 [Bug target/47840] New: incorrect _mm256_insert_epi{32,64} implementations kretz at kde dot org
                   ` (3 preceding siblings ...)
  2011-02-21 20:59 ` uros at gcc dot gnu.org
@ 2011-02-21 21:02 ` ubizjak at gmail dot com
  4 siblings, 0 replies; 6+ messages in thread
From: ubizjak at gmail dot com @ 2011-02-21 21:02 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47840

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Uros Bizjak <ubizjak at gmail dot com> 2011-02-21 20:06:03 UTC ---
Fixed.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-02-21 20:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-21 18:51 [Bug target/47840] New: incorrect _mm256_insert_epi{32,64} implementations kretz at kde dot org
2011-02-21 20:00 ` [Bug target/47840] [4.4/4.5/4.6 Regression] " ubizjak at gmail dot com
2011-02-21 20:05 ` uros at gcc dot gnu.org
2011-02-21 20:06 ` uros at gcc dot gnu.org
2011-02-21 20:59 ` uros at gcc dot gnu.org
2011-02-21 21:02 ` ubizjak at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).