public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares
@ 2011-02-24 10:44 rguenth at gcc dot gnu.org
  2011-02-24 10:56 ` [Bug fortran/47878] " rguenth at gcc dot gnu.org
                   ` (28 more replies)
  0 siblings, 29 replies; 30+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-02-24 10:44 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

           Summary: [4.6 Regression] 187.facerec miscompares
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rguenth@gcc.gnu.org
            Target: x86_64-*-*


I see miscompares with -O3 and -O2 -ffast-math.

Last known good r170390, first known bad r170432.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
@ 2011-02-24 10:56 ` rguenth at gcc dot gnu.org
  2011-02-24 11:04 ` burnus at gcc dot gnu.org
                   ` (27 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-02-24 10:56 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|x86_64-*-*                  |x86_64-*-*, ia64-*-*,
                   |                            |i?86-*-*
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.02.24 10:38:56
   Target Milestone|---                         |4.6.0
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-02-24 10:38:56 UTC ---
Last known good r170417.  Also seen on IA64 and IA32.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
  2011-02-24 10:56 ` [Bug fortran/47878] " rguenth at gcc dot gnu.org
@ 2011-02-24 11:04 ` burnus at gcc dot gnu.org
  2011-02-24 11:07 ` burnus at gcc dot gnu.org
                   ` (26 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: burnus at gcc dot gnu.org @ 2011-02-24 11:04 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org,
                   |                            |jb at gcc dot gnu.org

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-02-24 10:55:59 UTC ---
Betwixt r170417 and r170432 there aren't many commits. I only see two which at
a glance could be related:

r170432 | jb | 2011-02-23 07:59:51 +0100 (Wed, 23 Feb 2011) | 1 line
PR 47694 Read from named pipe fails

r170422 | jiez | 2011-02-23 01:25:34 +0100 (Wed, 23 Feb 2011) | 7 lines
        PR rtl-optimization/47763
        * web.c (web_main): Ignore naked clobber when replacing register.

Unless, it is one of those innocently looking patches ...


The Fortran patch is an I/O patch, which fixed a 4.3/4.4/4.5/4.6 regression for
list-directed, formatted reading from sockets.

(Without access to
http://www.spec.org/cpu2000/CFP2000/187.facerec/docs/187.facerec.html it is
kind of difficult to debug it; when I quickly searched, I also could not find
the source.)


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
  2011-02-24 10:56 ` [Bug fortran/47878] " rguenth at gcc dot gnu.org
  2011-02-24 11:04 ` burnus at gcc dot gnu.org
@ 2011-02-24 11:07 ` burnus at gcc dot gnu.org
  2011-02-24 11:28 ` rguenth at gcc dot gnu.org
                   ` (25 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: burnus at gcc dot gnu.org @ 2011-02-24 11:07 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-02-24 10:57:28 UTC ---
(In reply to comment #0)
> I see miscompares with -O3 and -O2 -ffast-math.

Does the miscompare depend on the -O flags? If so, the patch for PR 47694
cannot have cause it as it is a libgfortran only change. Looking at the
changelog, it then has to be a middle-end issue.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2011-02-24 11:07 ` burnus at gcc dot gnu.org
@ 2011-02-24 11:28 ` rguenth at gcc dot gnu.org
  2011-02-24 11:48 ` rguenth at gcc dot gnu.org
                   ` (24 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-02-24 11:28 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-02-24 11:19:57 UTC ---
(In reply to comment #3)
> (In reply to comment #0)
> > I see miscompares with -O3 and -O2 -ffast-math.
> 
> Does the miscompare depend on the -O flags? If so, the patch for PR 47694
> cannot have cause it as it is a libgfortran only change. Looking at the
> changelog, it then has to be a middle-end issue.

I only extracted information from our autotesters and did not run
manual tests yet.  That the issue is seen across a wide range of platforms
suggests the bug is in libgfortran.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2011-02-24 11:28 ` rguenth at gcc dot gnu.org
@ 2011-02-24 11:48 ` rguenth at gcc dot gnu.org
  2011-02-24 14:01 ` jvdelisle at gcc dot gnu.org
                   ` (23 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-02-24 11:48 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-02-24 11:28:36 UTC ---
Fails with -O0, works with r170432 reverted.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2011-02-24 11:48 ` rguenth at gcc dot gnu.org
@ 2011-02-24 14:01 ` jvdelisle at gcc dot gnu.org
  2011-02-24 14:16 ` rguenth at gcc dot gnu.org
                   ` (22 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2011-02-24 14:01 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #6 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2011-02-24 13:51:09 UTC ---
We are going to need some sort of reduced test case or revert the patch.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2011-02-24 14:01 ` jvdelisle at gcc dot gnu.org
@ 2011-02-24 14:16 ` rguenth at gcc dot gnu.org
  2011-02-24 14:17 ` rguenth at gcc dot gnu.org
                   ` (21 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-02-24 14:16 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-02-24 14:01:27 UTC ---
The error is

 Performing comparison with probe entries
  1      ar2:    global move determines position  58  45,  similarity = 0.79937
  1      ar2: best match      ar1 sim. = 0.85622
At line 61 of file imageRoutines.f90 (unit = 21, file = 'ar3.asc')
Fortran runtime error: Bad value during integer read

This line is the last in

        Open (Unit = imageLUN, File = PathName//FileName, Action = 'READ', &
        &     Recl = 130, Form = 'FORMATTED', Access = 'SEQUENTIAL', Status =
'OLD')
!
!       If UpSample == 1, read image directly.
!
        If (ImagePars%UpSample == 1) Then
                Read (Unit = imageLUN, FMT = '(64(Z2.2))') Image

The file opened starts with

3F4344484E5A63728592A0AEBAC6BEC1C4C5C6C6C7C6C8C7C8C5C6C8C8C9C6C7C8C9C9C9CBCECBCCCED1D2D1D1D1D0CECDCACCCCCACCCBCCCED0D5CCCFCFD0CE
CECDD1CDD0D1D2D2D1D0CFCCCACECDCFD0D0D4D4D4D0CFD5D0D1CFCFD0CDCCCECFD0D3D0D2D7D5D7D9D5DBD8D6D5D5D5D4D5D6D5D9D8D7D7D7D6D6D6D6D6D8D7

and continues with 1022 other lines of the same length.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (6 preceding siblings ...)
  2011-02-24 14:16 ` rguenth at gcc dot gnu.org
@ 2011-02-24 14:17 ` rguenth at gcc dot gnu.org
  2011-02-24 14:26 ` rguenth at gcc dot gnu.org
                   ` (20 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-02-24 14:17 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #8 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-02-24 14:04:04 UTC ---
Ah, line 61 of that file is

3A3B393C3B3C3B3D3B3B3C3C3C3D3D3E3F3D403E3F403E3E3C3D3B3D423E3E403E3E444242474B586E849EB9C1C5C5C9CBCECDCCCFCFCDCACDCAC9C6CCCACBD0

with +-1 surrounding lines

C9CCD0D0CECCCBCBC8C9CACCCACACBCCCCC8C5C6C9C7C7C7C7C6C4C3C0C4BBBAB8B7B6B3AFABA7A898908C82746C655C554F4A44454543434744444344454545
3A3B393C3B3C3B3D3B3B3C3C3C3D3D3E3F3D403E3F403E3E3C3D3B3D423E3E403E3E444242474B586E849EB9C1C5C5C9CBCECDCCCFCFCDCACDCAC9C6CCCACBD0
D1D0D0D2D2D0CECAC9CDCECFD0D2D3D2D0CECCC7C6C7C6C7C8C8C8C7C7C5C5C1BEBEBDBBB8B5AFAFAEADAAA6A6A5A5A3A3A6A5A4A19E9A9A9998989A9A999A9B


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (7 preceding siblings ...)
  2011-02-24 14:17 ` rguenth at gcc dot gnu.org
@ 2011-02-24 14:26 ` rguenth at gcc dot gnu.org
  2011-02-24 14:36 ` rguenth at gcc dot gnu.org
                   ` (19 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-02-24 14:26 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #9 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-02-24 14:18:06 UTC ---
And

        Integer,      Pointer    :: Image (:, :)

Breakpoint 1, read_radix (dtp=0x7fffffffd7e0, f=0x107bba0, dest=0x6377c0 "�, 
    length=4, radix=16)
    at /space/rguenther/src/svn/trunk/libgfortran/io/read.c:775
775       generate_error (&dtp->common, LIBERROR_READ_VALUE,
(gdb) p c
$1 = 92 '\\'
(gdb) p p - 64
$9 = 0x107ba61
"592A0AEBAC6BEC1C4C5C6C6C7C6C8C7C8C5C6C8C8C9C6C7C8C9C9C9CBCECBCC\\\221.\021�177�023\021TM\026���\030GT\002\033\v�\035\036\221\062\037\002�!\017\a\004#��$�&):��5)��\205*a\016"

looks like the read buffer is garbled.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (8 preceding siblings ...)
  2011-02-24 14:26 ` rguenth at gcc dot gnu.org
@ 2011-02-24 14:36 ` rguenth at gcc dot gnu.org
  2011-02-24 14:51 ` burnus at gcc dot gnu.org
                   ` (18 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-02-24 14:36 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #10 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-02-24 14:25:48 UTC ---
There are a load of valgrind errors as well:

==11765== Invalid read of size 1
==11765==    at 0x4F003D6: eat_leading_spaces (read.c:499)
==11765==    by 0x4F00885: _gfortrani_read_radix (read.c:661)
==11765==    by 0x4F0464D: formatted_transfer (transfer.c:1158)
==11765==    by 0x4F025E9: _gfortran_transfer_array (transfer.c:2033)
==11765==    by 0x41229C: __imageroutines_MOD_readimage (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41950F: __graphroutines_MOD_generategraphs (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41A114: MAIN__ (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41B47D: main (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==  Address 0x5c719a0 is 80 bytes inside a block of size 130 free'd
==11765==    at 0x4C262D8: realloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==11765==    by 0x4F0DC39: _gfortrani_fbuf_alloc (fbuf.c:125)
==11765==    by 0x4F0DDF7: _gfortrani_fbuf_read (fbuf.c:229)
==11765==    by 0x4F0DE99: _gfortrani_fbuf_getc_refill (fbuf.c:264)
==11765==    by 0x4F0601F: _gfortrani_read_block_form (fbuf.h:78)
==11765==    by 0x4F00855: _gfortrani_read_radix (read.c:656)
==11765==    by 0x4F0464D: formatted_transfer (transfer.c:1158)
==11765==    by 0x4F025E9: _gfortran_transfer_array (transfer.c:2033)
==11765==    by 0x41229C: __imageroutines_MOD_readimage (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41950F: __graphroutines_MOD_generategraphs (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41A114: MAIN__ (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41B47D: main (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765== 
==11765== Invalid read of size 1
==11765==    at 0x4F00936: _gfortrani_read_radix (read.c:674)
==11765==    by 0x4F0464D: formatted_transfer (transfer.c:1158)
==11765==    by 0x4F025E9: _gfortran_transfer_array (transfer.c:2033)
==11765==    by 0x41229C: __imageroutines_MOD_readimage (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41950F: __graphroutines_MOD_generategraphs (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41A114: MAIN__ (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41B47D: main (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==  Address 0x5c719a0 is 80 bytes inside a block of size 130 free'd
==11765==    at 0x4C262D8: realloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==11765==    by 0x4F0DC39: _gfortrani_fbuf_alloc (fbuf.c:125)
==11765==    by 0x4F0DDF7: _gfortrani_fbuf_read (fbuf.c:229)
==11765==    by 0x4F0DE99: _gfortrani_fbuf_getc_refill (fbuf.c:264)
==11765==    by 0x4F0601F: _gfortrani_read_block_form (fbuf.h:78)
==11765==    by 0x4F00855: _gfortrani_read_radix (read.c:656)
==11765==    by 0x4F0464D: formatted_transfer (transfer.c:1158)
==11765==    by 0x4F025E9: _gfortran_transfer_array (transfer.c:2033)
==11765==    by 0x41229C: __imageroutines_MOD_readimage (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41950F: __graphroutines_MOD_generategraphs (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41A114: MAIN__ (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41B47D: main (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765== 
==11765== Invalid read of size 1
==11765==    at 0x4F0042C: next_char (read.c:519)
==11765==    by 0x4F009AD: _gfortrani_read_radix (read.c:695)
==11765==    by 0x4F0464D: formatted_transfer (transfer.c:1158)
==11765==    by 0x4F025E9: _gfortran_transfer_array (transfer.c:2033)
==11765==    by 0x41229C: __imageroutines_MOD_readimage (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41950F: __graphroutines_MOD_generategraphs (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41A114: MAIN__ (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41B47D: main (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==  Address 0x5c719a0 is 80 bytes inside a block of size 130 free'd
==11765==    at 0x4C262D8: realloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==11765==    by 0x4F0DC39: _gfortrani_fbuf_alloc (fbuf.c:125)
==11765==    by 0x4F0DDF7: _gfortrani_fbuf_read (fbuf.c:229)
==11765==    by 0x4F0DE99: _gfortrani_fbuf_getc_refill (fbuf.c:264)
==11765==    by 0x4F0601F: _gfortrani_read_block_form (fbuf.h:78)
==11765==    by 0x4F00855: _gfortrani_read_radix (read.c:656)
==11765==    by 0x4F0464D: formatted_transfer (transfer.c:1158)
==11765==    by 0x4F025E9: _gfortran_transfer_array (transfer.c:2033)
==11765==    by 0x41229C: __imageroutines_MOD_readimage (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41950F: __graphroutines_MOD_generategraphs (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41A114: MAIN__ (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41B47D: main (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765== 
==11765== Conditional jump or move depends on uninitialised value(s)
==11765==    at 0x40DE2A: __fft2d_MOD_fft2db (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41172F: __gaborroutines_MOD_gabortrafo (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x419533: __graphroutines_MOD_generategraphs (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41A114: MAIN__ (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765==    by 0x41B47D: main (in
/home/abuild/rguenther/spec2000/cpu2000/benchspec/CFP2000/187.facerec/run/00000002/facerec_base.none)
==11765== 
     ar1: generated graph at  63 47, similarity = 0.80035
     at1: generated graph at  48 53, similarity = 0.77174
At line 61 of file imageRoutines.f90 (unit = 21, file = 'bevin1.asc')
Fortran runtime error: Bad value during integer read


it looks like you are keeping pointers to buffers you re-allocate
(and thus get relocated).


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (9 preceding siblings ...)
  2011-02-24 14:36 ` rguenth at gcc dot gnu.org
@ 2011-02-24 14:51 ` burnus at gcc dot gnu.org
  2011-02-24 14:55 ` burnus at gcc dot gnu.org
                   ` (17 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: burnus at gcc dot gnu.org @ 2011-02-24 14:51 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #11 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-02-24 14:34:09 UTC ---
Failing test case - though different to the one reported above:

  integer :: a(5)
  open(99,Recl = 40)
  write(99,'(5i3)') 1,2,3
  rewind(99)
  read(99,'(5i3)') a
  ! Expected: 1  2  3  0  0
  print *, a
  end

The program print here "0 2 3 0 0", but "1 2 3 0 0" with gfortran 4.1, g95, NAG
f95, ifort and pathf95.

Test case for the actual issue:

  integer :: a(42)
  open(99, recl=90)
  write(99,'(a)') '3F4344484E5A63728592A0AEBAC6BEC1C4C5C6C6C7C6C' &
                 //'8C7C8C5C6C8C8C9C6C7C8C9C9C9CBCECBCCCE'
  rewind(99)
  Read (Unit = 99, FMT = '(64(Z2.2))') a
  print '(10(i5))', a
  end

The crucial part seems to be to have (a) RECL= and (b) a line which is longer
than 80 characters.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (10 preceding siblings ...)
  2011-02-24 14:51 ` burnus at gcc dot gnu.org
@ 2011-02-24 14:55 ` burnus at gcc dot gnu.org
  2011-02-24 15:14 ` jakub at gcc dot gnu.org
                   ` (16 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: burnus at gcc dot gnu.org @ 2011-02-24 14:55 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #12 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-02-24 14:35:54 UTC ---
(In reply to comment #11)
> Test case for the actual issue:
>
> The crucial part seems to be to have (a) RECL= and (b) a line which is longer
> than 80 characters.

... and reading more that than available. For integer, such values are regarded
as 0.

Consequently, ifort and gfortran-4.1 print:
   63   67   68   72   78   90   99  114  133  146
  160  174  186  198  190  193  196  197  198  198
  199  198  200  199  200  197  198  200  200  201
  198  199  200  201  201  201  203  206  203  204
  206    0

While the trunk version prints:
  At line 6 of file bar.f90 (unit = 99, file = 'fort.99')
  Fortran runtime error: Bad value during integer read


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (11 preceding siblings ...)
  2011-02-24 14:55 ` burnus at gcc dot gnu.org
@ 2011-02-24 15:14 ` jakub at gcc dot gnu.org
  2011-02-24 15:39 ` jakub at gcc dot gnu.org
                   ` (15 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-02-24 15:14 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-24 15:05:39 UTC ---
Created attachment 23455
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23455
gcc46-pr47878.patch

So how about this patch?  Fixes the valgrind reported issues on Tobi's
testcase...


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (12 preceding siblings ...)
  2011-02-24 15:14 ` jakub at gcc dot gnu.org
@ 2011-02-24 15:39 ` jakub at gcc dot gnu.org
  2011-02-24 16:22 ` jvdelisle at gcc dot gnu.org
                   ` (14 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-02-24 15:39 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-24 15:14:05 UTC ---
Or alternatively, without any fbuf.h changes, I think it could be fixed by
dropping
  char *base;

  base = fbuf_getptr (dtp->u.p.current_unit);
  if (base == NULL)
    return NULL;

lines altogether and doing

  return fbuf_getptr (dtp->u.p.current_unit) - n;
instead of
  return base;
at the end.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (13 preceding siblings ...)
  2011-02-24 15:39 ` jakub at gcc dot gnu.org
@ 2011-02-24 16:22 ` jvdelisle at gcc dot gnu.org
  2011-02-24 17:07 ` jakub at gcc dot gnu.org
                   ` (13 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2011-02-24 16:22 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #15 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2011-02-24 16:03:41 UTC ---
Jakub's suggestion is probably OK.  I am not at a place where I can do and
test.
My only concern, is there a chance that we would backup passed the beginning of
the buffer?  Maybe make sure there is a check theat the final pointer returned
is greater than or equal to the original base.

So if it passes regression testing and fixes the original test case, consider
approved, but add a comment at the return point that mentions needed due to
buffer reallocation that may have occurred.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (14 preceding siblings ...)
  2011-02-24 16:22 ` jvdelisle at gcc dot gnu.org
@ 2011-02-24 17:07 ` jakub at gcc dot gnu.org
  2011-02-24 17:23 ` jvdelisle at gcc dot gnu.org
                   ` (12 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-02-24 17:07 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #16 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-24 16:20:27 UTC ---
Do you prefer the patch in #c13, or what I wrote in #c14?  I'd prefer not to
test both.
As for pointer comparisons, you can't compare the old pointer with the new one,
that triggers undefined behavior in C.  Comparing the positions is of course
possible, but then I'd say we should just go with #c13 rather than #c14.
Actually, reading the code some more, #c14 variant is quite problematic,
because
e.g. for '\n' or '\r' or ',' in some cases the last read character is not
accounted into n, thus fbuf_getptr (dtp->u.p.current_unit) - n might be one
char after what we want to return.
Sure, I can add a comment about realloc.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (15 preceding siblings ...)
  2011-02-24 17:07 ` jakub at gcc dot gnu.org
@ 2011-02-24 17:23 ` jvdelisle at gcc dot gnu.org
  2011-02-24 17:41 ` jvdelisle at gcc dot gnu.org
                   ` (11 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2011-02-24 17:23 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #17 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2011-02-24 17:07:06 UTC ---
C14, my browser here is not displaying the comment numbers, odd.

You will see where we set the eor number to 1 or 2 depending on what was found.
That can be used to adjust n if needed. The ',' I will have to think about, we
turn that feature off while reading character so it is not executed in all
cases, but I think n gets bummped for those already.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (16 preceding siblings ...)
  2011-02-24 17:23 ` jvdelisle at gcc dot gnu.org
@ 2011-02-24 17:41 ` jvdelisle at gcc dot gnu.org
  2011-02-24 18:28 ` jakub at gcc dot gnu.org
                   ` (10 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2011-02-24 17:41 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #18 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2011-02-24 17:10:50 UTC ---
The old code did this:

fbuf_seek (dtp->u.p.current_unit, n + seen_comma, SEEK_CUR);

So we could adjust for comma as well.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (17 preceding siblings ...)
  2011-02-24 17:41 ` jvdelisle at gcc dot gnu.org
@ 2011-02-24 18:28 ` jakub at gcc dot gnu.org
  2011-02-24 18:31 ` burnus at gcc dot gnu.org
                   ` (9 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-02-24 18:28 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #19 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-24 17:23:09 UTC ---
Created attachment 23456
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23456
gcc46-pr47878.patch

So like this?


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (18 preceding siblings ...)
  2011-02-24 18:28 ` jakub at gcc dot gnu.org
@ 2011-02-24 18:31 ` burnus at gcc dot gnu.org
  2011-02-24 18:53 ` jvdelisle at gcc dot gnu.org
                   ` (8 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: burnus at gcc dot gnu.org @ 2011-02-24 18:31 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #20 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-02-24 17:41:20 UTC ---
Comment on attachment 23456
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23456
gcc46-pr47878.patch

>+  read (99, '(5i3)') a
>+  if (any (a.ne.(/1, 2, 3, 0, 0/))) call abort 
>+end

I leave the reviewing to Jerry (or Janne), but I would add a
  close(99, status='delete')
to keep the testing directory tidy.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (19 preceding siblings ...)
  2011-02-24 18:31 ` burnus at gcc dot gnu.org
@ 2011-02-24 18:53 ` jvdelisle at gcc dot gnu.org
  2011-02-24 18:54 ` jvdelisle at gcc dot gnu.org
                   ` (7 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2011-02-24 18:53 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #21 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2011-02-24 18:27:42 UTC ---
This is OK and do add the close with status = "delete"


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (20 preceding siblings ...)
  2011-02-24 18:53 ` jvdelisle at gcc dot gnu.org
@ 2011-02-24 18:54 ` jvdelisle at gcc dot gnu.org
  2011-02-24 20:17 ` jakub at gcc dot gnu.org
                   ` (6 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2011-02-24 18:54 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #22 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2011-02-24 18:30:38 UTC ---
Just to be clear;

Created attachment 23456 [details]
gcc46-pr47878.patch


is approved. It has to be right, look at that attachment number!

;)


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (21 preceding siblings ...)
  2011-02-24 18:54 ` jvdelisle at gcc dot gnu.org
@ 2011-02-24 20:17 ` jakub at gcc dot gnu.org
  2011-02-24 20:43 ` jakub at gcc dot gnu.org
                   ` (5 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-02-24 20:17 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #23 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-24 20:14:00 UTC ---
Author: jakub
Date: Thu Feb 24 20:13:57 2011
New Revision: 170476

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170476
Log:
    PR fortran/47878
    * io/transfer.c (read_sf): Call fbuf_getptr only at the end,
    and subtract n, dtp->u.p.sf_seen_eor and seen_comma from it.

    * gfortran.dg/pr47878.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/pr47878.f90
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/transfer.c


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (22 preceding siblings ...)
  2011-02-24 20:17 ` jakub at gcc dot gnu.org
@ 2011-02-24 20:43 ` jakub at gcc dot gnu.org
  2011-02-24 22:09 ` pinskia at gcc dot gnu.org
                   ` (4 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-02-24 20:43 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #24 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-24 20:17:05 UTC ---
Richard, can you check if this fixes 187.facerec?


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (23 preceding siblings ...)
  2011-02-24 20:43 ` jakub at gcc dot gnu.org
@ 2011-02-24 22:09 ` pinskia at gcc dot gnu.org
  2011-02-25 10:55 ` rguenth at gcc dot gnu.org
                   ` (3 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: pinskia at gcc dot gnu.org @ 2011-02-24 22:09 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com

--- Comment #25 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-02-24 22:06:51 UTC ---
*** Bug 47887 has been marked as a duplicate of this bug. ***


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (24 preceding siblings ...)
  2011-02-24 22:09 ` pinskia at gcc dot gnu.org
@ 2011-02-25 10:55 ` rguenth at gcc dot gnu.org
  2011-03-05  0:06 ` jvdelisle at gcc dot gnu.org
                   ` (2 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-02-25 10:55 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #26 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-02-25 10:49:33 UTC ---
Works again.


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (25 preceding siblings ...)
  2011-02-25 10:55 ` rguenth at gcc dot gnu.org
@ 2011-03-05  0:06 ` jvdelisle at gcc dot gnu.org
  2011-03-07  3:09 ` jvdelisle at gcc dot gnu.org
  2011-03-07  3:14 ` jvdelisle at gcc dot gnu.org
  28 siblings, 0 replies; 30+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2011-03-05  0:06 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #27 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2011-03-05 00:05:40 UTC ---
Author: jvdelisle
Date: Sat Mar  5 00:05:34 2011
New Revision: 170692

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170692
Log:
2011-03-04  Jakub Jelinek  <jakub@redhat.com>

    Backport from mainline
    PR fortran/47878
    * io/transfer.c (read_sf): Call fbuf_getptr only at the end,
    and subtract n, dtp->u.p.sf_seen_eor and seen_comma from it.

2011-03-04  Janne Blomqvist  <jb@gcc.gnu.org>
        Jerry DeLisle    <jvdelisle@gcc.gnu.org>

    Backport from mainline
    PR libfortran/47694
    * io/fbuf.h (fbuf_getptr): New inline function.
    * io/transfer.c (read_sf): Use fbuf_getptr and fbuf_getc to scan
    through the string instead of fbuf_read.

2011-03-04  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

    Backport from mainline
    PR libgfortran/47878
    * gfortran.dg/pr47878.f90: New test.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gfortran.dg/pr47878.f90
Modified:
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_5-branch/libgfortran/ChangeLog
    branches/gcc-4_5-branch/libgfortran/io/fbuf.h
    branches/gcc-4_5-branch/libgfortran/io/transfer.c


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (26 preceding siblings ...)
  2011-03-05  0:06 ` jvdelisle at gcc dot gnu.org
@ 2011-03-07  3:09 ` jvdelisle at gcc dot gnu.org
  2011-03-07  3:14 ` jvdelisle at gcc dot gnu.org
  28 siblings, 0 replies; 30+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2011-03-07  3:09 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #28 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2011-03-07 03:08:12 UTC ---
Author: jvdelisle
Date: Mon Mar  7 03:08:08 2011
New Revision: 170732

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170732
Log:
2011-03-06  Jakub Jelinek  <jakub@redhat.com>

    Backport from mainline
    PR fortran/47878
    * io/transfer.c (read_sf): Call fbuf_getptr only at the end,
    and subtract n, dtp->u.p.sf_seen_eor and seen_comma from it.

2011-03-06  Janne Blomqvist  <jb@gcc.gnu.org>
        Jerry DeLisle    <jvdelisle@gcc.gnu.org>

    Backport from mainline
    PR libfortran/47694
    * io/io.h (fbuf_getptr): New inline function.
    * io/transfer.c (read_sf): Use fbuf_getptr and fbuf_getc to scan
    through the string instead of fbuf_read.

Modified:
    branches/gcc-4_4-branch/libgfortran/ChangeLog
    branches/gcc-4_4-branch/libgfortran/io/io.h
    branches/gcc-4_4-branch/libgfortran/io/transfer.c


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares
  2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
                   ` (27 preceding siblings ...)
  2011-03-07  3:09 ` jvdelisle at gcc dot gnu.org
@ 2011-03-07  3:14 ` jvdelisle at gcc dot gnu.org
  28 siblings, 0 replies; 30+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2011-03-07  3:14 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878

--- Comment #29 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2011-03-07 03:14:03 UTC ---
Author: jvdelisle
Date: Mon Mar  7 03:14:00 2011
New Revision: 170733

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170733
Log:
2011-03-06  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

    Backport from mainline
    PR libgfortran/47878
    * gfortran.dg/pr47878.f90: New test.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/gfortran.dg/pr47878.f90
Modified:
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog


^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2011-03-07  3:14 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-24 10:44 [Bug fortran/47878] New: [4.6 Regression] 187.facerec miscompares rguenth at gcc dot gnu.org
2011-02-24 10:56 ` [Bug fortran/47878] " rguenth at gcc dot gnu.org
2011-02-24 11:04 ` burnus at gcc dot gnu.org
2011-02-24 11:07 ` burnus at gcc dot gnu.org
2011-02-24 11:28 ` rguenth at gcc dot gnu.org
2011-02-24 11:48 ` rguenth at gcc dot gnu.org
2011-02-24 14:01 ` jvdelisle at gcc dot gnu.org
2011-02-24 14:16 ` rguenth at gcc dot gnu.org
2011-02-24 14:17 ` rguenth at gcc dot gnu.org
2011-02-24 14:26 ` rguenth at gcc dot gnu.org
2011-02-24 14:36 ` rguenth at gcc dot gnu.org
2011-02-24 14:51 ` burnus at gcc dot gnu.org
2011-02-24 14:55 ` burnus at gcc dot gnu.org
2011-02-24 15:14 ` jakub at gcc dot gnu.org
2011-02-24 15:39 ` jakub at gcc dot gnu.org
2011-02-24 16:22 ` jvdelisle at gcc dot gnu.org
2011-02-24 17:07 ` jakub at gcc dot gnu.org
2011-02-24 17:23 ` jvdelisle at gcc dot gnu.org
2011-02-24 17:41 ` jvdelisle at gcc dot gnu.org
2011-02-24 18:28 ` jakub at gcc dot gnu.org
2011-02-24 18:31 ` burnus at gcc dot gnu.org
2011-02-24 18:53 ` jvdelisle at gcc dot gnu.org
2011-02-24 18:54 ` jvdelisle at gcc dot gnu.org
2011-02-24 20:17 ` jakub at gcc dot gnu.org
2011-02-24 20:43 ` jakub at gcc dot gnu.org
2011-02-24 22:09 ` pinskia at gcc dot gnu.org
2011-02-25 10:55 ` rguenth at gcc dot gnu.org
2011-03-05  0:06 ` jvdelisle at gcc dot gnu.org
2011-03-07  3:09 ` jvdelisle at gcc dot gnu.org
2011-03-07  3:14 ` jvdelisle at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).