From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30645 invoked by alias); 24 Feb 2011 16:04:10 -0000 Received: (qmail 30632 invoked by uid 22791); 24 Feb 2011 16:04:08 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,TW_JV X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Feb 2011 16:04:05 +0000 From: "jvdelisle at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/47878] [4.6 Regression] 187.facerec miscompares X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: fortran X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: normal X-Bugzilla-Who: jvdelisle at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.6.0 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Thu, 24 Feb 2011 16:22:00 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-02/txt/msg02783.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47878 --- Comment #15 from Jerry DeLisle 2011-02-24 16:03:41 UTC --- Jakub's suggestion is probably OK. I am not at a place where I can do and test. My only concern, is there a chance that we would backup passed the beginning of the buffer? Maybe make sure there is a check theat the final pointer returned is greater than or equal to the original base. So if it passes regression testing and fixes the original test case, consider approved, but add a comment at the return point that mentions needed due to buffer reallocation that may have occurred.