From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10313 invoked by alias); 25 Feb 2011 17:39:58 -0000 Received: (qmail 10305 invoked by uid 22791); 25 Feb 2011 17:39:58 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Feb 2011 17:39:54 +0000 From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/47893] [4.6 Regression] 4.6 miscompiles mesa on i686 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: blocker X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.6.0 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 25 Feb 2011 18:31:00 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-02/txt/msg02884.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47893 --- Comment #10 from Jakub Jelinek 2011-02-25 17:39:36 UTC --- I guess that would break pa, because then else if (!STACK_ALIGNMENT_NEEDED) { ... } will be executed whenever record_alignment_slots is false, even for non-zero sizes or non-BLKmode. Other than that, I think it would be better to change the bool argument into an enum, after all we need just 3 variants, reduce_alignment_ok && record_alignment_slots (for caller-save), !reduce_alignment_ok && record_alignment_slots (for assign_stack_local) and !reduce_alignment_ok && !record_alignment_slots (for assign_stack_temp_for_type). I'm currently running x86_64-linux and i686-linux bootstraps/regtests gathering statistics, so far from the partial numbers I have a patch like that isn't going to pessimize stuff too much, add_frame_space from within assign_stack_temp_for_type accounts for like .5% of all add_frame_space calls (and similarly in the number of bytes thus recorded).