public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "andersk at mit dot edu" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/47901] -Wall should not imply -Wformat-zero-length by default Date: Mon, 23 Apr 2012 20:22:00 -0000 [thread overview] Message-ID: <bug-47901-4-3Y14tVdSid@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-47901-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47901 --- Comment #5 from Anders Kaseorg <andersk at mit dot edu> 2012-04-23 20:22:20 UTC --- I’m not sure ("%s", "") is a suitable replacement in general. Maybe this is a far-fetched example, but what the purpose of custom_printf is to shell-quote all its arguments, so that custom_printf(foo, "") writes "some_command" with no arguments but custom_printf(foo, "%s", "") writes "some_command ''" with a single empty argument? In any event, ("%s", "") is certainly different code with a potential runtime cost, and it’s not fair for -Wall to complain about the more straightforward ("") unless it’s reasonably likely for that code to be hiding some class of bugs. Is it? (Another real-world example from a project I help maintain: https://github.com/barnowl/barnowl/blob/barnowl-1.8.1/keys.c#L337 )
next prev parent reply other threads:[~2012-04-23 20:22 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-26 9:11 [Bug c/47901] New: " anders at kaseorg dot com 2012-04-07 20:42 ` [Bug c/47901] " manu at gcc dot gnu.org 2012-04-23 19:58 ` joseph at codesourcery dot com 2012-04-23 20:08 ` manu at gcc dot gnu.org 2012-04-23 20:11 ` andersk at mit dot edu 2012-04-23 20:22 ` andersk at mit dot edu [this message] 2012-04-23 20:50 ` joseph at codesourcery dot com 2012-04-23 21:31 ` andersk at mit dot edu 2012-04-26 14:19 ` manu at gcc dot gnu.org 2013-12-21 20:01 ` naesten at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-47901-4-3Y14tVdSid@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).