[Bug go/48017] New: Network tests should fail gracefully without network connectivity

[Bug go/48017] New: Network tests should fail gracefully without network connectivity

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48017

           Summary: Network tests should fail gracefully without network
                    connectivity
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
        AssignedTo: ian@airs.com
        ReportedBy: ro@gcc.gnu.org
              Host: i386-pc-solaris2.11
            Target: i386-pc-solaris2.11
             Build: i386-pc-solaris2.11


The libgo http and net tests FAIL on systems without network connectivity:

FAIL: http
--- FAIL: http.TestClient
    Get http://www.google.com/robots.txt: dial tcp www.google.com:http: dial
udp 129.70.160.15:53: Network is unreachable
--- FAIL: http.TestClientHead
    dial tcp www.google.com:http: dial udp 129.70.160.15:53: Network is
unreachable
--- FAIL: http.TestRedirect
    Get http://google.com/: dial tcp google.com:http: dial udp
129.70.160.15:53: Network is unreachable

FAIL: net
--- FAIL: net.TestDialGoogle
    lookup www.google.com: dial udp 129.70.160.15:53: Network is unreachable
--- FAIL: net.TestGoogleSRV
    failed: dial udp 129.70.160.15:53: Network is unreachable
    no results

Those tests shouldn't FAIL, but instead use UNSUPPORTED (or maybe UNRESOLVED)
instead since this is an expected condition.

[Bug go/48017] Network tests should fail gracefully without network connectivity

[ian at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48017

--- Comment #1 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> 2011-03-09 05:57:15 UTC ---
Author: ian
Date: Wed Mar  9 05:57:10 2011
New Revision: 170809

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170809
Log:
    PR go/48017
Only run net tests if GCCGO_RUN_ALL_TESTS is set in environment.

Modified:
    trunk/libgo/Makefile.am
    trunk/libgo/Makefile.in

[Bug go/48017] Network tests should fail gracefully without network connectivity

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48017

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Ian Lance Taylor <ian at airs dot com> 2011-03-09 05:58:19 UTC ---
Changed to only run the network tests if GCCGO_RUN_ALL_TESTS is set in the
environment.  I think this is a reasonable approach as described at
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00447.html .

Thanks for reporting this.