[Bug go/48020] New: libgo flag test FAILs on Solaris 2

[Bug go/48020] New: libgo flag test FAILs on Solaris 2

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48020

           Summary: libgo flag test FAILs on Solaris 2
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
        AssignedTo: ian@airs.com
        ReportedBy: ro@gcc.gnu.org
              Host: i386-pc-solaris2.11
            Target: i386-pc-solaris2.11
             Build: i386-pc-solaris2.11


The libgo flag test FAILs on Solaris 2:

FAIL: flag
flag provided but not defined: -x
--- FAIL: flag_test.TestEverything
    VisitAll misses some flags
    Visit fails after set

If it is invoked with -match TestEverything, the test works, the failure only
occurs with -match 'TestEverything|TestChangingArgs'

In the failing case, visitor is called with

  "after"
  "before"
  "after"
  "before"
  ...

on success (i.e. with TestEverything alone) with
  "v"
  "test_uint64"
  "match"
  "test_bool"
  "test_string"
  "test_float64"
  ...

[Bug go/48020] libgo flag test FAILs on Solaris 2

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48020

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.03.09 07:09:58
     Ever Confirmed|0                           |1

--- Comment #1 from Ian Lance Taylor <ian at airs dot com> 2011-03-09 07:09:58 UTC ---
I think that the problem is that the functions are not being run in the order
they appear in the file.  Most likely the Solaris nm program is sorting the
test functions by name.  The gotest script passes the -p option, which tells
GNU nm to not sort the functions.  Of course, the gcc middle-end may sort the
functions anyhow, so this is imperfect?

Does the Solaris nm have any option to not sort the symbols?  I don't see one
on the man page I found on the web.

I'm not sure what the best fix is going to be here.

[Bug go/48020] libgo flag test FAILs on Solaris 2

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48020

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2011-03-09 16:09:42 UTC ---
> --- Comment #1 from Ian Lance Taylor <ian at airs dot com> 2011-03-09 07:09:58 UTC ---
> I think that the problem is that the functions are not being run in the order
> they appear in the file.  Most likely the Solaris nm program is sorting the
> test functions by name.  The gotest script passes the -p option, which tells

Right, by default it does.

> GNU nm to not sort the functions.  Of course, the gcc middle-end may sort the
> functions anyhow, so this is imperfect?

Sun nm uses -p to produce the portable output format.

> Does the Solaris nm have any option to not sort the symbols?  I don't see one
> on the man page I found on the web.

You could use -v:

     -v    Sorts  external  symbols  by  value  before  they  are
           printed.

which of course matches the order of the functions in the object file.
This seems to be reasonably portable: GNU nm and the vendor nm's on IRIX
and Tru64 UNIX support it.

> I'm not sure what the best fix is going to be here.

I wonder if it might be an option (at least for a DejaGnu-ified libgo
testsuite) to have individual tests per function instead of per
directory?  This way, it might be easier to see which subtest is
failing, and (undesirable) interactions between them would be avoided.

    Rainer

[Bug go/48020] libgo flag test FAILs on Solaris 2

[ian at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48020

--- Comment #3 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> 2011-03-10 00:51:18 UTC ---
Author: ian
Date: Thu Mar 10 00:51:14 2011
New Revision: 170842

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170842
Log:
    PR go/48020
gotest: Pass -v to nm to avoid sorting on Solaris.

Modified:
    trunk/libgo/testsuite/gotest

[Bug go/48020] libgo flag test FAILs on Solaris 2

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48020

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Ian Lance Taylor <ian at airs dot com> 2011-03-10 00:52:41 UTC ---
This may be fixed now.  Let me know if not.