public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/48031] [4.4/4.5 Regression] gcc.c-torture/compile/pr42956.c ICEs gcc on m68k-linux, ivopts related?
Date: Thu, 10 Mar 2011 12:58:00 -0000	[thread overview]
Message-ID: <bug-48031-4-spimqqZuM1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-48031-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48031

--- Comment #11 from rguenther at suse dot de <rguenther at suse dot de> 2011-03-10 12:57:59 UTC ---
On Thu, 10 Mar 2011, ebotcazou at gcc dot gnu.org wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48031
> 
> --- Comment #10 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-03-10 12:46:33 UTC ---
> > No it isn't.  But given that fold at this place doesn't even
> > fill in the array-ref element-size slot but provides NULL_TREE
> > it is probably a fix for the better anyway?
> 
> Why not explicitly test in_gimple_form like in other places in the folder?

That would work, too.  You see no problem with a NULL operand 3
of array-refs?  If you create an array with a variable lower bound,
take its address, convert it to pointer to element type and
dereference that, would it expand ok if it does not have the
element size set properly?  At least get_inner_reference seems to
unconditionally multiply with array_ref_element_size () * index,
and array_ref_element_size () does not work for variable-size types
if the array-ref doesn't have the gimplified value.

You can probably come up with an Ada testcase that gets miscompiled?
(C arrays always have a lower bound of zero, thus the index
will be zero thus the multiplication ensures that the garbage
returned by array_ref_element_size is thrown away).

Richard.


  parent reply	other threads:[~2011-03-10 12:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 10:01 [Bug target/48031] New: [4,4, 4.5 regression] " mikpe at it dot uu.se
2011-03-08 11:02 ` [Bug tree-optimization/48031] [4.4/4.5 Regression] " rguenth at gcc dot gnu.org
2011-03-08 14:23 ` mikpe at it dot uu.se
2011-03-08 21:40 ` mikpe at it dot uu.se
2011-03-09  9:22 ` rguenther at suse dot de
2011-03-09 23:37 ` mikpe at it dot uu.se
2011-03-10  9:22 ` mikpe at it dot uu.se
2011-03-10  9:34 ` rguenther at suse dot de
2011-03-10 11:03 ` rguenth at gcc dot gnu.org
2011-03-10 12:35 ` ebotcazou at gcc dot gnu.org
2011-03-10 12:36 ` rguenther at suse dot de
2011-03-10 12:46 ` ebotcazou at gcc dot gnu.org
2011-03-10 12:58 ` rguenther at suse dot de [this message]
2011-03-10 13:04 ` ebotcazou at gcc dot gnu.org
2011-03-10 13:07 ` rguenther at suse dot de
2011-03-10 13:10 ` rguenth at gcc dot gnu.org
2011-03-10 14:03 ` mikpe at it dot uu.se
2011-03-15  8:53 ` mikpe at it dot uu.se
2011-03-15 10:06 ` rguenth at gcc dot gnu.org
2011-03-28 10:22 ` rguenth at gcc dot gnu.org
2011-04-10 10:38 ` rguenth at gcc dot gnu.org
2011-04-16 11:18 ` jakub at gcc dot gnu.org
2011-04-18 14:15 ` [Bug tree-optimization/48031] [4.4 " rguenth at gcc dot gnu.org
2011-04-18 14:42 ` [Bug tree-optimization/48031] [4.4/4.5 " rguenth at gcc dot gnu.org
2011-04-18 14:55 ` [Bug tree-optimization/48031] [4.4 " rguenth at gcc dot gnu.org
2012-03-13 16:57 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-48031-4-spimqqZuM1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).