[Bug driver/48071] New: Blank line after 'all warnings being treated as errors'

[Bug driver/48071] New: Blank line after 'all warnings being treated as errors'

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48071

           Summary: Blank line after 'all warnings being treated as
                    errors'
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: driver
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dnovillo@gcc.gnu.org


After -Werror is triggered, we are now emitting an extra blank line
that we were not emitting before.

$ cat a.cc
char c = 257;
$ g++-4.4.3 -c -o /dev/null -Werror a.cc
cc1plus: warnings being treated as errors
a.cc:1: error: overflow in implicit constant conversion
$

But with trunk, I get:

$ ~/gcc-trunk/native/bin/g++ -c -o /dev/null -Werror a.cc
a.cc:1:10: error: overflow in implicit constant conversion [-Werror=overflow]
cc1plus: all warnings being treated as errors
[... extra blank line ...]
$

[Bug middle-end/48071] [4.6/4.7 Regression] Blank line after 'all warnings being treated as errors'

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48071

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-02-01
          Component|driver                      |middle-end
   Target Milestone|---                         |4.6.3
            Summary|Blank line after 'all       |[4.6/4.7 Regression] Blank
                   |warnings being treated as   |line after 'all warnings
                   |errors'                     |being treated as errors'
     Ever Confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-02-01 19:41:49 UTC ---
Confirmed.

[Bug middle-end/48071] [4.6/4.7 Regression] Blank line after 'all warnings being treated as errors'

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48071

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-02 15:18:59 UTC ---
Caused by http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158168

[Bug middle-end/48071] [4.6/4.7 Regression] Blank line after 'all warnings being treated as errors'

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48071

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-02 15:20:15 UTC ---
Created attachment 26554
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26554
gcc47-pr48071.patch

Untested fix.

[Bug middle-end/48071] [4.6/4.7 Regression] Blank line after 'all warnings being treated as errors'

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48071

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-02 20:46:09 UTC ---
Author: jakub
Date: Thu Feb  2 20:46:06 2012
New Revision: 183847

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183847
Log:
    PR middle-end/48071
    * diagnostic.c (diagnostic_finish): Remove trailing newlines.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/diagnostic.c

[Bug middle-end/48071] [4.6 Regression] Blank line after 'all warnings being treated as errors'

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48071

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.6/4.7 Regression] Blank  |[4.6 Regression] Blank line
                   |line after 'all warnings    |after 'all warnings being
                   |being treated as errors'    |treated as errors'

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-02 20:48:13 UTC ---
Fixed on the trunk so far.

[Bug middle-end/48071] [4.6 Regression] Blank line after 'all warnings being treated as errors'

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48071

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-09 17:26:41 UTC ---
Author: jakub
Date: Thu Feb  9 17:26:29 2012
New Revision: 184058

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184058
Log:
    Backported from mainline
    2012-02-02  Jakub Jelinek  <jakub@redhat.com>

    PR middle-end/48071
    * diagnostic.c (diagnostic_finish): Remove trailing newlines.

Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/diagnostic.c

[Bug middle-end/48071] [4.6 Regression] Blank line after 'all warnings being treated as errors'

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48071

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-09 17:49:06 UTC ---
Fixed.