public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "paolo.carlini at oracle dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/48087] -Wall -Werror adds warnings over and above those generated by -Wall
Date: Tue, 18 Oct 2011 01:19:00 -0000	[thread overview]
Message-ID: <bug-48087-4-QcPpn5lO7R@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-48087-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48087

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-10-18
                 CC|                            |paolo.carlini at oracle dot
                   |                            |com
     Ever Confirmed|0                           |1

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-10-18 01:18:24 UTC ---
Well, this does, it (fixes both) but I don't know if we are aiming for
something better, no good including the whole "diagnostic.h"?!?

Index: tree-cfg.c
===================================================================
--- tree-cfg.c    (revision 180119)
+++ tree-cfg.c    (working copy)
@@ -37,7 +37,7 @@ along with GCC; see the file COPYING3.  If not see
 #include "timevar.h"
 #include "tree-dump.h"
 #include "tree-pass.h"
-#include "diagnostic-core.h"
+#include "diagnostic.h"
 #include "except.h"
 #include "cfgloop.h"
 #include "cfglayout.h"
@@ -7380,7 +7380,8 @@ execute_warn_function_return (void)
   else if (warn_return_type
        && !TREE_NO_WARNING (cfun->decl)
        && EDGE_COUNT (EXIT_BLOCK_PTR->preds) > 0
-       && !VOID_TYPE_P (TREE_TYPE (TREE_TYPE (cfun->decl))))
+       && !VOID_TYPE_P (TREE_TYPE (TREE_TYPE (cfun->decl)))
+       && !errorcount)
     {
       FOR_EACH_EDGE (e, ei, EXIT_BLOCK_PTR->preds)
     {


  parent reply	other threads:[~2011-10-18  1:19 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-12  6:21 [Bug c++/48087] New: " cgd at google dot com
2011-10-18  0:54 ` [Bug c++/48087] " paolo.carlini at oracle dot com
2011-10-18  1:19 ` paolo.carlini at oracle dot com [this message]
2011-10-18  1:22 ` paolo.carlini at oracle dot com
2011-10-18  1:30 ` [Bug middle-end/48087] [4.5/4.6/4.7 Regression] " paolo.carlini at oracle dot com
2011-10-18  8:26 ` rguenther at suse dot de
2011-10-18  9:42 ` paolo.carlini at oracle dot com
2011-10-18 15:44 ` manu at gcc dot gnu.org
2011-10-18 16:03 ` paolo.carlini at oracle dot com
2011-10-18 16:10 ` paolo.carlini at oracle dot com
2011-10-18 20:23 ` manu at gcc dot gnu.org
2011-10-18 23:42 ` paolo.carlini at oracle dot com
2011-10-19  1:44 ` manu at gcc dot gnu.org
2011-10-19  7:49 ` rguenther at suse dot de
2011-10-19 15:39 ` paolo.carlini at oracle dot com
2011-10-19 15:53 ` paolo.carlini at oracle dot com
2011-10-19 17:24 ` manu at gcc dot gnu.org
2011-10-19 17:28 ` paolo.carlini at oracle dot com
2011-10-27  9:27 ` rguenth at gcc dot gnu.org
2011-10-27  9:39 ` rguenth at gcc dot gnu.org
2011-10-27 10:21 ` paolo.carlini at oracle dot com
2011-10-27 10:26 ` rguenther at suse dot de
2011-12-06 10:09 ` rguenth at gcc dot gnu.org
2012-07-02 12:23 ` [Bug middle-end/48087] [4.5/4.6/4.7/4.8 " rguenth at gcc dot gnu.org
2013-01-15 15:12 ` [Bug middle-end/48087] [4.6/4.7/4.8 " jakub at gcc dot gnu.org
2013-01-15 16:40 ` manu at gcc dot gnu.org
2013-03-21 20:03 ` [Bug middle-end/48087] [4.6/4.7/4.8/4.9 " jakub at gcc dot gnu.org
2013-04-12 15:18 ` [Bug middle-end/48087] [4.7/4.8/4.9 " jakub at gcc dot gnu.org
2014-01-23  7:21 ` law at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-48087-4-QcPpn5lO7R@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).