[Bug rtl-optimization/48143] New: ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[Bug rtl-optimization/48143] New: ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

           Summary: ICE: in reset_sched_cycles_in_current_ebb, at
                    sel-sched.c:7114 with custom flags
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu


Created attachment 23675
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23675
reduced testcase

Compiler output:
$ gcc -ftree-vectorize -O2 -fno-dce -fno-ivopts -fsel-sched-pipelining
-fselective-scheduling2 -funroll-loops --param=max-cse-insns=50
--param=max-pending-list-length=50 testcase.c
testcase.c: In function ‘foo’:
testcase.c:13:1: internal compiler error: in reset_sched_cycles_in_current_ebb,
at sel-sched.c:7114
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Tested revisions:
r171001 - crash
4.6 r170955 - crash
4.5 r170955 - OK

[Bug rtl-optimization/48143] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

Andrey Belevantsev <abel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.03.16 07:33:21
         AssignedTo|unassigned at gcc dot       |abel at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Andrey Belevantsev <abel at gcc dot gnu.org> 2011-03-16 07:33:21 UTC ---
Confirmed, I will take a look.

[Bug rtl-optimization/48143] [4.6/4.7 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.0
            Summary|ICE: in                     |[4.6/4.7 Regression] ICE:
                   |reset_sched_cycles_in_curre |in
                   |nt_ebb, at sel-sched.c:7114 |reset_sched_cycles_in_curre
                   |with custom flags           |nt_ebb, at sel-sched.c:7114
                   |                            |with custom flags

[Bug rtl-optimization/48143] [4.6/4.7 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

Andrey Belevantsev <abel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubizjak at gmail dot com

--- Comment #2 from Andrey Belevantsev <abel at gcc dot gnu.org> 2011-03-18 14:35:30 UTC ---
We ICE because we again issue more than issue_rate insns.  And this happens
because we hit an insn which does not modify the DFA state at all, thus we do
not account for it when checking that we obey issue_rate limits.  The insn is
coming from sse2_cvtps2pd pattern of sse.md and it doesn't have a reservation
(has "nothing").

I don't have any idea how the pattern attributes should be fixed, but the
following seems to work on the test case.  Uros, does this make sense?


diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index ba2bf24..71c4bb7 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -2878,6 +2878,7 @@
    (set_attr "prefix" "maybe_vex")
    (set_attr "mode" "V2DF")
    (set_attr "prefix_data16" "0")
+   (set_attr "athlon_decode" "double")
    (set_attr "amdfam10_decode" "direct")
    (set_attr "bdver1_decode" "double")])

[Bug rtl-optimization/48143] [4.6/4.7 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

--- Comment #3 from Uros Bizjak <ubizjak at gmail dot com> 2011-03-18 16:39:36 UTC ---
(In reply to comment #2)
> We ICE because we again issue more than issue_rate insns.  And this happens
> because we hit an insn which does not modify the DFA state at all, thus we do
> not account for it when checking that we obey issue_rate limits.  The insn is
> coming from sse2_cvtps2pd pattern of sse.md and it doesn't have a reservation
> (has "nothing").
> 
> I don't have any idea how the pattern attributes should be fixed, but the
> following seems to work on the test case.  Uros, does this make sense?

Sure, but there are some other patterns missing athlon_decode attribute:

*sse2_cvtpd2dq
*sse2_cvttpd2dq
sse2_cvtss2sd
*sse2_cvtpd2ps
sse2_cvtps2pd

Can you please add missing athlon_decode attribute also for these?

Patch is pre-approved for 4.7 and needs RM approval for 4.6.

[Bug rtl-optimization/48143] [4.6/4.7 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steven at gcc dot gnu.org

--- Comment #4 from Steven Bosscher <steven at gcc dot gnu.org> 2011-03-19 16:51:02 UTC ---
Is it possible to check for this kind of problem in genautomata?

[Bug rtl-optimization/48143] [4.6/4.7 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

--- Comment #5 from Andrey Belevantsev <abel at gcc dot gnu.org> 2011-03-22 12:34:02 UTC ---
Author: abel
Date: Tue Mar 22 12:33:53 2011
New Revision: 171286

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171286
Log:
        PR rtl-optimization/48143
        * config/i386/sse.md (*sse2_cvtpd2dq): Add athlon_decode attribute.
        (*sse2_cvttpd2dq, sse2_cvtss2sd, *sse2_cvtpd2ps,
        sse2_cvtps2pd): Likewise.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/sse.md

[Bug rtl-optimization/48143] [4.6/4.7 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.6.0                       |4.6.1

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-03-25 19:52:49 UTC ---
GCC 4.6.0 is being released, adjusting target milestone.

[Bug rtl-optimization/48143] [4.6 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
      Known to work|                            |4.7.0
            Summary|[4.6/4.7 Regression] ICE:   |[4.6 Regression] ICE: in
                   |in                          |reset_sched_cycles_in_curre
                   |reset_sched_cycles_in_curre |nt_ebb, at sel-sched.c:7114
                   |nt_ebb, at sel-sched.c:7114 |with custom flags
                   |with custom flags           |
      Known to fail|4.7.0                       |

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-03-31 11:37:03 UTC ---
Do you plan to backport this to 4.6 branch?

[Bug rtl-optimization/48143] [4.6 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

--- Comment #8 from Andrey Belevantsev <abel at gcc dot gnu.org> 2011-03-31 11:44:46 UTC ---
(In reply to comment #7)
> Do you plan to backport this to 4.6 branch?
Sure, I was just waiting for 4.6.0 to take off.

[Bug rtl-optimization/48143] [4.6 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

--- Comment #9 from Andrey Belevantsev <abel at gcc dot gnu.org> 2011-04-01 11:07:47 UTC ---
Author: abel
Date: Fri Apr  1 11:07:44 2011
New Revision: 171825

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171825
Log:
        Backport from mainline
        2011-03-22  Andrey Belevantsev  <abel@ispras.ru>

        PR rtl-optimization/48143
        * config/i386/sse.md (*sse2_cvtpd2dq): Add athlon_decode attribute.
        (*sse2_cvttpd2dq, sse2_cvtss2sd, *sse2_cvtpd2ps,
        sse2_cvtps2pd): Likewise.


Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/config/i386/sse.md

[Bug rtl-optimization/48143] [4.6 Regression] ICE: in reset_sched_cycles_in_current_ebb, at sel-sched.c:7114 with custom flags

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48143

Andrey Belevantsev <abel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Andrey Belevantsev <abel at gcc dot gnu.org> 2011-04-01 11:09:10 UTC ---
Fixed on trunk and 4.6.