[Bug tree-optimization/48170] New: ICE: in hoist_code, at gcse.c:4524 with -fgcse --param max-hoist-depth={0,1}

[Bug tree-optimization/48170] New: ICE: in hoist_code, at gcse.c:4524 with -fgcse --param max-hoist-depth={0,1}

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48170

           Summary: ICE: in hoist_code, at gcse.c:4524 with -fgcse --param
                    max-hoist-depth={0,1}
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz
                CC: mkuvyrkov@gcc.gnu.org
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu


Created attachment 23701
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23701
reduced testcase

Compiler output:
$ gcc -O -fgcse --param max-hoist-depth=1 testcase.c 
testcase.c: In function 'bar':
testcase.c:10:1: internal compiler error: in hoist_code, at gcse.c:4524
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

The same happens for max-hoist-depth=1, though if I understand the
documentation correctly, 1 means "depth 1", 0 means "unlimited" (so maybe
"gcc_assert (MAX_HOIST_DEPTH > 1)" checks the value is not one of these
extrems?).

Tested revisions:
r171088 - crash
4.6 r170955 - crash
4.5 - doesn't know max-hoist-depth

[Bug tree-optimization/48170] ICE: in hoist_code, at gcse.c:4524 with -fgcse --param max-hoist-depth={0,1}

[mkuvyrkov at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48170

Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.03.18 09:28:02
     Ever Confirmed|0                           |1

--- Comment #1 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> 2011-03-18 09:28:02 UTC ---
Mine.

The asserts should definitely say (MAX_HOIST_DEPTH == 0 || MAX_HOIST_DEPTH >
1).  I will need to investigate why this is failing for depth == 1.

[Bug rtl-optimization/48170] ICE: in hoist_code, at gcse.c:4524 with -fgcse --param max-hoist-depth={0,1}

[mkuvyrkov at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48170

Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tree-optimization           |rtl-optimization

--- Comment #2 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> 2011-03-18 10:57:25 UTC ---
The asserts are bogus, they probably used to verify an invariant that was
removed by a later improvement.  Will check in a fix soon.

[Bug rtl-optimization/48170] ICE: in hoist_code, at gcse.c:4524 with -fgcse --param max-hoist-depth={0,1}

[mkuvyrkov at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48170

--- Comment #3 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> 2011-03-18 17:12:24 UTC ---
Author: mkuvyrkov
Date: Fri Mar 18 17:12:19 2011
New Revision: 171155

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171155
Log:
    PR rtl-optimization/48170
    * gcse.c (hoist_code): Remove bogus asserts.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gcse.c

[Bug rtl-optimization/48170] ICE: in hoist_code, at gcse.c:4524 with -fgcse --param max-hoist-depth={0,1}

[mkuvyrkov at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48170

Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> 2011-03-18 17:24:03 UTC ---
Fixed.