[Bug testsuite/48238] New: FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[Bug testsuite/48238] New: FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

           Summary: FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler
                    on *-apple-darwin*
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr
                CC: rguenther@suse.de


revision:         171245
Author:    rguenth
Date:    Mon Mar 21 15:32:21 2011 UTC (22 hours, 54 minutes ago)
Changed paths:    7
Log Message:    
2011-03-21  Richard Guenther  <rguenther@suse.de>

    PR c/47939
    * c-decl.c (grokdeclarator): Drop to the main variant only
    for array types.  Drop flag_gen_aux_info check.

    * gcc.dg/debug/dwarf2/pr47939-1.c: New testcase.
    * gcc.dg/debug/dwarf2/pr47939-2.c: Likewise.
    * gcc.dg/debug/dwarf2/pr47939-3.c: Likewise.
    * gcc.dg/debug/dwarf2/pr47939-4.c: Likewise.

These tests fail on *-apple-darwin* (see
http://gcc.gnu.org/ml/gcc-testresults/2011-03/msg02177.html). The occurrences
of 'Harry_t' in the assembly file are:

   39 -     .byte    0x5    # DW_AT_encoding
   40 -     .ascii "int\0"    # DW_AT_name
   41 -     .byte    0x5    # uleb128 0x5; (DIE (0xc2) DW_TAG_typedef)
   42 :     .ascii "Harry_t\0"    # DW_AT_name
   43 +     .byte    0x1    # DW_AT_decl_file
(/opt/gcc/work/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-1.c)
   44 +     .byte    0x4    # DW_AT_decl_line
   45 +     .long    0x9b    # DW_AT_type
  165 -     .long    0x9b    # DIE offset
  166 -     .ascii "_Harry\0"    # external name
  167 -     .long    0xc2    # DIE offset
  168 :     .ascii "Harry_t\0"    # external name
  169 +     .long    0
  170 +     .section __DWARF,__debug_line,regular,debug
  171 + Lsection__debug_line:

[Bug testsuite/48238] FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-03-22 14:50:40 UTC ---
On x86-linux it is

        .uleb128 0x5    # (DIE (0x4b) DW_TAG_typedef)
        .long   .LASF4  # DW_AT_name: "Harry_t"

what we match.

Better regexps appreciated.

[Bug testsuite/48238] FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-03-22 14:57:37 UTC ---
For such tests it is better to use -fno-merge-debug-strings in dg-options and
match what that produces, otherwise the regexps need to cover both merging and
non-merging...

[Bug testsuite/48238] FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-03-22 15:11:16 UTC ---
> Better regexps appreciated.

/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*(DW_AT_name:
\"Harry_t\"|\"Harry_t..\".*DW_AT_name)" } } */

works for me, hence

--- ../_clean/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-1.c    2011-03-21
19:22:34.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-1.c    2011-03-22
16:00:14.000000000 +0100
@@ -4,5 +4,5 @@
 typedef struct _Harry { int dummy; } Harry_t;
 Harry_t harry;

-/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*DW_AT_name: \"Harry_t\"" } }
*/
+/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*(DW_AT_name:
\"Harry_t\"|\"Harry_t..\".*DW_AT_name)" } } */
 /* { dg-final { cleanup-saved-temps } } */
--- ../_clean/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-2.c    2011-03-21
19:22:34.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-2.c    2011-03-22
16:04:14.000000000 +0100
@@ -4,5 +4,5 @@
 typedef const struct _Harry { int dummy; } Harry_t;
 Harry_t harry;

-/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*DW_AT_name: \"Harry_t\"" } }
*/
+/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*(DW_AT_name:
\"Harry_t\"|\"Harry_t..\".*DW_AT_name)" } } */
 /* { dg-final { cleanup-saved-temps } } */
--- ../_clean/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-3.c    2011-03-21
19:22:34.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-3.c    2011-03-22
16:04:40.000000000 +0100
@@ -4,5 +4,5 @@
 typedef struct _Harry { int dummy; } Harry_t;
 const Harry_t harry[5];

-/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*DW_AT_name: \"Harry_t\"" } }
*/
+/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*(DW_AT_name:
\"Harry_t\"|\"Harry_t..\".*DW_AT_name)" } } */
 /* { dg-final { cleanup-saved-temps } } */
--- ../_clean/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-4.c    2011-03-21
19:22:34.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-4.c    2011-03-22
16:05:13.000000000 +0100
@@ -4,5 +4,5 @@
 typedef const struct _Harry { int dummy; } Harry_t;
 Harry_t harry[10];

-/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*DW_AT_name: \"Harry_t\"" } }
*/
+/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*(DW_AT_name:
\"Harry_t\"|\"Harry_t..\".*DW_AT_name)" } } */
 /* { dg-final { cleanup-saved-temps } } */

leads to

...
Running /opt/gcc/work/gcc/testsuite/gcc.dg/debug/dwarf2/dwarf2.exp ...

        === gcc Summary for unix/-m64 ===

# of expected passes        369
# of unsupported tests        5

        === gcc Summary ===

# of expected passes        738
# of unsupported tests        10

[Bug testsuite/48238] FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

--- Comment #4 from Andreas Schwab <schwab@linux-m68k.org> 2011-03-22 15:28:56 UTC ---
You should avoid .* because that can result in multi-line matches.  Use [^\n]*
instead.

[Bug testsuite/48238] FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-03-22 22:06:10 UTC ---
> You should avoid .* because that can result in multi-line matches.  Use [^\n]*
> instead.

Is

--- ../_clean/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-1.c    2011-03-21
19:22:34.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-1.c    2011-03-22
22:59:23.000000000 +0100
@@ -4,5 +4,5 @@
 typedef struct _Harry { int dummy; } Harry_t;
 Harry_t harry;

-/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*DW_AT_name: \"Harry_t\"" } }
*/
+/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*(DW_AT_name:
\"Harry_t\"|\"Harry_t..\"\[^\\r\\n\]*DW_AT_name)" } } */
 /* { dg-final { cleanup-saved-temps } } */
--- ../_clean/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-2.c    2011-03-21
19:22:34.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-2.c    2011-03-22
22:59:38.000000000 +0100
@@ -4,5 +4,5 @@
 typedef const struct _Harry { int dummy; } Harry_t;
 Harry_t harry;

-/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*DW_AT_name: \"Harry_t\"" } }
*/
+/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*(DW_AT_name:
\"Harry_t\"|\"Harry_t..\"\[^\\r\\n\]*DW_AT_name)" } } */
 /* { dg-final { cleanup-saved-temps } } */
--- ../_clean/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-3.c    2011-03-21
19:22:34.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-3.c    2011-03-22
22:59:52.000000000 +0100
@@ -4,5 +4,5 @@
 typedef struct _Harry { int dummy; } Harry_t;
 const Harry_t harry[5];

-/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*DW_AT_name: \"Harry_t\"" } }
*/
+/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*(DW_AT_name:
\"Harry_t\"|\"Harry_t..\"\[^\\r\\n\]*DW_AT_name)" } } */
 /* { dg-final { cleanup-saved-temps } } */
--- ../_clean/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-4.c    2011-03-21
19:22:34.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-4.c    2011-03-22
23:00:06.000000000 +0100
@@ -4,5 +4,5 @@
 typedef const struct _Harry { int dummy; } Harry_t;
 Harry_t harry[10];

-/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*DW_AT_name: \"Harry_t\"" } }
*/
+/* { dg-final { scan-assembler
"DW_TAG_typedef\[^\\r\\n\]*\[\\r\\n\]+\[^\\r\\n\]*(DW_AT_name:
\"Harry_t\"|\"Harry_t..\"\[^\\r\\n\]*DW_AT_name)" } } */
 /* { dg-final { cleanup-saved-temps } } */

better?

[Bug testsuite/48238] FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

--- Comment #6 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-03-22 22:10:23 UTC ---
> For such tests it is better to use -fno-merge-debug-strings in dg-options and
> match what that produces, otherwise the regexps need to cover both merging and
> non-merging...

On x86_64-apple-darwin10.6.0 '-fno-merge-debug-strings' does not change the
assembly.

[Bug testsuite/48238] FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.03.25 10:02:18
                 CC|                            |ro at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #7 from Rainer Orth <ro at gcc dot gnu.org> 2011-03-25 10:02:18 UTC ---
Also affects Solaris with Sun as and IRIX 6.5 with gas:

Solaris:

        .byte   0x5     ! uleb128 0x5; (DIE (0xc6) DW_TAG_typedef)
        .ascii "Harry_t\0"      ! DW_AT_name

IRIX:
        .uleb128 0x5     # (DIE (0xc9) DW_TAG_typedef)
        .ascii "Harry_t\0"       # DW_AT_name

Dominique's last patch works for me (but please rather attach patches to the
PR; they are far easier to apply this way).

[Bug testsuite/48238] FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

--- Comment #8 from Rainer Orth <ro at gcc dot gnu.org> 2011-03-28 16:39:44 UTC ---
Author: ro
Date: Mon Mar 28 16:39:35 2011
New Revision: 171615

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171615
Log:
2011-03-26  Dominique d'Humieres  <dominiq@lps.ens.fr>

    PR testsuite/48238
    * gcc.dg/debug/dwarf2/pr47939-1.c: Generalize scan-assembler regex.
    * gcc.dg/debug/dwarf2/pr47939-2.c: Likewise.
    * gcc.dg/debug/dwarf2/pr47939-3.c: Likewise.
    * gcc.dg/debug/dwarf2/pr47939-4.c: Likewise.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-1.c
    trunk/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-2.c
    trunk/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-3.c
    trunk/gcc/testsuite/gcc.dg/debug/dwarf2/pr47939-4.c

[Bug testsuite/48238] FAIL: gcc.dg/debug/dwarf2/pr47939-0.c scan-assembler on *-apple-darwin*

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48238

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-03/msg01918
         Resolution|                            |FIXED
         AssignedTo|unassigned at gcc dot       |ro at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.7.0

--- Comment #9 from Rainer Orth <ro at gcc dot gnu.org> 2011-03-28 16:42:51 UTC ---
Applied the patch after testing.

Thanks.
  Rainer