[Bug lto/48246] New: ICE in lto_wpa_write_files

[Bug lto/48246] New: ICE in lto_wpa_write_files

[gpiez at web dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

           Summary: ICE in lto_wpa_write_files
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: gpiez@web.de


Created attachment 23754
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23754
testcase

I get an ICE when compiling the testcase with

g++ -r  -nostdlib testcase.ii -O3  -flto  -o /dev/null

Error message is lto1: internal compiler error: in lto_wpa_write_files, at
lto/lto.c:1518
This is gcc-4.6.0-rc2.

[Bug lto/48246] ICE in lto_wpa_write_files

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.03.23 10:00:36
                 CC|                            |hubicka at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-03-23 10:00:36 UTC ---
Confirmed.

An intermediate partition is completely empty (ltrans_partitions[2], after
lto_balanced_map (), out of 7 partitions in total).  Sorting moves that
empty partition last.

We do seem to allow a single empty partition (probably for an empty CU):

      gcc_assert (cgraph_node_set_nonempty_p (set)
                  || varpool_node_set_nonempty_p (vset) || !i);

so we could change !i for i == n_sets-1, but I suppose we could arrive
with multiple empty partitions here as well.

Honza, why do we even care to assert the above if we handle empty
partitions just fine (in case of !i)?  It looks like some partitioning
sanity check to me, not something we should assert on.

[Bug lto/48246] ICE in lto_wpa_write_files

[hubicka at ucw dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

--- Comment #2 from Jan Hubicka <hubicka at ucw dot cz> 2011-03-23 13:07:58 UTC ---
> Honza, why do we even care to assert the above if we handle empty
> partitions just fine (in case of !i)?  It looks like some partitioning
> sanity check to me, not something we should assert on.
The reason was that empty partition imply overhead and there is no need for
that, so I would preffer partitioning algs to never create the empty parts
(there was various issues with partitioning that lead to them).
But for release branch, dropping the assert is just fine.

Honza

[Bug lto/48246] ICE in lto_wpa_write_files

[bastiaan at bjacques dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

Bastiaan Jacques <bastiaan at bjacques dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bastiaan at bjacques dot
                   |                            |org

--- Comment #3 from Bastiaan Jacques <bastiaan at bjacques dot org> 2011-03-31 01:47:52 UTC ---
(In reply to comment #2)
> But for release branch, dropping the assert is just fine.

Then will you please do that?

[Bug lto/48246] ICE in lto_wpa_write_files

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-03-31 10:00:48 UTC ---
Author: rguenth
Date: Thu Mar 31 10:00:44 2011
New Revision: 171774

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171774
Log:
2011-03-31  Richard Guenther  <rguenther@suse.de>

    PR lto/48246
    * lto.c (lto_wpa_write_files): Disable assert for non-empty
    partitions when checking is not enabled.

Modified:
    branches/gcc-4_6-branch/gcc/lto/ChangeLog
    branches/gcc-4_6-branch/gcc/lto/lto.c

[Bug lto/48246] ICE in lto_wpa_write_files

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-03-31 10:02:03 UTC ---
Author: rguenth
Date: Thu Mar 31 10:02:00 2011
New Revision: 171775

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171775
Log:
2011-03-31  Richard Guenther  <rguenther@suse.de>

    PR lto/48246
    * lto.c (lto_wpa_write_files): Disable assert for non-empty
    partitions when checking is not enabled.

Modified:
    trunk/gcc/lto/ChangeLog
    trunk/gcc/lto/lto.c

[Bug lto/48246] ICE in lto_wpa_write_files

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-checking

--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-03-31 10:02:29 UTC ---
Done.

[Bug lto/48246] ICE in lto_wpa_write_files

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincenzo.innocente at cern
                   |                            |dot ch

--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-04-04 12:33:35 UTC ---
*** Bug 48433 has been marked as a duplicate of this bug. ***

[Bug lto/48246] ICE in lto_wpa_write_files

[vincenzo.innocente at cern dot ch]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

--- Comment #8 from vincenzo Innocente <vincenzo.innocente at cern dot ch> 2011-04-04 13:22:26 UTC ---
I downloaded and installed
gcc version 4.6.1 20110401
as I issued a "make" in the same area where I had the ICE in
lto_wpa_write_files
I got
lto1: internal compiler error: in lto_reissue_options, at lto-opts.c:418.

Once "make clean" and rebuild from scratch things when fine.
So it looks to me that the new version cannot use previously produced object
files
Besides this minor point (I had only to wait 45 minutes using 8 cpus to have my
full application to build)
I confim that LATEST/4.6.1 solves the issue

[Bug lto/48246] ICE in lto_wpa_write_files

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |petr.malik at hotmail dot
                   |                            |com

--- Comment #9 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-05-19 11:15:19 UTC ---
*** Bug 49059 has been marked as a duplicate of this bug. ***

[Bug lto/48246] ICE in lto_wpa_write_files

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com

--- Comment #10 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-16 13:15:32 UTC ---
*** Bug 49439 has been marked as a duplicate of this bug. ***

[Bug lto/48246] ICE in lto_wpa_write_files

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

--- Comment #11 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-18 10:51:45 UTC ---
Author: hubicka
Date: Sat Jun 18 10:51:43 2011
New Revision: 175175

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175175
Log:
oops, comitted with wrong PR# :(
    PR lto/48246
    * lto.c (lto_1_to_1_map): Don't create empty partitions.
    (lto_balanced_map): Likewise.

Modified:
    trunk/gcc/lto/ChangeLog

[Bug lto/48246] ICE in lto_wpa_write_files

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

--- Comment #12 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-18 10:53:08 UTC ---
The problem should be fixed on mainline now. Concerning comment #8, the problem
is that LTO files needs to be rebuild after every compiler update.  Official
release will bump up LTO file version number and diagnoze the issue as version
mismatch. For sources pulled out of SVN you get this kind of errors.

[Bug lto/48246] ICE in lto_wpa_write_files

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-08-02 14:13:36 UTC ---
This no longer reproduces on trunk and was mitigated on the branch, closing.

[Bug lto/48246] ICE in lto_wpa_write_files

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

--- Comment #14 from Peter Bergner <bergner at gcc dot gnu.org> 2012-04-23 12:44:51 UTC ---
Author: bergner
Date: Mon Apr 23 12:44:46 2012
New Revision: 186703

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186703
Log:
    Backport from mainline
    2011-06-11  Jan Hubicka  <jh@suse.cz>

    PR lto/48246
    * lto.c (lto_1_to_1_map): Don't create empty partitions.
    (lto_balanced_map): Likewise.

Modified:
    branches/gcc-4_6-branch/gcc/lto/ChangeLog
    branches/gcc-4_6-branch/gcc/lto/lto.c

[Bug lto/48246] ICE in lto_wpa_write_files

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48246

--- Comment #15 from Peter Bergner <bergner at gcc dot gnu.org> 2012-04-23 16:40:10 UTC ---
Author: bergner
Date: Mon Apr 23 16:39:59 2012
New Revision: 186714

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186714
Log:
    Merge up to 186704 (pick up PR lto/48246).
    * REVISION: Update subversion id.

Modified:
    branches/ibm/gcc-4_6-branch/   (props changed)
    branches/ibm/gcc-4_6-branch/gcc/ChangeLog
    branches/ibm/gcc-4_6-branch/gcc/ChangeLog.ibm
    branches/ibm/gcc-4_6-branch/gcc/DATESTAMP
    branches/ibm/gcc-4_6-branch/gcc/REVISION
    branches/ibm/gcc-4_6-branch/gcc/config/alpha/linux-unwind.h
    branches/ibm/gcc-4_6-branch/gcc/config/bfin/linux-unwind.h
    branches/ibm/gcc-4_6-branch/gcc/config/i386/linux-unwind.h
    branches/ibm/gcc-4_6-branch/gcc/config/ia64/linux-unwind.h
    branches/ibm/gcc-4_6-branch/gcc/config/mips/linux-unwind.h
    branches/ibm/gcc-4_6-branch/gcc/config/pa/linux-unwind.h
    branches/ibm/gcc-4_6-branch/gcc/config/sh/linux-unwind.h
    branches/ibm/gcc-4_6-branch/gcc/config/xtensa/linux-unwind.h
    branches/ibm/gcc-4_6-branch/gcc/lto/ChangeLog
    branches/ibm/gcc-4_6-branch/gcc/lto/lto.c

Propchange: branches/ibm/gcc-4_6-branch/
            ('svn:mergeinfo' modified)

Propchange: branches/ibm/gcc-4_6-branch/
            ('svnmerge-integrated' modified)