public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/48337] New: [4.7 regression] options.c doesn't compile on SPARC
@ 2011-03-29 14:38 ro at gcc dot gnu.org
  2011-03-29 15:08 ` [Bug bootstrap/48337] " joseph at codesourcery dot com
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2011-03-29 14:38 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48337

           Summary: [4.7 regression] options.c doesn't compile on SPARC
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ro@gcc.gnu.org
                CC: ebotcazou@gcc.gnu.org, jsm28@gcc.gnu.org
              Host: sparc-sun-solaris2.*
            Target: sparc-sun-solaris2.*
             Build: sparc-sun-solaris2.*


As already reported by Art Haas on the gcc list, SPARC bootstrap is broken
since
Joseph's recent sparc option patch:

options.c:753:3: error: enum conversion in initialization is invalid in C++
[-Werror=c++-compat]
options.c:753:3: error: (near initialization for
'global_options_init.x_sparc_cpu_and_features') [-Werror=c++-compat]
options.c:755:3: error: enum conversion in initialization is invalid in C++
[-Werror=c++-compat]
options.c:755:3: error: (near initialization for
'global_options_init.x_sparc_cpu') [-Werror=c++-compat]

The lines in question are:

  0, /* sparc_cpu_and_features */
  0, /* sparc_std_struct_return */
  0, /* sparc_cpu */

Since I could make no sense of the options machinery, I've added

options.o-warn = -Wno-error

to gcc/Makefile.in as a workaround.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/48337] [4.7 regression] options.c doesn't compile on SPARC
  2011-03-29 14:38 [Bug bootstrap/48337] New: [4.7 regression] options.c doesn't compile on SPARC ro at gcc dot gnu.org
@ 2011-03-29 15:08 ` joseph at codesourcery dot com
  2011-03-29 15:50 ` ro at CeBiTec dot Uni-Bielefeld.DE
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: joseph at codesourcery dot com @ 2011-03-29 15:08 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48337

--- Comment #1 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2011-03-29 14:51:01 UTC ---
On Tue, 29 Mar 2011, ro at gcc dot gnu.org wrote:

> options.c:753:3: error: enum conversion in initialization is invalid in C++
> [-Werror=c++-compat]
> options.c:753:3: error: (near initialization for
> 'global_options_init.x_sparc_cpu_and_features') [-Werror=c++-compat]
> options.c:755:3: error: enum conversion in initialization is invalid in C++
> [-Werror=c++-compat]
> options.c:755:3: error: (near initialization for
> 'global_options_init.x_sparc_cpu') [-Werror=c++-compat]

Try adding Init(PROCESSOR_V7) to the lines in sparc.opt defining sparc_cpu 
and sparc_cpu_and_features.  It appears an explicit initializer of 0 for 
these enums isn't being accepted even where an implicit 0 from the lack of 
initializer (when a variable rather than a field was used) was accepted.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/48337] [4.7 regression] options.c doesn't compile on SPARC
  2011-03-29 14:38 [Bug bootstrap/48337] New: [4.7 regression] options.c doesn't compile on SPARC ro at gcc dot gnu.org
  2011-03-29 15:08 ` [Bug bootstrap/48337] " joseph at codesourcery dot com
@ 2011-03-29 15:50 ` ro at CeBiTec dot Uni-Bielefeld.DE
  2011-03-29 16:07 ` ro at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2011-03-29 15:50 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48337

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2011-03-29 15:43:39 UTC ---
> Try adding Init(PROCESSOR_V7) to the lines in sparc.opt defining sparc_cpu 
> and sparc_cpu_and_features.  It appears an explicit initializer of 0 for 
> these enums isn't being accepted even where an implicit 0 from the lack of 
> initializer (when a variable rather than a field was used) was accepted.

That did the trick, together with a similar change in sparc.c.

I'll submit the patch shortly.

Thanks.
    Rainer


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/48337] [4.7 regression] options.c doesn't compile on SPARC
  2011-03-29 14:38 [Bug bootstrap/48337] New: [4.7 regression] options.c doesn't compile on SPARC ro at gcc dot gnu.org
  2011-03-29 15:08 ` [Bug bootstrap/48337] " joseph at codesourcery dot com
  2011-03-29 15:50 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2011-03-29 16:07 ` ro at gcc dot gnu.org
  2011-03-30 10:42 ` ro at gcc dot gnu.org
  2011-03-30 10:44 ` ro at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2011-03-29 16:07 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48337

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.03.29 15:47:51
         AssignedTo|unassigned at gcc dot       |ro at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.7.0
     Ever Confirmed|0                           |1

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> 2011-03-29 15:47:51 UTC ---
Patch submitted.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/48337] [4.7 regression] options.c doesn't compile on SPARC
  2011-03-29 14:38 [Bug bootstrap/48337] New: [4.7 regression] options.c doesn't compile on SPARC ro at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2011-03-29 16:07 ` ro at gcc dot gnu.org
@ 2011-03-30 10:42 ` ro at gcc dot gnu.org
  2011-03-30 10:44 ` ro at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2011-03-30 10:42 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48337

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> 2011-03-30 10:01:17 UTC ---
Author: ro
Date: Wed Mar 30 10:01:13 2011
New Revision: 171717

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171717
Log:
2011-03-30  Joseph Myers  <joseph@codesourcery.com>
        Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

    PR bootstrap/48337
    * config/sparc/sparc.opt (sparc_cpu_and_features): Add
    Init(PROCESSOR_V7).
    (sparc_cpu): Likewise.
    * config/sparc/sparc.c (sparc_option_override): Replace 0 by
    PROCESSOR_V7.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/sparc/sparc.c
    trunk/gcc/config/sparc/sparc.opt


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/48337] [4.7 regression] options.c doesn't compile on SPARC
  2011-03-29 14:38 [Bug bootstrap/48337] New: [4.7 regression] options.c doesn't compile on SPARC ro at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2011-03-30 10:42 ` ro at gcc dot gnu.org
@ 2011-03-30 10:44 ` ro at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2011-03-30 10:44 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48337

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> 2011-03-30 10:03:46 UTC ---
Fixed for 4.7.0.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-03-30 10:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-29 14:38 [Bug bootstrap/48337] New: [4.7 regression] options.c doesn't compile on SPARC ro at gcc dot gnu.org
2011-03-29 15:08 ` [Bug bootstrap/48337] " joseph at codesourcery dot com
2011-03-29 15:50 ` ro at CeBiTec dot Uni-Bielefeld.DE
2011-03-29 16:07 ` ro at gcc dot gnu.org
2011-03-30 10:42 ` ro at gcc dot gnu.org
2011-03-30 10:44 ` ro at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).