[Bug rtl-optimization/48389] [4.5/4.6/4.7 Regression] ICE: in make_edges, at cfgbuild.c:319 with -mtune=pentiumpro

["law at redhat dot com" <gcc-bugzilla@gcc.gnu.org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48389

--- Comment #6 from Jeffrey A. Law <law at redhat dot com> 2011-04-07 15:04:49 UTC ---
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/06/11 17:00, steven at gcc dot gnu.org wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48389
> 
> --- Comment #5 from Steven Bosscher <steven at gcc dot gnu.org> 2011-04-06 23:00:31 UTC ---
> Created attachment 23905
>   --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23905
> First shot at a fix (also for PR48486)
> 
> Well, one can always hope for a quick fix.
I was looking at your proposed patch -- the first thing that jumps out
is cfgbuild.c has many tests similar to the one you fixed (testing for
eq/ne without masking off irrelevant bits).

I'd hate to see this once instance get fixed and all the others left
behind, but I'm also not familiar enough with the code to say for sure
if the other tests are correct as-written or definitely need to be fixed.

The cfgexpand changes look pretty reasonable.  The extra barrier is odd,
but not terribly surprising given the wacky way we've represented jump
tables in RTL.

It's not clear why you twiddled the code to mask off EDGE_EXECUTABLE,
but it's not terribly important, just a curiosity on my part.

jeff

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNndKIAAoJEBRtltQi2kC7fAgH/3A9Rsa28p2Kkly/eZAf5kBU
aGFO3XbeC/MfarJQM7AdQ33WVFL+bAr2DBUaxXE304WGM0T4S/jwEPOiYbeJ2Bsi
ziXZfa3urRgC10zAVSqAbP8y40NLqC3aO9NL9o+OB6eyjWuDSPTDakOpmWNJOqGg
A3oAg5ONWcJO5CxODIUBaXlJBtV7igGNjrQnSPouKOCC8lR+Ljy8yQK62kMR6pP3
h7hJzhEr09wWpq5rd5rEekZd9xvboPGChvD5QK6BMHtE6HdM2UVJ7Z02X8EgKUJj
J8oCGd4RK6fsRWvO00fAZBeev2ccz5zjKhlry4QiXm9tNHwN8n0Xff2k32jEFgs=
=cObX
-----END PGP SIGNATURE-----