public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "matz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/48389] [4.5/4.6/4.7 Regression] ICE: in make_edges, at cfgbuild.c:319 with -mtune=pentiumpro
Date: Fri, 08 Apr 2011 13:05:00 -0000	[thread overview]
Message-ID: <bug-48389-4-mOphu5MMFx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-48389-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48389

--- Comment #11 from Michael Matz <matz at gcc dot gnu.org> 2011-04-08 13:05:18 UTC ---
I know what's the problem.  Your patch can't work.  commit_one_edge_insertion
relies on edge splitting to work, which relies on being able to patch jump
insns, which relies on correctly set JUMP_LABEL on those insns, hence
rebuild_jump_labels (which in this case doesn't rebuild but really initializes
JUMP_LABEL for the first time) must be called before inserting insns.

So, no it can't even theoretically work, except if we rewrite how
jumps are patched to redirect edges.

I'd propose to change the interface to rebuild_jump_labels somewhat to
only conditionally run over forced_labels.  Then it can be called on the
insn chains that are to be inserted on edges before insertion.


  parent reply	other threads:[~2011-04-08 13:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31 16:11 [Bug rtl-optimization/48389] New: " zsojka at seznam dot cz
2011-04-06  0:26 ` [Bug rtl-optimization/48389] " pinskia at gcc dot gnu.org
2011-04-06 16:53 ` law at redhat dot com
2011-04-06 16:55 ` law at redhat dot com
2011-04-06 20:42 ` steven at gcc dot gnu.org
2011-04-06 21:53 ` steven at gcc dot gnu.org
2011-04-06 22:51 ` law at redhat dot com
2011-04-06 23:00 ` steven at gcc dot gnu.org
2011-04-07 15:05 ` law at redhat dot com
2011-04-07 15:38 ` matz at gcc dot gnu.org
2011-04-07 18:41 ` law at redhat dot com
2011-04-07 21:28 ` stevenb.gcc at gmail dot com
2011-04-08 11:38 ` matz at gcc dot gnu.org
2011-04-08 13:05 ` matz at gcc dot gnu.org [this message]
2011-04-08 20:20 ` matz at gcc dot gnu.org
2011-04-08 20:22 ` [Bug rtl-optimization/48389] [4.5/4.6 " matz at gcc dot gnu.org
2011-04-09 10:09 ` stevenb.gcc at gmail dot com
2011-04-10 10:46 ` rguenth at gcc dot gnu.org
2011-04-28 15:18 ` rguenth at gcc dot gnu.org
2012-07-02 11:30 ` rguenth at gcc dot gnu.org
2013-04-12 16:18 ` [Bug rtl-optimization/48389] [4.6 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-48389-4-mOphu5MMFx@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).