* [Bug testsuite/48402] autogen fixincludes in GCC 4.6.0 testsuite fails on OS X 10.6.7
2011-04-01 18:40 [Bug other/48402] New: autogen fixincludes in GCC 4.6.0 testsuite fails on OS X 10.6.7 source at sharpsteen dot net
@ 2011-08-03 9:43 ` jeru.sheng at gmail dot com
2011-09-28 8:20 ` sambler at nd dot edu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: jeru.sheng at gmail dot com @ 2011-08-03 9:43 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48402
Cheng Sheng <jeru.sheng at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeru.sheng at gmail dot com
--- Comment #1 from Cheng Sheng <jeru.sheng at gmail dot com> 2011-08-03 09:43:08 UTC ---
I encountered this problem as well in gcc-4.6.1, on Mac OS X 10.7. After some
checking, I found that the source of this error is that "sed" in Linux is
slightly different from "sed" in the POSIX spec (see
http://pubs.opengroup.org/onlinepubs/009695399/utilities/sed.html).
In Linux, the c-command of "sed" can be followed by the text directly, while in
the spec, the c-command should be followed immediately by a backslash, then a
newline, then the text. Therefore, one hack instruction in
gcc-4.6.0/fixinclude/inclhack.def doesn't work:
*****************************************
***** Part of "inclhack.def" Begins *****
*****************************************
/*
* Solaris 10+ <complex.h> is wrapped in #ifndef __cplusplus. Wrap in
* extern "C" instead so libstdc++ can use it.
*/
fix = {
hackname = solaris_complex_cxx;
mach = "*-*-solaris2.*";
files = complex.h;
sed = "/#if[ \t]*!defined(__cplusplus)/c"
"#ifdef\t__cplusplus\\\nextern \"C\" {\\\n#endif";
sed = "/#endif[ \t]*\\/\\* !defined(__cplusplus) \\*\\//c"
"#ifdef\t__cplusplus\\\n}\\\n#endif";
test_text = "#if !defined(__cplusplus)\n"
"#endif /* !defined(__cplusplus) */";
};
***************************************
***** Part of "inclhack.def" Ends *****
***************************************
A fix would be to replace the "/c" commands of the two "sed"s to "/c\\\n",
i.e.:
--- inclhack.def.bak 2011-08-03 17:40:44.000000000 +0800
+++ inclhack.def 2011-08-03 17:40:52.000000000 +0800
@@ -3315,9 +3315,9 @@
hackname = solaris_complex_cxx;
mach = "*-*-solaris2.*";
files = complex.h;
- sed = "/#if[ \t]*!defined(__cplusplus)/c"
+ sed = "/#if[ \t]*!defined(__cplusplus)/c\\\n"
"#ifdef\t__cplusplus\\\nextern \"C\" {\\\n#endif";
- sed = "/#endif[ \t]*\\/\\* !defined(__cplusplus) \\*\\//c"
+ sed = "/#endif[ \t]*\\/\\* !defined(__cplusplus) \\*\\//c\\\n"
"#ifdef\t__cplusplus\\\n}\\\n#endif";
test_text = "#if !defined(__cplusplus)\n"
"#endif /* !defined(__cplusplus) */";
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug testsuite/48402] autogen fixincludes in GCC 4.6.0 testsuite fails on OS X 10.6.7
2011-04-01 18:40 [Bug other/48402] New: autogen fixincludes in GCC 4.6.0 testsuite fails on OS X 10.6.7 source at sharpsteen dot net
2011-08-03 9:43 ` [Bug testsuite/48402] " jeru.sheng at gmail dot com
@ 2011-09-28 8:20 ` sambler at nd dot edu
2011-09-29 6:15 ` sambler at nd dot edu
2013-12-19 16:46 ` dominiq at lps dot ens.fr
3 siblings, 0 replies; 5+ messages in thread
From: sambler at nd dot edu @ 2011-09-28 8:20 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48402
Stuart Ambler <sambler at nd dot edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sambler at nd dot edu
--- Comment #2 from Stuart Ambler <sambler at nd dot edu> 2011-09-28 06:29:36 UTC ---
Same error encountered (configure, make, make install work, but make check
fails in the same way). Tried proposed fix but apparently didn't guess
correctly the exact sequence of actions to make it work.
OS: OS X 10.6.8
Autogen: 5.12
compiler used to build GCC 4.6.1 was Apple 4.2.1 which responds to -v with
Using built-in specs.
Target: i686-apple-darwin10
Configured with: /var/tmp/gcc/gcc-5666.3~6/src/configure --disable-checking
--enable-werror --prefix=/usr --mandir=/usr/share/man
--enable-languages=c,objc,c++,obj-c++
--program-transform-name=/^[cg][^.-]*$/s/$/-4.2/ --with-slibdir=/usr/lib
--build=i686-apple-darwin10 --with-gxx-include-dir=/usr/include/c++/4.2.1
--host=i686-apple-darwin10 --target=i686-apple-darwin10
Thread model: posix
gcc version 4.2.1 (Apple Inc. build 5666) (dot 3)
GCC 4.6.1 configured with ../gcc-4.6.1/configure --with-pkgversion=osx10.6.8
--prefix=/usr/local/unix --with-gmp=/usr/local/unix --with-mpfr=/usr/local/unix
--with-mpc=/usr/local/unix --disable-multilib
After build and install, it responds to -v with
Using built-in specs.
COLLECT_GCC=/usr/local/unix/bin/gcc
COLLECT_LTO_WRAPPER=/usr/local/unix/libexec/gcc/i386-apple-darwin10.8.0/4.6.1/lto-wrapper
Target: i386-apple-darwin10.8.0
Configured with: ../gcc-4.6.1/configure --with-pkgversion=osx10.6.8
--prefix=/usr/local/unix --with-gmp=/usr/local/unix --with-mpfr=/usr/local/unix
--with-mpc=/usr/local/unix --disable-multilib
Thread model: posix
gcc version 4.6.1 (osx10.6.8)
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug testsuite/48402] autogen fixincludes in GCC 4.6.0 testsuite fails on OS X 10.6.7
2011-04-01 18:40 [Bug other/48402] New: autogen fixincludes in GCC 4.6.0 testsuite fails on OS X 10.6.7 source at sharpsteen dot net
2011-08-03 9:43 ` [Bug testsuite/48402] " jeru.sheng at gmail dot com
2011-09-28 8:20 ` sambler at nd dot edu
@ 2011-09-29 6:15 ` sambler at nd dot edu
2013-12-19 16:46 ` dominiq at lps dot ens.fr
3 siblings, 0 replies; 5+ messages in thread
From: sambler at nd dot edu @ 2011-09-29 6:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48402
--- Comment #3 from Stuart Ambler <sambler at nd dot edu> 2011-09-29 05:02:34 UTC ---
Verified fix as follows. After fresh de-tar of gcc-core, g++, objc,
testsuite-4.6.1.tar.g, edit gcc-4.6.1/fixincludes/inclhack.def according to
Cheng Sheng's comment, also edit same directory genfixes to make its autogen
version check work:
$ diff genfixes.orig genfixes
'65c65
< if [ -z "`${AG} -v | fgrep 'Ver. 5.'`" ]
---
> if [ -z "`${AG} -v | fgrep '(GNU AutoGen) 5.'`" ]
run ./genfixes, cd to separate build directory, configure, make, sudo make
install, sudo make check - all worked correctly (except that make check
reported one unexpected failure, FAIL: gcc.dg/ipa/pr48195.c (test for excess
errors), which I have no reason to think is related to this bug).
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug testsuite/48402] autogen fixincludes in GCC 4.6.0 testsuite fails on OS X 10.6.7
2011-04-01 18:40 [Bug other/48402] New: autogen fixincludes in GCC 4.6.0 testsuite fails on OS X 10.6.7 source at sharpsteen dot net
` (2 preceding siblings ...)
2011-09-29 6:15 ` sambler at nd dot edu
@ 2013-12-19 16:46 ` dominiq at lps dot ens.fr
3 siblings, 0 replies; 5+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-12-19 16:46 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48402
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Per the more than two years old comment 3, closing as FIXED.
^ permalink raw reply [flat|nested] 5+ messages in thread