[Bug go/48407] New: libgo/configure --without-libffi doesn't work

[Bug go/48407] New: libgo/configure --without-libffi doesn't work

[corsepiu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48407

           Summary: libgo/configure --without-libffi doesn't work
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
        AssignedTo: ian@airs.com
        ReportedBy: corsepiu@gcc.gnu.org


libgo/configure.ac supplies --without-libffi

However,
libgo/runtime/go-reflect-call.c
unconditionally includes "ffi.h".

I.e. this option doen't do what
libgo/configure --help
...
  --without-libffi        don't use libffi
...
suggests.

[Bug go/48407] libgo/configure --without-libffi doesn't work

[dirtyepic at gentoo dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48407

Ryan Hill <dirtyepic at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dirtyepic at gentoo dot org

--- Comment #1 from Ryan Hill <dirtyepic at gentoo dot org> 2011-04-03 07:44:52 UTC ---
http://gcc.gnu.org/ml/gcc-patches/2010-11/msg02084.html

[Bug go/48407] libgo/configure --without-libffi doesn't work

[joel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48407

Joel Sherrill <joel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian at airs dot com, joel
                   |                            |at gcc dot gnu.org

--- Comment #2 from Joel Sherrill <joel at gcc dot gnu.org> 2011-04-03 20:18:00 UTC ---
This patch is in my local svn tree.  Ian 

Index: configure.ac
===================================================================
--- configure.ac    (revision 170678)
+++ configure.ac    (working copy)
@@ -618,7 +618,8 @@
     ;;
   *-*-rtems*)
     skipdirs="${skipdirs} target-libiberty"
-    noconfigdirs="$noconfigdirs target-libgloss ${libgcj}"
+    # noconfigdirs="$noconfigdirs target-libgloss ${libgcj}"
+    noconfigdirs="$noconfigdirs target-libgloss"
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

[Bug go/48407] libgo/configure --without-libffi doesn't work

[joel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48407

--- Comment #3 from Joel Sherrill <joel at gcc dot gnu.org> 2011-04-03 20:25:18 UTC ---
Sorry.. it was submitted before I was finished...

I have this in my local tree.  I recall Ian and I discussing that since
Go and GCJ both need libffi, the logic should be smarter.  But this works.

I submitted patches to libffi for m68k and mips.  I recall Go built and worked
on at least i386, sparc, mips, powerpc, and arm.   So libffi is OK to enable. 
If libffi doesn't support a particular architecture, then Go and GCJ are not
available on that architecture.

Index: configure.ac
===================================================================
--- configure.ac    (revision 170678)
+++ configure.ac    (working copy)
@@ -618,7 +618,8 @@
     ;;
   *-*-rtems*)
     skipdirs="${skipdirs} target-libiberty"
-    noconfigdirs="$noconfigdirs target-libgloss ${libgcj}"
+    # noconfigdirs="$noconfigdirs target-libgloss ${libgcj}"
+    noconfigdirs="$noconfigdirs target-libgloss"
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

[Bug go/48407] libgo/configure --without-libffi doesn't work

[corsepiu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48407

--- Comment #4 from Ralf Corsepius <corsepiu at gcc dot gnu.org> 2011-04-04 11:40:59 UTC ---
(In reply to comment #3)

> I have this in my local tree.  I recall Ian and I discussing that since
> Go and GCJ both need libffi, the logic should be smarter.

Joel, as you may have gueess, I also have a similar patch as the one you posted
here applied, because otherwise "nothing builds", however this is a different
issue.


So, let me try to refine my issues:

* libgo/configure's --without-libffi, suggests GCC (rsp. libgo) could be built
without libffi. This apparently does not apply. libgo (currently) strictly
requires libffi.

In other words, "--without-libffi" doesn't do what a user who is not deeply
intimate with libgo, may think it does. libgo/configure's --without-libffi
actually is closer to "--with/without-external-libffi" than to
"--with/without-libffi".

That said, may-be renaming it could be considered.

* GCC's toplevel configure doesn't honor --with/without-libffi (neither in the
sense of external-ffi nor in the sense of not using libffi).

[Bug go/48407] libgo/configure --without-libffi doesn't work

[ian at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48407

--- Comment #5 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> 2012-02-14 20:47:42 UTC ---
Author: ian
Date: Tue Feb 14 20:47:35 2012
New Revision: 184234

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184234
Log:
    PR go/48407
runtime: Permit building libgo without libffi.

Modified:
    trunk/libgo/runtime/go-reflect-call.c

[Bug go/48407] libgo/configure --without-libffi doesn't work

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48407

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Ian Lance Taylor <ian at airs dot com> 2012-02-14 20:48:52 UTC ---
Fixed, in the sense that you can now build a somewhat broken libgo if you don't
have libffi.

http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00763.html