[Bug c++/48420] New: Missed -Wconversion-null warning when passing const bool to T*

[Bug c++/48420] New: Missed -Wconversion-null warning when passing const bool to T*

[jyasskin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48420

           Summary: Missed -Wconversion-null warning when passing const
                    bool to T*
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jyasskin@gcc.gnu.org


$ g++-mp-4.6 -Wconversion-null -c test.cc
dhcp-172-19-248-71:~/tmp$ cat test.cc
void foo(int* p);

void bar() {
    const bool kDebugMode = false;  // NULL pointer constant.
    foo(kDebugMode);  // But no warning!
}
$ g++-mp-4.6 -Wconversion-null -c test.cc
$ 

Changing the kDebugMode to 'false' or a false expression involving an enum
triggers the warning.

[Bug c++/48420] Missed -Wconversion-null warning when passing const bool to T*

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48420

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-09-28
     Ever Confirmed|0                           |1

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-09-28 20:03:34 UTC ---
Interestingly, in C++0x mode it works, obviously thanks to the work on
constexpr. Do you really want it for C++98 too? ;)

[Bug c++/48420] Missed -Wconversion-null warning when passing const bool to T*

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48420

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-09-28 20:05:32 UTC ---
Oops, sorry, got confused, in C++0x it's an hard error. Uhmmm.

[Bug c++/48420] Missed -Wconversion-null warning when passing const bool to T*

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48420

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-03 01:19:36 UTC ---
On it.

[Bug c++/48420] Missed -Wconversion-null warning when passing const bool to T*

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48420

--- Comment #4 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-11-04 16:31:23 UTC ---
Author: paolo
Date: Fri Nov  4 16:31:18 2011
New Revision: 180963

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=180963
Log:
/cp
2011-11-04  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/48420
    * call.c (conversion_null_warnings): For 'false' to NULL pointer,
    just check that TREE_TYPE (expr) is a BOOLEAN_TYPE.

/testsuite
2011-11-04  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/48420
    * g++.dg/warn/Wconversion-null-3.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/warn/Wconversion-null-3.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/call.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/48420] Missed -Wconversion-null warning when passing const bool to T*

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48420

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-04 16:32:51 UTC ---
Fixed for 4.7.0.

[Bug c++/48420] Missed -Wconversion-null warning when passing const bool to T*

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48420

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tutufan at gmail dot com

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-12-13 19:59:38 UTC ---
*** Bug 51531 has been marked as a duplicate of this bug. ***

[Bug c++/48420] Missed -Wconversion-null warning when passing const bool to T*

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48420

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hub at figuiere dot net

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-05-03 01:35:04 UTC ---
*** Bug 53207 has been marked as a duplicate of this bug. ***