[Bug bootstrap/48471] New: ia64-*-* does not bootstrap due to unused variables in dbxout.c

[Bug bootstrap/48471] New: ia64-*-* does not bootstrap due to unused variables in dbxout.c

[sje at cup dot hp.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48471

           Summary: ia64-*-* does not bootstrap due to unused variables in
                    dbxout.c
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: sje@cup.hp.com


I get these errors when bootstrapping on ia64-hp-hpux11.23.

/proj/opensrc_nobackup/sje/reg/src/trunk/gcc/dbxout.c:107:12: error:
'debug_nesting' defined but not used [-Werror=unused-variable]
/proj/opensrc_nobackup/sje/reg/src/trunk/gcc/dbxout.c:109:14: error:
'symbol_queue' defined but not used [-Werror=unused-variable]
/proj/opensrc_nobackup/sje/reg/src/trunk/gcc/dbxout.c:110:12: error:
'symbol_queue_index' defined but not used [-Werror=unused-variable]
/proj/opensrc_nobackup/sje/reg/src/trunk/gcc/dbxout.c:111:12: error:
'symbol_queue_size' defined but not used [-Werror=unused-variable]
cc1: all warnings being treated as errors

I believe they were caused by this checkin:

------------------------------------------------------------------------
r171981 | froydnj | 2011-04-05 05:02:55 -0700 (Tue, 05 Apr 2011) | 8 lines

        * debug.h (debug_flush_symbol_queue, debug_queue_symbol): Delete.
        (debug_free_queue, debug_nesting, symbol_queue_index): Delete.
        * final.c (debug_flush_symbol_queue, debug_queue_symbol):
        Move these...
        (debug_free_queue, debug_nesting, symbol_queue_index):
        ...and these...
        * dbxout.c: ...to here.  Make static.

[Bug bootstrap/48471] ia64-*-* does not bootstrap due to unused variables in dbxout.c

[sje at cup dot hp.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48471

--- Comment #1 from Steve Ellcey <sje at cup dot hp.com> 2011-04-05 20:44:32 UTC ---
FYI: I could not find a changelog entry for the r171981 change to dbxout.c.

[Bug bootstrap/48471] ia64-*-* does not bootstrap due to unused variables in dbxout.c

[froydnj at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48471

--- Comment #2 from Nathan Froyd <froydnj at gcc dot gnu.org> 2011-04-05 20:45:20 UTC ---
Created attachment 23888
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23888
untested patch

[Bug bootstrap/48471] ia64-*-* does not bootstrap due to unused variables in dbxout.c

[froydnj at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48471

Nathan Froyd <froydnj at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |froydnj at gcc dot gnu.org

--- Comment #3 from Nathan Froyd <froydnj at gcc dot gnu.org> 2011-04-05 20:45:38 UTC ---
Does the attached patch solve things?

[Bug bootstrap/48471] ia64-*-* does not bootstrap due to unused variables in dbxout.c

[sje at cup dot hp.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48471

--- Comment #4 from Steve Ellcey <sje at cup dot hp.com> 2011-04-05 21:20:09 UTC ---
The patch looks good.  I haven't finished my bootstrap but I am in stage2 and
dbxout.c compiled correctly.

[Bug bootstrap/48471] ia64-*-* does not bootstrap due to unused variables in dbxout.c

[sje at cup dot hp.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48471

--- Comment #5 from Steve Ellcey <sje at cup dot hp.com> 2011-04-05 23:12:25 UTC ---
Bootstrap finished, everything looked good.

[Bug bootstrap/48471] [4.7 Regression] ia64-*-* does not bootstrap due to unused variables in dbxout.c

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48471

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
   Target Milestone|---                         |4.7.0
            Summary|ia64-*-* does not bootstrap |[4.7 Regression] ia64-*-*
                   |due to unused variables in  |does not bootstrap due to
                   |dbxout.c                    |unused variables in
                   |                            |dbxout.c

[Bug bootstrap/48471] [4.7 Regression] ia64-*-* does not bootstrap due to unused variables in dbxout.c

[froydnj at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48471

--- Comment #6 from Nathan Froyd <froydnj at gcc dot gnu.org> 2011-04-06 01:06:44 UTC ---
Author: froydnj
Date: Wed Apr  6 01:06:42 2011
New Revision: 172016

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=172016
Log:
    PR bootstrap/48471
    * dbxout.c (debug_nesting, symbol_queue, symbol_queue_index):
    Move these...
    (symbol_queue_size, DBXOUT_DECR_NESTING): ...and these...
    (DBXOUT_DECR_NESTING_AND_RETURN): ...and this under
    #ifdef DBX_DEBUGGING_INFO.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dbxout.c

[Bug bootstrap/48471] [4.7 Regression] ia64-*-* does not bootstrap due to unused variables in dbxout.c

[froydnj at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48471

Nathan Froyd <froydnj at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Nathan Froyd <froydnj at gcc dot gnu.org> 2011-04-06 01:07:14 UTC ---
Fixed on trunk.