public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "schaub.johannes at googlemail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/48562] [C++0x] warn about uses of initializer_list that will lead to dangling pointers
Date: Sun, 25 Sep 2011 14:53:00 -0000	[thread overview]
Message-ID: <bug-48562-4-j9YastzeIm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-48562-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48562

--- Comment #6 from Johannes Schaub <schaub.johannes at googlemail dot com> 2011-09-25 14:22:33 UTC ---
(In reply to comment #5)
> Johannes, sorry about the dumb question: now I understand the issue decently
> well - and after all boils down to adding a warning - but I'm not sure to
> understand your code snippet: is it meant to crash at runtime? Trigger valgrind
> errors?

In the C++11 spec, it is said that the lifetime of the backing-up array is the
same as the lifetime of the initializer_list object which was initialized by
the array (not considering the DRs and their resolution that Jason has pointed
to). My code was just meant to test whether GCC obeys those rules.

struct X {
  X(int) { cout << "+"; }
  X(X const&) { cout << "+"; }
  ~X() { cout << "-"; }
};

auto *p = new initalizer_list<X>{1, 2, 3}; // ... not at this
delete p; // C++11 requires "now" at this point ...

(again not considering those DRs that revise these rules). 

I think that a warning against "({...})" would be useful too

    // fine
    initializer_list<int> a{1, 2, 3};

    // this is bad
    initializer_list<int> b({1, 2, 3});

Second one is bad because it will destroy the array after initializing 'b', and
won't lengthen the lifetime (because it will use the copy/move constructor).


  parent reply	other threads:[~2011-09-25 14:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-11 21:45 [Bug c++/48562] New: Prematurely destroys initializer_list array when using new-expression schaub.johannes at googlemail dot com
2011-04-19  9:20 ` [Bug c++/48562] " amonakov at gcc dot gnu.org
2011-09-23 22:09 ` [Bug c++/48562] [C++0x] " paolo.carlini at oracle dot com
2011-09-23 22:25 ` [Bug c++/48562] [C++0x] warn about uses of initializer_list that will lead to dangling pointers jason at gcc dot gnu.org
2011-09-23 22:26 ` paolo.carlini at oracle dot com
2011-09-23 22:35 ` paolo.carlini at oracle dot com
2011-09-25 11:08 ` paolo.carlini at oracle dot com
2011-09-25 14:53 ` schaub.johannes at googlemail dot com [this message]
2011-09-25 14:58 ` paolo.carlini at oracle dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-48562-4-j9YastzeIm@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).