public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/48600] [4.6/4.7 Regression] ICE when using cold attribute
Date: Tue, 31 Jan 2012 15:07:00 -0000	[thread overview]
Message-ID: <bug-48600-4-p3R9eksXE6@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-48600-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48600

--- Comment #15 from Jan Hubicka <hubicka at gcc dot gnu.org> 2012-01-31 14:31:56 UTC ---
I am testing the attached patch 
Index: predict.c
===================================================================
--- predict.c   (revision 183666)
+++ predict.c   (working copy)
@@ -1833,6 +1833,10 @@ predict_paths_for_bb (basic_block cur, b
   edge_iterator ei;
   basic_block son;

+  /* AUX is used to detect cycles while walking predictors with only EH/FAKE
+     succestors.  */
+  cur->aux = (void *)(size_t) 1;
+
   /* We are looking for all edges forming edge cut induced by
      set of all blocks postdominated by BB.  */
   FOR_EACH_EDGE (e, ei, cur->preds)
@@ -1848,7 +1852,7 @@ predict_paths_for_bb (basic_block cur, b
        continue;
       gcc_assert (bb == cur || dominated_by_p (CDI_POST_DOMINATORS, cur, bb));

-      /* See if there is how many edge from e->src that is not abnormal
+      /* See if there is an edge from e->src that is not abnormal
         and does not lead to BB.  */
       FOR_EACH_EDGE (e2, ei2, e->src->succs)
        if (e2 != e
@@ -1864,13 +1868,14 @@ predict_paths_for_bb (basic_block cur, b
         leading to e->src.  */
       if (found)
         predict_edge_def (e, pred, taken);
-      else
+      else if (!e->src->aux)
        predict_paths_for_bb (e->src, e->src, pred, taken);
     }
   for (son = first_dom_son (CDI_POST_DOMINATORS, cur);
        son;
        son = next_dom_son (CDI_POST_DOMINATORS, son))
     predict_paths_for_bb (son, bb, pred, taken);
+  cur->aux = (void *)(size_t) NULL;
 }

 /* Sets branch probabilities according to PREDiction and


  parent reply	other threads:[~2012-01-31 14:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-14  2:36 [Bug middle-end/48600] New: [4.6 regression] " matt at use dot net
2011-04-14  9:23 ` [Bug middle-end/48600] " rguenth at gcc dot gnu.org
2011-04-14 17:00 ` matt at use dot net
2011-04-15 18:30 ` matt at use dot net
2011-04-18 11:23 ` jakub at gcc dot gnu.org
2011-04-26 21:10 ` [Bug middle-end/48600] [4.6/4.7 Regression] " jsm28 at gcc dot gnu.org
2011-06-01 14:36 ` matt at use dot net
2011-06-27 16:19 ` jakub at gcc dot gnu.org
2011-08-18  6:08 ` jakub at gcc dot gnu.org
2011-08-18  9:12 ` rguenth at gcc dot gnu.org
2011-08-19 22:18 ` hubicka at gcc dot gnu.org
2011-10-26 17:25 ` jakub at gcc dot gnu.org
2011-12-09  9:14 ` rguenth at gcc dot gnu.org
2011-12-09  9:18 ` rguenth at gcc dot gnu.org
2012-01-24 10:20 ` jakub at gcc dot gnu.org
2012-01-31 14:55 ` hubicka at gcc dot gnu.org
2012-01-31 15:07 ` hubicka at gcc dot gnu.org [this message]
2012-02-10 12:22 ` hubicka at gcc dot gnu.org
2012-02-10 12:23 ` [Bug middle-end/48600] [4.7 " hubicka at gcc dot gnu.org
2012-03-01 14:55 ` [Bug middle-end/48600] [4.6 " jakub at gcc dot gnu.org
2012-03-23 10:52 ` hubicka at gcc dot gnu.org
2012-03-23 14:36 ` hubicka at gcc dot gnu.org
2012-03-23 14:53 ` hubicka at gcc dot gnu.org
2012-06-11  9:11 ` jye2 at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-48600-4-p3R9eksXE6@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).