[Bug libstdc++/48631] New: [C++0x] default_delete<T[]> accepts pointer conversions in function call operator

[Bug libstdc++/48631] New: [C++0x] default_delete<T[]> accepts pointer conversions in function call operator

[daniel.kruegler at googlemail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48631

           Summary: [C++0x] default_delete<T[]> accepts pointer
                    conversions in function call operator
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: daniel.kruegler@googlemail.com


The following program using 4.7.0 20110409 (experimental) should be rejected,
but is accepted:

//------------
#include <memory>

struct B {};
struct D : B {};

int main() {
  D d;
  std::default_delete<B[]> db;
  typedef decltype(db(&d)) type;
}
//------------

Reason for this deviation of the spec is the missing deleted function call
operator as described in [unique.ptr.dltr.dflt1]:

template <class T> struct default_delete<T[]> {
  constexpr default_delete() noexcept = default;
  void operator()(T*) const;
  template <class U> void operator()(U*) const = delete;
};

[Bug libstdc++/48631] [C++0x] default_delete<T[]> accepts pointer conversions in function call operator

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48631

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.04.16 01:19:45
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com
   Target Milestone|---                         |4.6.1
     Ever Confirmed|0                           |1

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-04-16 01:19:45 UTC ---
I'm handling this one too.

[Bug libstdc++/48631] [C++0x] default_delete<T[]> accepts pointer conversions in function call operator

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48631

--- Comment #2 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-04-16 02:02:35 UTC ---
Author: paolo
Date: Sat Apr 16 02:02:29 2011
New Revision: 172534

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=172534
Log:
2011-04-15  Daniel Krugler  <daniel.kruegler@googlemail.com>
        Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/48631
    * include/bits/unique_ptr.h (default_delete<_Tp[]>): Add deleted
    function call operator.
    * testsuite/20_util/default_delete/48631_neg.cc: New.
    * testsuite/20_util/weak_ptr/comparison/cmp_neg.cc: Adjust dg-error
    line numbers.

Added:
    trunk/libstdc++-v3/testsuite/20_util/default_delete/48631_neg.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/unique_ptr.h
    trunk/libstdc++-v3/testsuite/20_util/weak_ptr/comparison/cmp_neg.cc

[Bug libstdc++/48631] [C++0x] default_delete<T[]> accepts pointer conversions in function call operator

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48631

--- Comment #3 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-04-16 02:05:01 UTC ---
Author: paolo
Date: Sat Apr 16 02:04:56 2011
New Revision: 172535

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=172535
Log:
2011-04-15  Daniel Krugler  <daniel.kruegler@googlemail.com>
        Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/48631
    * include/bits/unique_ptr.h (default_delete<_Tp[]>): Add deleted
    function call operator.
    * testsuite/20_util/default_delete/48631_neg.cc: New.
    * testsuite/20_util/weak_ptr/comparison/cmp_neg.cc: Adjust dg-error
    line numbers.

Added:
   
branches/gcc-4_6-branch/libstdc++-v3/testsuite/20_util/default_delete/48631_neg.cc
Modified:
    branches/gcc-4_6-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_6-branch/libstdc++-v3/include/bits/unique_ptr.h
   
branches/gcc-4_6-branch/libstdc++-v3/testsuite/20_util/weak_ptr/comparison/cmp_neg.cc

[Bug libstdc++/48631] [C++0x] default_delete<T[]> accepts pointer conversions in function call operator

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48631

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-04-16 02:05:43 UTC ---
Done. Fixed mainline and 4_6-branch.

[Bug libstdc++/48631] [C++0x] default_delete<T[]> accepts pointer conversions in function call operator

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48631

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-04-16 02:09:46 UTC ---
Jason, in case the issue is not known and your are interested: after the
library fix we reject the snippet but we give the error message twice.