From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-353885-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 23918 invoked by alias); 17 Apr 2011 20:12:45 -0000
Received: (qmail 23903 invoked by uid 22791); 17 Apr 2011 20:12:44 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 17 Apr 2011 20:12:30 +0000
From: "daniel.kruegler at googlemail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/48635] [C++0x] unique_ptr<T, D&> moves the deleter instead of copying it
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: daniel.kruegler at googlemail dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: paolo.carlini at oracle dot com
X-Bugzilla-Target-Milestone: 4.6.1
X-Bugzilla-Changed-Fields:
Message-ID: <bug-48635-4-NuoyznILLb@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-48635-4@http.gcc.gnu.org/bugzilla/>
References: <bug-48635-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Date: Sun, 17 Apr 2011 20:12:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2011-04/txt/msg01789.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D48635

--- Comment #8 from Daniel Kr=C3=BCgler <daniel.kruegler at googlemail dot =
com> 2011-04-17 20:12:09 UTC ---
(In reply to comment #7)
> Ok... Do we have testcases for that?

I have two test cases for the *assignment* situation, I invented them out o=
f my
head and I hope the code below does not too many typos and thinkos:

1) This program should be well-formed according to FDIS wording, but ill-fo=
rmed
according to the intended wording:

#include <memory>
#include <utility>

struct D;

struct B {
 B& operator=3D(D&) =3D delete;
 template<class T>
   void operator()(T*) const {}
};

struct D : B {};

int main()
{
 B b;
 D d;
 std::unique_ptr<void, B&> ub(nullptr, b);
 std::unique_ptr<void, D&> ud(nullptr, d);
 ub =3D std::move(ud); // Should be rejected
}

2) The same scenario here:

struct D2;

struct B2 {
 B2& operator=3D(D2&) =3D delete;
 template<class T>
   void operator()(T*) const {}
};

struct D2 {
 B2 b;
 operator B2&() { return b; }
 template<class T>
   void operator()(T*) const {}
};

int main()
{
 B2 b;
 D2 d;
 std::unique_ptr<void, B2&> ub(nullptr, b);
 std::unique_ptr<void, D2&> ud(nullptr, d);
 ub =3D std::move(ud); // Should be rejected
}

> By the way, I noticed that in the templated *constructor* we have been us=
ing D
> instead of E in the forward, and that doesn't seem correct vs the FDIS it=
self.
> What do you think? The below regtests fine:

I agree that the suggested fixes are necessary and they look correct to me.