public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "daniel.kruegler at googlemail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/48635] New: [C++0x] unique_ptr<T, D&> moves the deleter instead of copying it Date: Fri, 15 Apr 2011 21:01:00 -0000 [thread overview] Message-ID: <bug-48635-4@http.gcc.gnu.org/bugzilla/> (raw) http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48635 Summary: [C++0x] unique_ptr<T, D&> moves the deleter instead of copying it Product: gcc Version: 4.7.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: libstdc++ AssignedTo: unassigned@gcc.gnu.org ReportedBy: daniel.kruegler@googlemail.com The following program using 4.7.0 20110409 (experimental) should print "copy", but it prints "move" instead: //------------- #include <memory> #include <utility> #include <iostream> struct Deleter { Deleter() = default; Deleter(const Deleter&) = default; Deleter(Deleter&&) = default; Deleter& operator=(const Deleter&) { std::cout << "copy" << std::endl; return *this; } Deleter& operator=(Deleter&&) { std::cout << "move" << std::endl; return *this; } template<class T> void operator()(T* p) const { delete p; } }; int main() { Deleter d1, d2; std::unique_ptr<int, Deleter&> p1(new int, d1), p2(nullptr, d2); p2 = std::move(p1); } //------------- The reason for the failure is, that the library implementation of the move-assignment operator of std::unique_ptr (and of it's templated variant) uses std::move to transfer the deleter from the source to the target, but as of [unique.ptr.single.asgn] p. 2 and p. 6 it shall use std::forward instead. Doing it correctly will ensure that the deleter is copied and not moved in this case, which is an intended design aim of std::unique_ptr with deleters that are lvalue-references. The necessary fix is to replace the usage of std::move at the two places by std::forward<deleter_type>.
next reply other threads:[~2011-04-15 21:01 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-04-15 21:01 daniel.kruegler at googlemail dot com [this message] 2011-04-15 21:46 ` [Bug libstdc++/48635] " daniel.kruegler at googlemail dot com 2011-04-16 0:25 ` paolo.carlini at oracle dot com 2011-04-16 0:58 ` paolo at gcc dot gnu.org 2011-04-16 1:01 ` paolo.carlini at oracle dot com 2011-04-16 1:01 ` paolo at gcc dot gnu.org 2011-04-17 19:18 ` daniel.kruegler at googlemail dot com 2011-04-17 19:45 ` paolo.carlini at oracle dot com 2011-04-17 20:12 ` daniel.kruegler at googlemail dot com 2011-04-17 21:46 ` paolo at gcc dot gnu.org 2011-04-17 21:47 ` paolo at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-48635-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).