[Bug c++/48660] New: ARM ICE in expand_expr_real_1

[Bug c++/48660] New: ARM ICE in expand_expr_real_1

[jani at ubuntu dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

           Summary: ARM ICE in expand_expr_real_1
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jani@ubuntu.com


Originally reported here
https://bugs.launchpad.net/ubuntu/+source/shibboleth-sp2/+bug/736661

Occurs with 4.5.2 and 4.6.0

/bin/bash ../libtool --silent --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I.
-I.. -pthread -g -O2 -g -Wall -O2 -O2 -DNDEBUG -pthread -Wall -g -O2 -DNDEBUG
-c -o XMLServiceProvider.lo `test -f 'impl/XMLServiceProvider.cpp' || echo
'./'`impl/XMLServiceProvider.cpp
impl/XMLServiceProvider.cpp: In member function 'std::pair<bool,
bool><unnamed>::XMLConfig::_ZTv0_n24_NK12_GLOBAL__N_19XMLConfig7getBoolEPKcS2_(const
char*, const char*) const':
impl/XMLServiceProvider.cpp:311:25: internal compiler error: in
expand_expr_real_1, at expr.c:8454

Link to preprocessed source

https://bugs.launchpad.net/ubuntu/+source/shibboleth-sp2/+bug/736661/+attachment/1916995/+files/XMLServiceProvider.ii

[Bug c++/48660] ARM ICE in expand_expr_real_1

[ramana at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.05.06 16:12:46
     Ever Confirmed|0                           |1

[Bug c++/48660] ARM ICE in expand_expr_real_1

[michael.hope at linaro dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

Michael Hope <michael.hope at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hope at linaro dot
                   |                            |org

--- Comment #1 from Michael Hope <michael.hope at linaro dot org> 2011-06-09 02:51:33 UTC ---
Occurs in trunk r174795, 4.6.0, and 4.5.3.

[Bug c++/48660] ARM ICE in expand_expr_real_1

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

Mikael Pettersson <mikpe at it dot uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org,
                   |                            |mikpe at it dot uu.se

--- Comment #2 from Mikael Pettersson <mikpe at it dot uu.se> 2011-06-09 22:03:23 UTC ---
It's caused or triggered by r154736:

Author: hubicka
Date: Sun Nov 29 10:32:08 2009
New Revision: 154736

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154736
Log:

    * cgraph.c (same_body_alias_1): Break out of
    (same_body_alias): ... here; remove comdat check; it is handled
    in cp already.
    (cgraph_add_thunk): New.
    (dump_cgraph_node): Dump aliases and thunks.
    * cgraph.h (cgraph_thunk_info): New structure.
    (struct cgraph_node): Add thunk info.
    (cgraph_add_thunk): New.
        ...

One strange thing about that commit is that it added calls to record_loop_exits
in ira.c, but the ChangeLog entry doesn't mention ira.c, and nothing else in
the commit seems related to loops or ira.  A local hack that got accidentally
committed?

[Bug c++/48660] ARM ICE in expand_expr_real_1

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

--- Comment #3 from Mikael Pettersson <mikpe at it dot uu.se> 2011-06-10 10:04:52 UTC ---
Created attachment 24484
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24484
reduced test case

With the massively reduced test case and r154736 built as a cross to
armv5tel-linux-gnueabi, I get:

> /tmp/objdir/gcc/g++ -B/tmp/objdir/gcc -O1 -S XMLServiceProvider.cc
XMLServiceProvider.cc: In member function 'virtual thunk to
XMLConfig::getBool() const':
XMLServiceProvider.cc:24:19: internal compiler error: in expand_expr_real_1, at
expr.c:8510

[Bug c++/48660] ARM ICE in expand_expr_real_1

[m.k.edwards at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

Michael K. Edwards <m.k.edwards at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.k.edwards at gmail dot
                   |                            |com

--- Comment #4 from Michael K. Edwards <m.k.edwards at gmail dot com> 2011-07-11 20:31:28 UTC ---
The problem seems to be that promote_decl_mode() is changing the value returned
from the pair constructor from HImode to BLKmode:

(gdb) p debug_tree(decl)
 <result_decl 0x2aaaab61ea80 D.2836
    type <record_type 0x2aaaab5d9930 pair no-force-blk type_5 type_6 BLK
        size <integer_cst 0x2aaaaaaf05f0 constant 16>
        unit size <integer_cst 0x2aaaaaaf0618 constant 2>
        align 8 symtab 0 alias set -1 canonical type 0x2aaaab5d9930
        fields <field_decl 0x2aaaab5f1d10 first type <boolean_type
0x2aaaaab08888 bool>
            unsigned nonlocal decl_3 QI file PR48660.cpp line 6 col 7
            size <integer_cst 0x2aaaaaaf04b0 constant 8>
            unit size <integer_cst 0x2aaaaaaf04d8 constant 1>
            align 8 offset_align 64
            offset <integer_cst 0x2aaaaaaf0410 constant 0>
            bit offset <integer_cst 0x2aaaaaaf0e38 constant 0> context
<record_type 0x2aaaab5d9930 pair> chain <field_decl 0x2aaaab5f1da8 second>>
context <translation_unit_decl 0x2aaaaaafb508 D.1>
        full-name "struct pair<bool, bool>"
        X() X(constX&) this=(X&) n_parents=0 use_template=1 interface-unknown
        pointer_to_this <pointer_type 0x2aaaab603150> chain <type_decl
0x2aaaab5ce958 pair>>
    used ignored regdecl BLK file PR48660.cpp line 31 col 1 size <integer_cst
0x2aaaaaaf05f0 16> unit size <integer_cst 0x2aaaaaaf0618 2>
    align 8
    (reg:HI 140 [ <retval> ])>

This is in turn happening because DECL_MODE (decl) == BLKmode, while in the
caller, GET_MODE (decl_rtl) == HImode.  It's not clear to me whether the rtx
expression should have been in BLKmode in the first place, or whether
expand_expr_real_1() should tolerate the conversion.  The context in
expand_expr_real_1() suggests that the point of the call to promote_decl_mode()
was to get the signedness of the result, and the only use of its return value
is in the gcc_assert().  I will check whether moving the gcc_assert() inside
the results in promote_function_mode() branch results in correct code; however,
that may just be papering over a real problem.

[Bug c++/48660] [4.5/4.6/4.7 Regression] ARM ICE in expand_expr_real_1

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

--- Comment #5 from Matthias Klose <doko at gcc dot gnu.org> 2011-09-03 14:18:30 UTC ---
works with 4.4.6, not with 4.5/4.6/trunk 20110824

[Bug middle-end/48660] [4.5/4.6/4.7 Regression] ARM ICE in expand_expr_real_1

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

rsandifo@gcc.gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-09/msg00558.htm
                   |                            |l
                 CC|                            |rsandifo at gcc dot gnu.org
          Component|c++                         |middle-end
         AssignedTo|unassigned at gcc dot       |rsandifo at gcc dot gnu.org
                   |gnu.org                     |

[Bug middle-end/48660] [4.5/4.6/4.7 Regression] ARM ICE in expand_expr_real_1

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.4

[Bug middle-end/48660] [4.5/4.6/4.7 Regression] ARM ICE in expand_expr_real_1

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
            Version|unknown                     |4.5.2

[Bug middle-end/48660] [4.5/4.6/4.7 Regression] ARM ICE in expand_expr_real_1

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

rsandifo@gcc.gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.7.0
      Known to fail|4.7.0                       |

--- Comment #7 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2011-12-21 16:36:37 UTC ---
Fixed on trunk.  I'll ask about backporting.

[Bug middle-end/48660] [4.5/4.6/4.7 Regression] ARM ICE in expand_expr_real_1

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

--- Comment #6 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2011-12-21 16:34:49 UTC ---
Author: rsandifo
Date: Wed Dec 21 16:34:41 2011
New Revision: 182595

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182595
Log:
Add reference to PR middle-end/48660

Modified:
    trunk/gcc/ChangeLog

[Bug middle-end/48660] [4.5/4.6 Regression] ARM ICE in expand_expr_real_1

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

--- Comment #8 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2012-01-06 14:56:52 UTC ---
Author: rsandifo
Date: Fri Jan  6 14:56:46 2012
New Revision: 182955

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182955
Log:
gcc/
    PR middle-end/48660
    * expr.h (copy_blkmode_to_reg): Declare.
    * expr.c (copy_blkmode_to_reg): New function.
    (expand_assignment): Don't expand register RESULT_DECLs before
    the lhs.  Use copy_blkmode_to_reg to copy BLKmode values into a
    RESULT_DECL register.
    (expand_expr_real_1): Handle BLKmode decls when looking for promotion.

gcc/testsuite/
    PR middle-end/48660
    * g++.dg/pr48660.C: New test.

Added:
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/pr48660.C
Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/expr.c
    branches/gcc-4_6-branch/gcc/expr.h
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug middle-end/48660] [4.5/4.6 Regression] ARM ICE in expand_expr_real_1

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

--- Comment #9 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2012-01-06 14:59:51 UTC ---
Author: rsandifo
Date: Fri Jan  6 14:59:47 2012
New Revision: 182956

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182956
Log:
gcc/
    PR middle-end/48660
    * expr.h (copy_blkmode_to_reg): Declare.
    * expr.c (copy_blkmode_to_reg): New function.
    (expand_assignment): Don't expand register RESULT_DECLs before
    the lhs.  Use copy_blkmode_to_reg to copy BLKmode values into a
    RESULT_DECL register.
    (expand_expr_real_1): Handle BLKmode decls when looking for promotion.

gcc/testsuite/
    PR middle-end/48660
    * g++.dg/pr48660.C: New test.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/pr48660.C
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/expr.c
    branches/gcc-4_5-branch/gcc/expr.h
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog

[Bug middle-end/48660] [4.5/4.6 Regression] ARM ICE in expand_expr_real_1

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48660

rsandifo@gcc.gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2012-01-18 11:53:39 UTC ---
Fixed on branches and trunk.