[Bug target/48708] New: Invalid V2DI vector set insn generated

[Bug target/48708] New: Invalid V2DI vector set insn generated

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48708

           Summary: Invalid V2DI vector set insn generated
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ubizjak@gmail.com


Following testcase, derived from PR48678:

#include <emmintrin.h>

typedef long long T __attribute__((may_alias));
struct S { __m128i d; };

__m128i
foo (long long *x, struct S *y, __m128i *z)
{
  struct S s = *y;
  ((T *) &s.d)[0] = *x;
  return _mm_cmpeq_epi16 (s.d, *z);
}

ICEs with invalid insn pattern (-O2 -msse2):

t.c: In function ‘foo’:
t.c:12:1: error: unrecognizable insn:
(insn 10 9 11 3 (set (reg/v:V2DI 66 [ s ])
        (vec_concat:V2DI (reg:DI 71)
            (vec_select:DI (reg/v:V2DI 66 [ s ])
                (parallel [
                        (const_int 1 [0x1])
                    ])))) t.c:10 -1
     (nil))
t.c:12:1: internal compiler error: in extract_insn, at recog.c:2109

The problem is in i386.c, ix86_expand_vector_set (around line 31485), where
V2DImode goes through the same code path as V2DFmode, synthesizing
unrecognisable vec_concat/vec_select insn in invalid mode.

[Bug target/48708] Invalid V2DI vector set insn generated

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48708

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.04.21 08:47:48
     Ever Confirmed|0                           |1

--- Comment #1 from Uros Bizjak <ubizjak at gmail dot com> 2011-04-21 08:47:48 UTC ---
Patch in testing:

Index: i386.c
===================================================================
--- i386.c    (revision 172811)
+++ i386.c    (working copy)
@@ -31483,10 +31483,19 @@ ix86_expand_vector_set (bool mmx_ok, rtx
       break;

     case V2DImode:
-      use_vec_merge = TARGET_SSE4_1;
+      use_vec_merge = TARGET_SSE4_1 && TARGET_64BIT;
       if (use_vec_merge)
     break;

+      tmp = gen_reg_rtx (GET_MODE_INNER (mode));
+      ix86_expand_vector_extract (false, tmp, target, 1 - elt);
+      if (elt == 0)
+    tmp = gen_rtx_VEC_CONCAT (mode, tmp, val);
+      else
+    tmp = gen_rtx_VEC_CONCAT (mode, val, tmp);
+      emit_insn (gen_rtx_SET (VOIDmode, target, tmp));
+      return;
+
     case V2DFmode:
       {
     rtx op0, op1;

[Bug target/48708] Invalid V2DI vector set insn generated

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48708

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |ubizjak at gmail dot com
                   |gnu.org                     |
   Target Milestone|---                         |4.6.2

[Bug target/48708] Invalid V2DI vector set insn generated

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48708

--- Comment #2 from uros at gcc dot gnu.org 2011-04-21 11:55:50 UTC ---
Author: uros
Date: Thu Apr 21 11:55:45 2011
New Revision: 172821

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=172821
Log:
    PR target/48708
    * config/i386/i386.c (ix86_expand_vector_set) <V2DImode>: Generate
    vec_extract and vec_concat for non-SSE4_1 targets.

testsuite/ChangeLog:

    PR target/48708
    * gcc.target/i386/pr48708.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/i386/pr48708.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/48708] Invalid V2DI vector set insn generated

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48708

--- Comment #3 from uros at gcc dot gnu.org 2011-04-21 20:23:58 UTC ---
Author: uros
Date: Thu Apr 21 20:23:55 2011
New Revision: 172843

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=172843
Log:
    PR target/48708
    * config/i386/i386.c (ix86_expand_vector_set) <V2DImode>: Generate
    vec_extract and vec_concat for non-SSE4_1 targets.

testsuite/ChangeLog:

    PR target/48708
    * gcc.target/i386/pr48708.c: New test.


Added:
    branches/gcc-4_6-branch/gcc/testsuite/gcc.target/i386/pr48708.c
Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/config/i386/i386.c
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug target/48708] Invalid V2DI vector set insn generated

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48708

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.6.2                       |---

[Bug target/48708] Invalid V2DI vector set insn generated

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48708

--- Comment #4 from uros at gcc dot gnu.org 2011-05-04 18:25:33 UTC ---
Author: uros
Date: Wed May  4 18:25:25 2011
New Revision: 173389

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=173389
Log:
    Backport from mainline
    2011-04-21  Uros Bizjak  <ubizjak@gmail.com>

    PR target/48708
    * config/i386/i386.c (ix86_expand_vector_set) <V2DImode>: Generate
    vec_extract and vec_concat for non-SSE4_1 targets.

testsuite/ChangeLog:

    Backport from mainline
    2011-04-21  Uros Bizjak  <ubizjak@gmail.com>

    PR target/48708
    * gcc.target/i386/pr48708.c: New test.


Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.target/i386/pr48708.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/config/i386/i386.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog

[Bug target/48708] Invalid V2DI vector set insn generated

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48708

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-04/msg01760.htm
                   |                            |l
         Resolution|                            |FIXED
   Target Milestone|---                         |4.5.4

--- Comment #5 from Uros Bizjak <ubizjak at gmail dot com> 2011-05-04 18:28:20 UTC ---
Fixed.