public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types
@ 2011-04-26 13:50 daniel.kruegler at googlemail dot com
2011-04-26 14:10 ` [Bug c++/48771] " paolo.carlini at oracle dot com
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: daniel.kruegler at googlemail dot com @ 2011-04-26 13:50 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48771
Summary: [C++0x] is_literal_type incorrect for references to
non-literal types
Product: gcc
Version: 4.7.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: daniel.kruegler@googlemail.com
gcc 4.7.0 20110423 (experimental) in C++0x mode rejects the following code:
//-----------
#include <type_traits>
struct NonLiteral {
NonLiteral();
~NonLiteral();
};
static_assert(std::is_literal_type<NonLiteral&>::value, "Error"); // #1
static_assert(std::is_literal_type<NonLiteral&&>::value, "Error"); // #2
//-----------
because both assertions fire. This code should be accepted, because as of the
FDIS all reference types are literal types (similar to pointers).
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/48771] [C++0x] is_literal_type incorrect for references to non-literal types
2011-04-26 13:50 [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types daniel.kruegler at googlemail dot com
@ 2011-04-26 14:10 ` paolo.carlini at oracle dot com
2011-04-26 14:40 ` paolo.carlini at oracle dot com
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-04-26 14:10 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48771
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2011.04.26 14:10:31
CC| |jason at gcc dot gnu.org
Component|libstdc++ |c++
Ever Confirmed|0 |1
--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-04-26 14:10:31 UTC ---
This is really a C++ front-end issue, not a library issue, because it just
boils down to __is_literal_type and in turn to the internal literal_type_p,
which apparently should be updated to reflect the FDIS concept.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/48771] [C++0x] is_literal_type incorrect for references to non-literal types
2011-04-26 13:50 [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types daniel.kruegler at googlemail dot com
2011-04-26 14:10 ` [Bug c++/48771] " paolo.carlini at oracle dot com
@ 2011-04-26 14:40 ` paolo.carlini at oracle dot com
2011-04-27 3:58 ` jason at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-04-26 14:40 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48771
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paolo.carlini at oracle dot
| |com
--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-04-26 14:39:36 UTC ---
The below patchlet fixes the problem and passes the testsuite.
Jason, let me know if you consider it safe, for 4_6-branch too, in case.
Paolo.
//////////////
Index: testsuite/g++.dg/ext/is_literal_type1.C
===================================================================
--- testsuite/g++.dg/ext/is_literal_type1.C (revision 0)
+++ testsuite/g++.dg/ext/is_literal_type1.C (revision 0)
@@ -0,0 +1,11 @@
+// PR c++/48771
+// { dg-do compile }
+// { dg-options "-std=c++0x" }
+
+struct NonLiteral {
+ NonLiteral();
+ ~NonLiteral();
+};
+
+static_assert(__is_literal_type(NonLiteral&), "Error");
+static_assert(__is_literal_type(NonLiteral&&), "Error");
Index: cp/semantics.c
===================================================================
--- cp/semantics.c (revision 172961)
+++ cp/semantics.c (working copy)
@@ -5331,7 +5331,8 @@ float_const_decimal64_p (void)
bool
literal_type_p (tree t)
{
- if (SCALAR_TYPE_P (t))
+ if (SCALAR_TYPE_P (t)
+ || TREE_CODE (t) == REFERENCE_TYPE)
return true;
if (CLASS_TYPE_P (t))
return CLASSTYPE_LITERAL_P (t);
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/48771] [C++0x] is_literal_type incorrect for references to non-literal types
2011-04-26 13:50 [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types daniel.kruegler at googlemail dot com
2011-04-26 14:10 ` [Bug c++/48771] " paolo.carlini at oracle dot com
2011-04-26 14:40 ` paolo.carlini at oracle dot com
@ 2011-04-27 3:58 ` jason at gcc dot gnu.org
2011-04-27 9:01 ` paolo.carlini at oracle dot com
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jason at gcc dot gnu.org @ 2011-04-27 3:58 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48771
--- Comment #3 from Jason Merrill <jason at gcc dot gnu.org> 2011-04-27 03:58:16 UTC ---
Looks fine, but also remove the REFERENCE_TYPE check in
valid_type_in_constexpr_fundecl_p.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/48771] [C++0x] is_literal_type incorrect for references to non-literal types
2011-04-26 13:50 [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types daniel.kruegler at googlemail dot com
` (2 preceding siblings ...)
2011-04-27 3:58 ` jason at gcc dot gnu.org
@ 2011-04-27 9:01 ` paolo.carlini at oracle dot com
2011-04-28 9:23 ` paolo at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-04-27 9:01 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48771
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC|paolo.carlini at oracle dot |
|com |
AssignedTo|unassigned at gcc dot |paolo.carlini at oracle dot
|gnu.org |com
--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-04-27 08:26:13 UTC ---
Ok, thanks, patch to the mailing list forthcoming.
I'm also considering removing valid_type_in_constexpr_fundecl_p altogether and
replacing the two calls with literal_type_p directly.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/48771] [C++0x] is_literal_type incorrect for references to non-literal types
2011-04-26 13:50 [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types daniel.kruegler at googlemail dot com
` (3 preceding siblings ...)
2011-04-27 9:01 ` paolo.carlini at oracle dot com
@ 2011-04-28 9:23 ` paolo at gcc dot gnu.org
2011-04-28 9:25 ` paolo.carlini at oracle dot com
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paolo at gcc dot gnu.org @ 2011-04-28 9:23 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48771
--- Comment #5 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-04-28 09:21:25 UTC ---
Author: paolo
Date: Thu Apr 28 09:21:23 2011
New Revision: 173062
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=173062
Log:
/cp
2011-04-28 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/48771
* semantics.c (literal_type_p): Reference types are literal types,
per the FDIS.
(valid_type_in_constexpr_fundecl_p): Remove.
(is_valid_constexpr_fn): Adjust.
/testsuite
2011-04-28 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/48771
* g++.dg/ext/is_literal_type1.C: New.
Added:
trunk/gcc/testsuite/g++.dg/ext/is_literal_type1.C
Modified:
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/semantics.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/48771] [C++0x] is_literal_type incorrect for references to non-literal types
2011-04-26 13:50 [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types daniel.kruegler at googlemail dot com
` (4 preceding siblings ...)
2011-04-28 9:23 ` paolo at gcc dot gnu.org
@ 2011-04-28 9:25 ` paolo.carlini at oracle dot com
2011-04-28 15:57 ` rguenth at gcc dot gnu.org
2011-06-06 15:43 ` paolo.carlini at oracle dot com
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-04-28 9:25 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48771
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.6.1
--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-04-28 09:23:50 UTC ---
Done on the mainline so far.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/48771] [C++0x] is_literal_type incorrect for references to non-literal types
2011-04-26 13:50 [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types daniel.kruegler at googlemail dot com
` (5 preceding siblings ...)
2011-04-28 9:25 ` paolo.carlini at oracle dot com
@ 2011-04-28 15:57 ` rguenth at gcc dot gnu.org
2011-06-06 15:43 ` paolo.carlini at oracle dot com
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-04-28 15:57 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48771
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.6.1 |---
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/48771] [C++0x] is_literal_type incorrect for references to non-literal types
2011-04-26 13:50 [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types daniel.kruegler at googlemail dot com
` (6 preceding siblings ...)
2011-04-28 15:57 ` rguenth at gcc dot gnu.org
@ 2011-06-06 15:43 ` paolo.carlini at oracle dot com
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-06-06 15:43 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48771
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.7.0
--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-06-06 15:42:57 UTC ---
I guess we can be satisfied with having this fixed in mainline.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-06-06 15:43 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-26 13:50 [Bug libstdc++/48771] New: [C++0x] is_literal_type incorrect for references to non-literal types daniel.kruegler at googlemail dot com
2011-04-26 14:10 ` [Bug c++/48771] " paolo.carlini at oracle dot com
2011-04-26 14:40 ` paolo.carlini at oracle dot com
2011-04-27 3:58 ` jason at gcc dot gnu.org
2011-04-27 9:01 ` paolo.carlini at oracle dot com
2011-04-28 9:23 ` paolo at gcc dot gnu.org
2011-04-28 9:25 ` paolo.carlini at oracle dot com
2011-04-28 15:57 ` rguenth at gcc dot gnu.org
2011-06-06 15:43 ` paolo.carlini at oracle dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).