[Bug gcov-profile/48845] New: [4.7 regression] All g++.dg/tree-prof and gcc.dg/{matrix, tree-prof} executions tests fail on Solaris 8/9

[Bug gcov-profile/48845] New: [4.7 regression] All g++.dg/tree-prof and gcc.dg/{matrix, tree-prof} executions tests fail on Solaris 8/9

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48845

           Summary: [4.7 regression] All g++.dg/tree-prof and
                    gcc.dg/{matrix, tree-prof} executions tests fail on
                    Solaris 8/9
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: gcov-profile
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ro@gcc.gnu.org
                CC: davidxl@gcc.gnu.org
              Host: *-*-solaris2.[89]
            Target: *-*-solaris2.[89]
             Build: *-*-solaris2.[89]


Between 20110421 and 20110429, all g++.dg/tree-prof and gcc.dg/{matrix,
tree-prof}
execution tests started to fail on Solaris 8 and 9, both x86 and SPARC:

+FAIL: g++.dg/tree-prof/indir-call-prof-2.C execution,    -g 
-fprofile-generate

spawn [open ...]
ld.so.1: indir-call-prof-2.x01: fatal:
/var/gcc/regression/trunk/9-gcc-gas/build
/gcc/testsuite/g++/indir-call-prof-2.x01: object requires TLS, but TLS failed
to
 initialize

This obviously happens since profiling now uses TLS under the hood:

[5]     |         4|       4|TLS  |LOCL |0    |9     
|__gcov_indirect_call_callee
[6]     |         0|       4|TLS  |LOCL |0    |9     
|__gcov_indirect_call_counters

So it is caused by this patch:

2011-04-27  Xinliang David Li  <davidxl@google.com>

        * tree-profile.c (init_ic_make_global_vars): Set
        tls attribute on ic vars.
        * coverage.c (coverage_end_function): Initialize
        function_list with zero.

Some platforms require special options for TLS, which is handled by
dg-add-options tls.  It seems that all tests in those directories should be
marked

  dg-require-effective-target tls_runtime
  dg-add-options tls

or rather this should be handled in the .exp files instead.

  Rainer

[Bug gcov-profile/48845] [4.7 regression] All g++.dg/tree-prof and gcc.dg/{matrix, tree-prof} executions tests fail on Solaris 8/9

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48845

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0

[Bug gcov-profile/48845] [4.7 regression] All g++.dg/tree-prof and gcc.dg/{matrix, tree-prof} executions tests fail on Solaris 8/9

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48845

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> 2011-05-24 14:53:42 UTC ---
Author: ro
Date: Tue May 24 14:53:39 2011
New Revision: 174119

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=174119
Log:
    PR gcov-profile/48845
    * config/sol2.h (LIB_SPEC): Link TLS support for tree profiling.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/sol2.h

[Bug gcov-profile/48845] [4.7 regression] All g++.dg/tree-prof and gcc.dg/{matrix, tree-prof} executions tests fail on Solaris 8/9

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48845

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.05.24 21:25:43
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
     Ever Confirmed|0                           |1

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-05-24 21:25:43 UTC ---
Yep.

[Bug gcov-profile/48845] [4.7 regression] All g++.dg/tree-prof and gcc.dg/{matrix, tree-prof} executions tests fail on Solaris 8/9

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48845

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-05/msg01719.htm
                   |                            |l,http://gcc.gnu.org/ml/gcc
                   |                            |-patches/2011-05/msg01981.h
                   |                            |tml
         Resolution|                            |FIXED
         AssignedTo|unassigned at gcc dot       |ro at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> 2011-05-26 11:17:35 UTC ---
Fixed both for Solaris and in testsuite.