public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/48847] New: Wrong "unused parameter" warning with interface block
@ 2011-05-02 20:38 tkoenig at gcc dot gnu.org
  2011-12-15 21:59 ` [Bug fortran/48847] " dominiq at lps dot ens.fr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2011-05-02 20:38 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48847

           Summary: Wrong "unused parameter" warning with interface block
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: enhancement
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: tkoenig@gcc.gnu.org


Original test case by Ondrej Certik from
http://gcc.gnu.org/ml/fortran/2011-04/msg00297.html

Reduced test case:

module foo
contains
  function f(g)
    interface
       real function g()
       end function g
    end interface
    real :: f
    f = g()
  end function f
end module foo
ig25@linux-fd1f:~/Krempel/Warn> gfortran -c -Wunused-parameter b.f90
b.f90:3:0: warning: unused parameter 'g' [-Wunused-parameter]

Same warning in 4.4, so probably not a regression.


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/48847] Wrong "unused parameter" warning with interface block
  2011-05-02 20:38 [Bug fortran/48847] New: Wrong "unused parameter" warning with interface block tkoenig at gcc dot gnu.org
@ 2011-12-15 21:59 ` dominiq at lps dot ens.fr
  2012-02-03 22:13 ` tkoenig at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: dominiq at lps dot ens.fr @ 2011-12-15 21:59 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48847

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-12-15
     Ever Confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-12-15 21:57:44 UTC ---
Confirmed, it is still there at revision 182390.


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/48847] Wrong "unused parameter" warning with interface block
  2011-05-02 20:38 [Bug fortran/48847] New: Wrong "unused parameter" warning with interface block tkoenig at gcc dot gnu.org
  2011-12-15 21:59 ` [Bug fortran/48847] " dominiq at lps dot ens.fr
@ 2012-02-03 22:13 ` tkoenig at gcc dot gnu.org
  2012-02-04 22:14 ` tkoenig at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2012-02-03 22:13 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48847

--- Comment #2 from Thomas Koenig <tkoenig at gcc dot gnu.org> 2012-02-03 22:13:07 UTC ---
This doesn't match the docs.  We say

-Wunused-parameter'
     Contrary to `gcc''s meaning of `-Wunused-parameter', `gfortran''s
     implementation of this option does not warn about unused dummy
     arguments (see `-Wunused-dummy-argument'), but about unused
     `PARAMETER' values. `-Wunused-parameter' is not included in
     `-Wall' but is implied by `-Wall -Wextra'.

-Wunsued-parameter is being used in the C sense here.

We don't warn with

ig25@linux-fd1f:~/Krempel/Unused> cat bar.f90
module foo
contains
  function f(g)
    f = g()
  end function f
end module foo
ig25@linux-fd1f:~/Krempel/Unused> gfortran -S -Wunused-dummy-argument bar.f90

(and we should).


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/48847] Wrong "unused parameter" warning with interface block
  2011-05-02 20:38 [Bug fortran/48847] New: Wrong "unused parameter" warning with interface block tkoenig at gcc dot gnu.org
  2011-12-15 21:59 ` [Bug fortran/48847] " dominiq at lps dot ens.fr
  2012-02-03 22:13 ` tkoenig at gcc dot gnu.org
@ 2012-02-04 22:14 ` tkoenig at gcc dot gnu.org
  2012-02-05 20:14 ` tkoenig at gcc dot gnu.org
  2012-02-05 20:16 ` tkoenig at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2012-02-04 22:14 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48847

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |tkoenig at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Thomas Koenig <tkoenig at gcc dot gnu.org> 2012-02-04 22:14:40 UTC ---
I have a patch.


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/48847] Wrong "unused parameter" warning with interface block
  2011-05-02 20:38 [Bug fortran/48847] New: Wrong "unused parameter" warning with interface block tkoenig at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2012-02-04 22:14 ` tkoenig at gcc dot gnu.org
@ 2012-02-05 20:14 ` tkoenig at gcc dot gnu.org
  2012-02-05 20:16 ` tkoenig at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2012-02-05 20:14 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48847

--- Comment #4 from Thomas Koenig <tkoenig at gcc dot gnu.org> 2012-02-05 20:14:10 UTC ---
Author: tkoenig
Date: Sun Feb  5 20:14:00 2012
New Revision: 183916

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183916
Log:
2012-02-05  Thomas König  <tkoenig@gcc.gnu.org>

    PR fortran/48847
    * trans-decl.c:  Warn about unused dummy procedure arguments
    if -Wunused-dummy-argument is specified.  Suppress middle-end
    warnings about procedure arguments.

2012-02-05  Thomas König  <tkoenig@gcc.gnu.org>

    PR fortran/48847
    * gfortran.dg/warn_unused_dummy_argument_3.f90:  New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/warn_unused_dummy_argument_3.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/testsuite/ChangeLog


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/48847] Wrong "unused parameter" warning with interface block
  2011-05-02 20:38 [Bug fortran/48847] New: Wrong "unused parameter" warning with interface block tkoenig at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2012-02-05 20:14 ` tkoenig at gcc dot gnu.org
@ 2012-02-05 20:16 ` tkoenig at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2012-02-05 20:16 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48847

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Thomas Koenig <tkoenig at gcc dot gnu.org> 2012-02-05 20:15:51 UTC ---
Fixed on trunk, closing.


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-05 20:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-02 20:38 [Bug fortran/48847] New: Wrong "unused parameter" warning with interface block tkoenig at gcc dot gnu.org
2011-12-15 21:59 ` [Bug fortran/48847] " dominiq at lps dot ens.fr
2012-02-03 22:13 ` tkoenig at gcc dot gnu.org
2012-02-04 22:14 ` tkoenig at gcc dot gnu.org
2012-02-05 20:14 ` tkoenig at gcc dot gnu.org
2012-02-05 20:16 ` tkoenig at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).