[Bug target/48860] New: r173265 breaks bootstrap on x86_64-apple-darwin10

[Bug target/48860] New: r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

           Summary: r173265 breaks bootstrap on x86_64-apple-darwin10
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: howarth@nitro.med.uc.edu


The commit...

r173265 | uros | 2011-05-02 14:58:32 -0400 (Mon, 02 May 2011) | 13 lines

        * config/i386/mmx.md (*mov<mode>_internal_rex64): Use %vmovq for
        reg<->xmm moves.
        (*mov<mode>_internal): Merge with *mov<mode>_internal_avx.
        (*movv2sf_internal_rex64): Use %vmovq for reg<->xmm moves.  Merge
        with *movv2sf_internal_rex64_avx.
        (*movv2sf_internal): Merge with *movv2sf_internal_avx.
        * config/i386/i386.md (*movdi_internal_rex64) <TYPE_SSEMOV>:
        Use %v prefix in insn mnemonic to handle TARGET_AVX.
        (*movdi_internal): Add "isa" attribute.  Use "maybe_vex" instead of
        "vex" in "prefix" attribute calculation.
        (*movdf_internal): Output AVX mnemonics.  Add "prefix" attribute.

breaks the bootstrap of gcc trunk on x86_64-apple-darwin10 as follows...

/sw/src/fink.build/gcc47-4.7.0-1000/darwin_objdir/./gcc/xgcc
-B/sw/src/fink.build/gcc47-4.7.0-1000/darwin_objdir/./gcc/
-B/sw/lib/gcc4.7/x86_64-apple-darwin10.7.0/bin/
-B/sw/lib/gcc4.7/x86_64-apple-darwin10.7.0/lib/ -isystem
/sw/lib/gcc4.7/x86_64-apple-darwin10.7.0/include -isystem
/sw/lib/gcc4.7/x86_64-apple-darwin10.7.0/sys-include    -g -O2 -O2  -g -O2
-DIN_GCC   -W -Wall -Wwrite-strings -Wcast-qual -Wstrict-prototypes
-Wmissing-prototypes -Wold-style-definition  -isystem ./include  -fPIC -pipe -g
-DHAVE_GTHR_DEFAULT -DIN_LIBGCC2 -D__GCC_FLOAT_NOT_NEEDED -fno-stack-protector 
 -I. -I. -I../.././gcc -I../../../gcc-4.7-20110503/libgcc
-I../../../gcc-4.7-20110503/libgcc/. -I../../../gcc-4.7-20110503/libgcc/../gcc
-I../../../gcc-4.7-20110503/libgcc/../include  -DHAVE_CC_TLS -DUSE_EMUTLS -o
extenddftf2_s.o -MT extenddftf2_s.o -MD -MP -MF extenddftf2_s.dep -DSHARED
-fexceptions -c
../../../gcc-4.7-20110503/libgcc/../gcc/config/soft-fp/extenddftf2.c
../../../gcc-4.7-20110503/libgcc/../gcc/config/soft-fp/extenddftf2.c:36:8:
warning: no previous prototype for '__extenddftf2' [-Wmissing-prototypes]
{standard input}:11:suffix or operands invalid for `movq'
{standard input}:14:suffix or operands invalid for `movq'
make[3]: *** [extenddftf2_s.o] Error 1
make[2]: *** [all-stage1-target-libgcc] Error 2
make[1]: *** [stage1-bubble] Error 2
make: *** [all] Error 2

This problem doesn't exist at r173264.

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #3 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-05-04 04:53:07 UTC ---
  $ ../gcc-4.7-20110503/configure --prefix=/sw --prefix=/sw/lib/gcc4.7
--mandir=/sw/share/man --infodir=/sw/lib/gcc4.7/info
--with-build-config=bootstrap-lto --enable-stage1-languages=c,lto
--enable-languages=c,c++,fortran,lto,objc,obj-c++,java --with-gmp=/sw
--with-libiconv-prefix=/sw --with-ppl=/sw --with-cloog=/sw --with-mpc=/sw
--with-system-zlib --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib
--program-suffix=-fsf-4.7 --enable-checking=yes --enable-cloog-backend=isl

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #1 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-05-04 04:51:56 UTC ---
Created attachment 24173
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24173
preprocessed source for libgcc/../gcc/config/soft-fp/extenddftf2.c

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #2 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-05-04 04:52:26 UTC ---
Created attachment 24174
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24174
assembly file for libgcc/../gcc/config/soft-fp/extenddftf2.c

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #4 from Uros Bizjak <ubizjak at gmail dot com> 2011-05-04 06:17:47 UTC ---
(In reply to comment #2)
> Created attachment 24174 [details]
> assembly file for libgcc/../gcc/config/soft-fp/extenddftf2.c

Can you please add -dp to compile flags?

Which assembler do you use?

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #5 from Uros Bizjak <ubizjak at gmail dot com> 2011-05-04 07:04:50 UTC ---
Created attachment 24176
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24176
Band-aid patch for broken assemblers

You have broken assembler, see Intel instruction set reference, MOVD/MOVQ insn.

I will provide the patch that detects this problem in the assembler, but please
report this to eventually fix the assembler issue.

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #6 from uros at gcc dot gnu.org 2011-05-04 10:05:23 UTC ---
Author: uros
Date: Wed May  4 10:05:20 2011
New Revision: 173361

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=173361
Log:
    PR target/48860
    * config/i386/i386.md (*movdi_internal_rex64) Use %vmovd
    for reg<->xmm moves.
    * config/i386/sse.md (*vec_concatv2di_rex64_sse4_1): Ditto.
    (vec_concatv2di_rex64_sse): Ditto.
    (*sse2_storeq_rex64): Do not emit %v prefix for mov{q} mnemonic.
    (*vec_extractv2di_1_rex64): Ditto.

    Revert:
    2011-05-02  Uros Bizjak  <ubizjak@gmail.com>

    * config/i386/mmx.md (*mov<mode>_internal_rex64): Use %vmovq for
    reg<->xmm moves.
    (*movv2sf_internal_rex64): Use %vmovq for reg<->xmm moves.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.md
    trunk/gcc/config/i386/mmx.md
    trunk/gcc/config/i386/sse.md

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #8 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-05-04 12:52:02 UTC ---
The assembler is from...

Xcode 4.0.2
Build version 4A2002a

but the assembler from...

Xcode 3.2.6
Component versions: DevToolsCore-1809.0; DevToolsSupport-1806.0
BuildVersion: 10M2518

also shows the same error.

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #7 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-05-04 12:49:27 UTC ---
Created attachment 24180
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24180
assembly file for libgcc/../gcc/config/soft-fp/extenddftf2.c with -dp

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #9 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-05-04 12:58:41 UTC ---
Opened radr://9381460 with extenddftf2.s generated with -dp as the testcase.

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #10 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-05-04 13:10:23 UTC ---
Could this be similar to the required change from...

http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01024.html

to adapt to the darwin assembler's usage of movq?

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #11 from Uros Bizjak <ubizjak at gmail dot com> 2011-05-04 13:25:28 UTC ---
(In reply to comment #10)
> Could this be similar to the required change from...
> 
> http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01024.html
> 
> to adapt to the darwin assembler's usage of movq?

Yes... Unfortunately, the commit didn't explain, why inconsistent use of movd
vs. movq.

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

--- Comment #12 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-05-04 14:13:04 UTC ---
This looks similar to this bug...

 http://www.mail-archive.com/mpir-devel@googlegroups.com/msg04286.html

where is claimed these are bugs in the older gas on darwin.

[Bug target/48860] r173265 breaks bootstrap on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48860

Jack Howarth <howarth at nitro dot med.uc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-05-04 15:11:49 UTC ---
Bootstrap fixed again on x86_64-apple-darwin10 at r173376.