From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-355867-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 26871 invoked by alias); 6 May 2011 09:22:38 -0000
Received: (qmail 26862 invoked by uid 22791); 6 May 2011 09:22:38 -0000
X-SWARE-Spam-Status: No, hits=-2.7 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 May 2011 09:22:24 +0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/48908] [4.7 Regression]: build fails on cris-elf in libiberty:md5.c, shift-related
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Keywords: build, ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.0
X-Bugzilla-Changed-Fields:
Message-ID: <bug-48908-4-U6lrmDLwiT@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-48908-4@http.gcc.gnu.org/bugzilla/>
References: <bug-48908-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Fri, 06 May 2011 09:22:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2011-05/txt/msg00534.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48908

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-05-06 09:19:38 UTC ---
Ok, so

              other_amount
                = simplify_gen_binary (MINUS, GET_MODE (op1),
                                       GEN_INT (GET_MODE_BITSIZE (mode)),
                                       op1);

does not constant fold!?  Oh.

The following fixes the ICE for me:

Index: expmed.c
===================================================================
--- expmed.c    (revision 173473)
+++ expmed.c    (working copy)
@@ -2141,9 +2141,12 @@ expand_shift_1 (enum tree_code code, enu
              rtx new_amount, other_amount;
              rtx temp1;

+             op1_mode = GET_MODE (op1);
+             if (op1_mode == VOIDmode)
+               op1_mode = word_mode;
              new_amount = op1;
              other_amount
-               = simplify_gen_binary (MINUS, GET_MODE (op1),
+               = simplify_gen_binary (MINUS, op1_mode,
                                       GEN_INT (GET_MODE_BITSIZE (mode)),
                                       op1);

or, other variant, side-stepping the issue:

Index: expmed.c
===================================================================
--- expmed.c    (revision 173473)
+++ expmed.c    (working copy)
@@ -2141,11 +2141,16 @@ expand_shift_1 (enum tree_code code, enu
              rtx new_amount, other_amount;
              rtx temp1;

+             op1_mode = GET_MODE (op1);
              new_amount = op1;
-             other_amount
-               = simplify_gen_binary (MINUS, GET_MODE (op1),
-                                      GEN_INT (GET_MODE_BITSIZE (mode)),
-                                      op1);
+             if (op1_mode == VOIDmode)
+               other_amount = GEN_INT (GET_MODE_BITSIZE (mode)
+                                       - INTVAL (op1));
+             else
+               other_amount
+                 = simplify_gen_binary (MINUS, op1_mode,
+                                        GEN_INT (GET_MODE_BITSIZE (mode)),
+                                        op1);

              shifted = force_reg (mode, shifted);