public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug objc++/49070] [8/9/10/11 regression] ObjC++ compiler fails to compile ObjC method invocations without keyword arguments
Date: Wed, 24 Mar 2021 22:07:34 +0000	[thread overview]
Message-ID: <bug-49070-4-fydfRAoHxm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-49070-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49070

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:e3cac00975a1de879dc8356285a8908c25026ec4

commit r10-9536-ge3cac00975a1de879dc8356285a8908c25026ec4
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Fri Feb 26 10:21:02 2021 +0000

    Objective-C++ : Fix handling of unnamed message parms [PR49070].

    When we are parsing an Objective-C++ message, a colon is a valid
    terminator for a assignment-expression.  That is:

    [receiver meth:x:x:x:x];

    Is a valid, if somewhat unreadable, construction; corresponding
    to a method declaration like:

    - (id) meth:(id)arg0 :(id)arg1 :(id)arg2 :(id)arg3;

    Where three of the message params have no selector name.

    If fact, although it might be unintentional, Objective-C/C++ can
    accept message selectors with all the parms unnamed (this applies
    to the clang implementation too, which is taken as the reference
    for the language).

    For regular C++, the pattern x:x is not valid in that position an
    an error is emitted with a fixit for the expected scope token.

    If we simply made that error conditional on !c_dialect_objc()
    that would regress Objective-C++ diagnostics for cases outside a
    message selector, so we add a state flag for this.

    gcc/cp/ChangeLog:

            PR objc++/49070
            * parser.c (cp_debug_parser): Add Objective-C++ message
            state flag.
            (cp_parser_nested_name_specifier_opt): Allow colon to
            terminate an assignment-expression when parsing Objective-
            C++ messages.
            (cp_parser_objc_message_expression): Set and clear message
            parsing state on entry and exit.
            * parser.h (struct cp_parser): Add a context flag for
            Objective-C++ message state.

    gcc/testsuite/ChangeLog:

            PR objc++/49070
            * obj-c++.dg/pr49070.mm: New test.
            * objc.dg/unnamed-parms.m: New test.

    (cherry picked from commit 0cc218d42c241ed286cc5af9fb7d2e45386f7a24)

  parent reply	other threads:[~2021-03-24 22:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 19:11 [Bug objc++/49070] New: " nicola at gcc dot gnu.org
2011-05-19 19:14 ` [Bug objc++/49070] " nicola at gcc dot gnu.org
2021-02-26 21:42 ` [Bug objc++/49070] [8/9/10/11 regression] " iains at gcc dot gnu.org
2021-03-18 11:50 ` cvs-commit at gcc dot gnu.org
2021-03-24 22:07 ` cvs-commit at gcc dot gnu.org [this message]
2021-05-14 14:05 ` [Bug objc++/49070] [9/10/11/12 " jakub at gcc dot gnu.org
2021-06-01  8:05 ` rguenth at gcc dot gnu.org
2022-05-27  9:11 ` [Bug objc++/49070] [9 " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-49070-4-fydfRAoHxm@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).