public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/49074] [OOP] Defined assignment w/ CLASS arrays: Incomplete error message
Date: Thu, 16 Jun 2011 18:24:00 -0000	[thread overview]
Message-ID: <bug-49074-4-zelbCZ2QWT@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-49074-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49074

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |janus at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from janus at gcc dot gnu.org 2011-06-16 18:24:15 UTC ---
Ok, in fact we just fail to propagate the locus when replacing the assignment
with the corresponding type-bound call. The following one-liner fixes it:


Index: gcc/fortran/interface.c
===================================================================
--- gcc/fortran/interface.c    (revision 175100)
+++ gcc/fortran/interface.c    (working copy)
@@ -3242,6 +3242,7 @@ gfc_extend_assign (gfc_code *c, gfc_namespace *ns)
       c->expr1 = gfc_get_expr ();
       build_compcall_for_operator (c->expr1, actual, tb_base, tbo, gname);
       c->expr1->value.compcall.assign = 1;
+      c->expr1->where = c->loc;
       c->expr2 = NULL;
       c->op = EXEC_COMPCALL;


With this one gets the correct error message:

        foobar = [bar(1), bar(2)]
                                 1
Error: Non-scalar base object at (1) currently not implemented


Will commit as obvious after regtesting.


  parent reply	other threads:[~2011-06-16 18:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20  4:52 [Bug fortran/49074] New: " jvdelisle at gcc dot gnu.org
2011-05-20  7:27 ` [Bug fortran/49074] [OOP] Defined assignment w/ CLASS arrays: " burnus at gcc dot gnu.org
2011-06-16 17:51 ` janus at gcc dot gnu.org
2011-06-16 18:24 ` janus at gcc dot gnu.org [this message]
2011-06-16 21:46 ` janus at gcc dot gnu.org
2011-06-16 21:49 ` janus at gcc dot gnu.org
2011-06-19 21:08 ` janus at gcc dot gnu.org
2011-06-19 21:32 ` janus at gcc dot gnu.org
2011-12-11 20:48 ` pault at gcc dot gnu.org
2011-12-12 12:27 ` burnus at gcc dot gnu.org
2011-12-12 12:39 ` burnus at gcc dot gnu.org
2013-06-11 16:14 ` mikael at gcc dot gnu.org
2013-06-13 16:08 ` burnus at gcc dot gnu.org
2013-06-14 11:40 ` mikael at gcc dot gnu.org
2013-06-15 21:23 ` mikael at gcc dot gnu.org
2013-06-15 21:25 ` mikael at gcc dot gnu.org
2013-06-15 21:28 ` mikael at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-49074-4-zelbCZ2QWT@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).