[Bug target/49114] New: [x32] 454.calculix in SPEC CPU 2006 failed

[Bug target/49114] New: [x32] 454.calculix in SPEC CPU 2006 failed

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

           Summary: [x32] 454.calculix in SPEC CPU 2006 failed
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com


x32 branch miscompiled 454.calculix in SPEC CPU 2006 with

-mx32 -DSPEC_CPU -DNDEBUG -ISPOOLES  -O3 -funroll-loops -ffast-math

I got

  Running 454.calculix ref peak lnxx32-gcc default

454.calculix: copy 0 non-zero return code (exit code=11, signal=0)


****************************************
Contents of hyperviscoplastic.err
****************************************
/bin/sh: line 1: 13660 Segmentation fault      taskset -c $TASK_CPU
../run_peak_
ref_lnxx32-gcc.0000/calculix_peak.lnxx32-gcc -i hyperviscoplastic

[Bug target/49114] [x32] 454.calculix in SPEC CPU 2006 failed

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2011-05-24 04:40:08 UTC ---
gen_reload generates wrong code for

(gdb) call debug_rtx (out)
(reg:SI 1 dx)
(gdb) call debug_rtx (in)
(plus:SI (subreg:SI (reg/v/f:DI 182 [ b ]) 0)
    (const_int 8 [0x8]))
(gdb) 

when dx contains DI 182 [ b ].  gen_reload first
puts (const_int 8 [0x8]) in dx and then replaces
DI 182 [ b ] with dx.

[Bug target/49114] [x32] 454.calculix in SPEC CPU 2006 failed

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2011-05-24 05:12:46 UTC ---
For

(insn 588 587 589 28 (set (mem:DF (zero_extend:DI (plus:SI (subreg:SI
(reg/v/f:DI 182 [ b ]) 0) 
                    (const_int 8 [0x8]))) [4 MEM[base: b_96(D), index:
D.15020_278, step: 8, offset: 0B]+0 S8 A64])
        (reg:DF 340 [ D.14980 ])) spooles.c:291 106 {*movdf_internal_rex64}
     (expr_list:REG_DEAD (reg:DF 340 [ D.14980 ])
        (nil)))

reload generates:

(note 587 586 1017 34 NOTE_INSN_DELETED)

(insn 1017 587 1020 34 (set (reg:DI 1 dx)
        (mem/c:DI (plus:DI (reg/f:DI 7 sp)
                (const_int 112 [0x70])) [5 %sfp+-208 S8 A64])) spooles.c:291 62
{*movdi_internal_rex64}
     (nil))

(insn 1020 1017 1022 34 (set (reg:SI 1 dx)
        (const_int 8 [0x8])) spooles.c:291 64 {*movsi_internal}
     (nil))

(insn 1022 1020 1023 34 (set (reg:SI 1 dx)
        (reg:SI 1 dx)) spooles.c:291 64 {*movsi_internal}
     (nil))

(insn 1023 1022 1024 34 (set (reg:SI 1 dx)
        (plus:SI (reg:SI 1 dx)
            (const_int 8 [0x8]))) spooles.c:291 248 {*lea_1_x32}
     (expr_list:REG_EQUIV (plus:SI (subreg:SI (reg:DI 1 dx) 0)
            (const_int 8 [0x8]))
        (nil)))

(insn 1024 1023 588 34 (set (reg:DI 1 dx)
        (zero_extend:DI (reg:SI 1 dx))) spooles.c:291 112
{*zero_extendsidi2_rex64}
     (expr_list:REG_EQUIV (zero_extend:DI (plus:SI (subreg:SI (reg:DI 1 dx) 0)
                (const_int 8 [0x8])))
        (nil)))

(insn 588 1024 589 34 (set (mem:DF (reg:DI 1 dx) [4 MEM[base: b_96(D), index:
D.15020_278, step: 8, offset: 0B]+0 S8 A64])
        (reg:DF 0 ax [orig:340 D.14980 ] [340])) spooles.c:291 106
{*movdf_internal_rex64}
     (nil))

[Bug rtl-optimization/49114] [x32] 454.calculix in SPEC CPU 2006 failed

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vmakarov at redhat dot com
          Component|target                      |rtl-optimization

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> 2011-05-24 23:14:55 UTC ---
gen_reload has

      if (CONSTANT_P (op1) || MEM_P (op1) || GET_CODE (op1) == SUBREG
          || (REG_P (op1)
              && REGNO (op1) >= FIRST_PSEUDO_REGISTER)
          || (code != CODE_FOR_nothing
              && !insn_operand_matches (code, 2, op1)))
        tem = op0, op0 = op1, op1 = tem; 

When IN is

(plus:SI (subreg:SI (reg/v/f:DI 182 [ b ]) 0)
    (const_int 8 [0x8]))

OP0 is SUBREG.  Swapping seems odd since we prefer SUBREG as OP0.
I am testing this patch

@@ -8528,7 +8528,9 @@ gen_reload (rtx out, rtx in, int opnum, enum reload_type
type)

       code = optab_handler (add_optab, GET_MODE (out));

-      if (CONSTANT_P (op1) || MEM_P (op1) || GET_CODE (op1) == SUBREG
+      if (((CONSTANT_P (op1) || MEM_P (op1))
+       && GET_CODE (op0) != SUBREG)
+      || GET_CODE (op1) == SUBREG
       || (REG_P (op1)
           && REGNO (op1) >= FIRST_PSEUDO_REGISTER)
       || (code != CODE_FOR_nothing

[Bug rtl-optimization/49114] [x32] 454.calculix in SPEC CPU 2006 failed

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> 2011-05-24 23:17:02 UTC ---
Bad reload:

Reloads for insn # 588
Reload 0: reload_in (DI) = (reg/v/f:DI 182 [ b ]) 
        GENERAL_REGS, RELOAD_FOR_OPERAND_ADDRESS (opnum = 0) 
        reload_in_reg: (reg/v/f:DI 182 [ b ]) 
        reload_reg_rtx: (reg:DI 1 dx)
Reload 1: reload_in (DI) = (zero_extend:DI (plus:SI (subreg:SI (reg/v/f:DI 182
[ b ]) 0)
                                                        (const_int 8 [0x8])))
        GENERAL_REGS, RELOAD_FOR_OPERAND_ADDRESS (opnum = 0) 
        reload_in_reg: (zero_extend:DI (plus:SI (subreg:SI (reg/v/f:DI 182 [ b
]) 0)
                                                        (const_int 8 [0x8])))
        reload_reg_rtx: (reg:DI 1 dx)
Reload 2: reload_out (DF) = (mem:DF (zero_extend:DI (plus:SI (subreg:SI
(reg/v/f:DI 182 [ b ]) 0)
                                                            (const_int 8
[0x8]))) [4 MEM[base: b_96(D), index: D.15020_278, step: 8, offset: 0B]+0 S8
A64])
        NO_REGS, RELOAD_FOR_OUTPUT (opnum = 0), optional
        reload_out_reg: (mem:DF (zero_extend:DI (plus:SI (subreg:SI (reg/v/f:DI
182 [ b ]) 0)
                                                            (const_int 8
[0x8]))) [4 MEM[base: b_96(D), index: D.15020_278, step: 8, offset: 0B]+0 S8
A64])

leads to

(insn 1017 587 1020 34 (set (reg:DI 1 dx)
        (mem/c:DI (plus:DI (reg/f:DI 7 sp)
                (const_int 112 [0x70])) [5 %sfp+-208 S8 A64])) spooles.c:291 62
{*movdi_internal_rex64}
     (nil))

(insn 1020 1017 1022 34 (set (reg:SI 1 dx)
        (const_int 8 [0x8])) spooles.c:291 64 {*movsi_internal}
     (nil))

(insn 1022 1020 1023 34 (set (reg:SI 1 dx)
        (reg:SI 1 dx)) spooles.c:291 64 {*movsi_internal}
     (nil))

(insn 1023 1022 1024 34 (set (reg:SI 1 dx)
        (plus:SI (reg:SI 1 dx)
            (const_int 8 [0x8]))) spooles.c:291 248 {*lea_1_x32}
     (expr_list:REG_EQUIV (plus:SI (subreg:SI (reg:DI 1 dx) 0)
            (const_int 8 [0x8]))
        (nil)))

(insn 1024 1023 588 34 (set (reg:DI 1 dx)
        (zero_extend:DI (reg:SI 1 dx))) spooles.c:291 112
{*zero_extendsidi2_rex64}
     (expr_list:REG_EQUIV (zero_extend:DI (plus:SI (subreg:SI (reg:DI 1 dx) 0)
                (const_int 8 [0x8])))
        (nil)))

(insn 588 1024 589 34 (set (mem:DF (reg:DI 1 dx) [4 MEM[base: b_96(D), index:
D.15020_278, step: 8, offset: 0B]+0 S8 A64])
        (reg:DF 0 ax [orig:340 D.14980 ] [340])) spooles.c:291 106
{*movdf_internal_rex64}
     (nil))

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #5 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2011-05-27 13:39:28 UTC ---
Author: hjl
Date: Fri May 27 13:39:25 2011
New Revision: 174333

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=174333
Log:
Properly handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

2011-05-24  H.J. Lu  <hongjiu.lu@intel.com>

    PR rtl-optimization/49114
    * reload1.c (gen_reload): Properly handle
    (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

Modified:
    branches/x32/gcc/ChangeLog.x32
    branches/x32/gcc/reload1.c

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #6 from Ulrich Weigand <uweigand at gcc dot gnu.org> 2011-06-29 12:15:20 UTC ---
Author: uweigand
Date: Wed Jun 29 12:15:08 2011
New Revision: 175631

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175631
Log:
    PR rtl-optimization/49114
    * reload.c (struct replacement): Remove SUBREG_LOC member.
    (push_reload): Do not set it.
    (push_replacement): Likewise.
    (subst_reload): Remove dead code.
    (copy_replacements): Remove assertion.
    (copy_replacements_1): Do not handle SUBREG_LOC.
    (move_replacements): Likewise.
    (find_replacement): Remove dead code.  Use reload_adjust_reg_for_mode.
    Detect subregs via recursive descent instead of via SUBREG_LOC.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/reload.c

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #7 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2011-06-29 13:32:42 UTC ---
Author: hjl
Date: Wed Jun 29 13:32:40 2011
New Revision: 175636

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175636
Log:
Don't handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

2011-06-27  H.J. Lu  <hongjiu.lu@intel.com>

    PR rtl-optimization/49114
    * reload1.c (gen_reload): Don't handle
    (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int))).

Modified:
    branches/x32/gcc/ChangeLog.x32
    branches/x32/gcc/reload1.c

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #8 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2011-06-29 13:33:25 UTC ---
Author: hjl
Date: Wed Jun 29 13:33:23 2011
New Revision: 175637

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175637
Log:
Remove SUBREG_LOC member from struct replacement.

2011-06-28  Ulrich Weigand  <Ulrich.Weigand@de.ibm.com>

    PR rtl-optimization/49114
    * reload.c (struct replacement): Remove SUBREG_LOC member.
    (push_reload): Do not set it.
    (push_replacement): Likewise.
    (subst_reload): Remove dead code.
    (copy_replacements): Remove assertion.
    (copy_replacements_1): Do not handle SUBREG_LOC.
    (move_replacements): Likewise.
    (find_replacement): Remove dead code.  Use reload_adjust_reg_for_mode.
    Detect subregs via recursive descent instead of via SUBREG_LOC.

Modified:
    branches/x32/gcc/ChangeLog.x32
    branches/x32/gcc/reload.c

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[pthaugen at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

Pat Haugen <pthaugen at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pthaugen at gcc dot
                   |                            |gnu.org, uweigand at gcc
                   |                            |dot gnu.org

--- Comment #9 from Pat Haugen <pthaugen at gcc dot gnu.org> 2011-06-29 15:58:57 UTC ---
Trunk now fails to build on PPC with the following:

/home/gccbuild/gcc_trunk_anonsvn/gcc/gcc/reload.c: In function ‘push_reload’:
/home/gccbuild/gcc_trunk_anonsvn/gcc/gcc/reload.c:926:28: error: variable
‘out_subreg_loc’ set but not used [-Werror=unused-but-set-variable]
/home/gccbuild/gcc_trunk_anonsvn/gcc/gcc/reload.c:926:8: error: variable
‘in_subreg_loc’ set but not used [-Werror=unused-but-set-variable]

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #11 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-29 16:17:38 UTC ---
(In reply to comment #9)
> Trunk now fails to build on PPC with the following:
> 
> /home/gccbuild/gcc_trunk_anonsvn/gcc/gcc/reload.c: In function ‘push_reload’:
> /home/gccbuild/gcc_trunk_anonsvn/gcc/gcc/reload.c:926:28: error: variable
> ‘out_subreg_loc’ set but not used [-Werror=unused-but-set-variable]
> /home/gccbuild/gcc_trunk_anonsvn/gcc/gcc/reload.c:926:8: error: variable
> ‘in_subreg_loc’ set but not used [-Werror=unused-but-set-variable]

Can you try the patch I uploaded?

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #10 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-29 16:17:03 UTC ---
Created attachment 24633
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24633
A patch to restore bootstrap

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #12 from Ulrich Weigand <uweigand at gcc dot gnu.org> 2011-06-29 16:19:14 UTC ---
Author: uweigand
Date: Wed Jun 29 16:19:08 2011
New Revision: 175652

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175652
Log:
    PR rtl-optimization/49114
    * reload.c (push_reload): Define in_subreg_loc and out_subreg_loc
    only if LIMIT_RELOAD_CLASS to avoid -Werror build breaks.

Modified:
    trunk/gcc/reload.c

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #13 from Ulrich Weigand <uweigand at gcc dot gnu.org> 2011-06-29 16:24:28 UTC ---
(In reply to comment #10)
> Created attachment 24633 [details]
> A patch to restore bootstrap

Huh, sorry for the duplicate patch ... I hadn't seen yours.

[Bug rtl-optimization/49114] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[pthaugen at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

--- Comment #14 from Pat Haugen <pthaugen at gcc dot gnu.org> 2011-06-29 18:21:23 UTC ---
Working fine now, thx.

[Bug rtl-optimization/49114] [x32] Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int)))

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49114

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|Reload failed to handle     |[x32] Reload failed to
                   |(set reg:X (plus:X          |handle (set reg:X (plus:X
                   |(subreg:X (reg:Y) 0)        |(subreg:X (reg:Y) 0)
                   |(const_int)))               |(const_int)))

--- Comment #15 from H.J. Lu <hjl.tools at gmail dot com> 2011-08-02 17:07:22 UTC ---
Fixed.